mangos-mirror/server
0
0
Fork 0
mirror of https://github.com/mangosfour/server.git synced 2025-12-12 19:37:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

[11877] Remove check for quest_template if QuestSort and SkillId match

Browse source 
Signed-off-by: Schmoozerd <schmoozerd@scriptdev2.com>
This commit is contained in:
virusav 2012-01-16 18:26:42 +01:00 • committed by Schmoozerd
parent 14b001ff2a
commit 16b244373a
3 changed files with 1 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/game/ObjectMgr.cpp
View file

@ -3782,17 +3782,6 @@ void ObjectMgr::LoadQuests()
qinfo->GetQuestId(),qinfo->ZoneOrSort); qinfo->GetQuestId(),qinfo->ZoneOrSort);
// no changes, quest not dependent from this value but can have problems at client (note some may be 0, we must allow this so no check) // no changes, quest not dependent from this value but can have problems at client (note some may be 0, we must allow this so no check)
} }
//check for proper RequiredSkill value (skill case)
if (uint32 skill_id = SkillByQuestSort(-int32(qinfo->ZoneOrSort)))
{
if (qinfo->RequiredSkill != skill_id)
{
sLog.outErrorDb("Quest %u has `ZoneOrSort` = %i but `RequiredSkill` does not have a corresponding value (%u).",
qinfo->GetQuestId(),qinfo->ZoneOrSort,skill_id);
//override, and force proper value here?
}
}
} }
// RequiredClasses, can be 0/CLASSMASK_ALL_PLAYABLE to allow any class // RequiredClasses, can be 0/CLASSMASK_ALL_PLAYABLE to allow any class

19
src/game/SharedDefines.h
View file

@ -2386,25 +2386,6 @@ inline SkillType SkillByLockType(LockType locktype)
return SKILL_NONE; return SKILL_NONE;
} }
inline uint32 SkillByQuestSort(int32 QuestSort)
{
switch(QuestSort)
{
case QUEST_SORT_HERBALISM: return SKILL_HERBALISM;
case QUEST_SORT_FISHING: return SKILL_FISHING;
case QUEST_SORT_BLACKSMITHING: return SKILL_BLACKSMITHING;
case QUEST_SORT_ALCHEMY: return SKILL_ALCHEMY;
case QUEST_SORT_LEATHERWORKING: return SKILL_LEATHERWORKING;
case QUEST_SORT_ENGINEERING: return SKILL_ENGINEERING;
case QUEST_SORT_TAILORING: return SKILL_TAILORING;
case QUEST_SORT_COOKING: return SKILL_COOKING;
case QUEST_SORT_FIRST_AID: return SKILL_FIRST_AID;
case QUEST_SORT_JEWELCRAFTING: return SKILL_JEWELCRAFTING;
case QUEST_SORT_INSCRIPTION: return SKILL_INSCRIPTION;
}
return 0;
}
enum SkillCategory enum SkillCategory
{ {
SKILL_CATEGORY_ATTRIBUTES = 5, SKILL_CATEGORY_ATTRIBUTES = 5,

2
src/shared/revision_nr.h
View file

@ -1,4 +1,4 @@
#ifndef __REVISION_NR_H__ #ifndef __REVISION_NR_H__
#define __REVISION_NR_H__ #define __REVISION_NR_H__
#define REVISION_NR "11876" #define REVISION_NR "11877"
#endif // __REVISION_NR_H__ #endif // __REVISION_NR_H__