mangos-mirror/server
0
0
Fork 0
mirror of https://github.com/mangosfour/server.git synced 2025-12-14 16:37:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

[7396] Fixed crash at group disband after some player invite decline and offline.

Browse source 
Correctly cleanup invites list at decline.
This commit is contained in:
VladimirMangos 2009-03-07 07:48:14 +03:00
parent 2159dee379
commit 1727657ab5
3 changed files with 7 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

20
src/game/GroupHandler.cpp
View file

@ -215,26 +215,16 @@ void WorldSession::HandleGroupDeclineOpcode( WorldPacket & /*recv_data*/ )
Group *group = GetPlayer()->GetGroupInvite(); Group *group = GetPlayer()->GetGroupInvite();
if (!group) return; if (!group) return;
// remember leader if online
Player *leader = objmgr.GetPlayer(group->GetLeaderGUID()); Player *leader = objmgr.GetPlayer(group->GetLeaderGUID());
/** error handling **/ // uninvite, group can be deleted
GetPlayer()->UninviteFromGroup();
if(!leader || !leader->GetSession()) if(!leader || !leader->GetSession())
return; return;
/********************/
// everything's fine, do it
if(!group->IsCreated())
{
// note: this means that if you invite more than one person
// and one of them declines before the first one accepts
// all invites will be cleared
// fixme: is that ok ?
group->RemoveAllInvites();
delete group;
}
GetPlayer()->SetGroupInvite(NULL);
// report
WorldPacket data( SMSG_GROUP_DECLINE, 10 ); // guess size WorldPacket data( SMSG_GROUP_DECLINE, 10 ); // guess size
data << GetPlayer()->GetName(); data << GetPlayer()->GetName();
leader->GetSession()->SendPacket( &data ); leader->GetSession()->SendPacket( &data );

2
src/shared/revision_nr.h
View file

@ -1,4 +1,4 @@
#ifndef __REVISION_NR_H__ #ifndef __REVISION_NR_H__
#define __REVISION_NR_H__ #define __REVISION_NR_H__
#define REVISION_NR "7395" #define REVISION_NR "7396"
#endif // __REVISION_NR_H__ #endif // __REVISION_NR_H__