diff --git a/src/game/ObjectMgr.cpp b/src/game/ObjectMgr.cpp index 2e20342af..b88796107 100644 --- a/src/game/ObjectMgr.cpp +++ b/src/game/ObjectMgr.cpp @@ -883,36 +883,36 @@ void ObjectMgr::LoadEquipmentTemplates() { sEquipmentStorage.Load(); - for(uint32 i=0; i< sEquipmentStorage.MaxEntry; ++i) + for(uint32 i=0; i < sEquipmentStorage.MaxEntry; ++i) { EquipmentInfo const* eqInfo = sEquipmentStorage.LookupEntry(i); - if(!eqInfo) + if (!eqInfo) continue; - for(uint8 j=0; j<3; j++) + for(uint8 j = 0; j < 3; ++j) { - if(!eqInfo->equipentry[j]) + if (!eqInfo->equipentry[j]) continue; ItemEntry const *dbcitem = sItemStore.LookupEntry(eqInfo->equipentry[j]); - if(!dbcitem) + if (!dbcitem) { sLog.outErrorDb("Unknown item (entry=%u) in creature_equip_template.equipentry%u for entry = %u, forced to 0.", eqInfo->equipentry[j], j+1, i); const_cast(eqInfo)->equipentry[j] = 0; continue; } - if(dbcitem->InventoryType != INVTYPE_WEAPON && - dbcitem->InventoryType != INVTYPE_SHIELD && - dbcitem->InventoryType != INVTYPE_RANGED && - dbcitem->InventoryType != INVTYPE_2HWEAPON && - dbcitem->InventoryType != INVTYPE_WEAPONMAINHAND && - dbcitem->InventoryType != INVTYPE_WEAPONOFFHAND && - dbcitem->InventoryType != INVTYPE_HOLDABLE && - dbcitem->InventoryType != INVTYPE_THROWN && - dbcitem->InventoryType != INVTYPE_RANGEDRIGHT) + if (dbcitem->InventoryType != INVTYPE_WEAPON && + dbcitem->InventoryType != INVTYPE_SHIELD && + dbcitem->InventoryType != INVTYPE_RANGED && + dbcitem->InventoryType != INVTYPE_2HWEAPON && + dbcitem->InventoryType != INVTYPE_WEAPONMAINHAND && + dbcitem->InventoryType != INVTYPE_WEAPONOFFHAND && + dbcitem->InventoryType != INVTYPE_HOLDABLE && + dbcitem->InventoryType != INVTYPE_THROWN && + dbcitem->InventoryType != INVTYPE_RANGEDRIGHT) { sLog.outErrorDb("Item (entry=%u) in creature_equip_template.equipentry%u for entry = %u is not equipable in a hand, forced to 0.", eqInfo->equipentry[j], j+1, i); const_cast(eqInfo)->equipentry[j] = 0; @@ -4406,20 +4406,20 @@ void ObjectMgr::LoadSpellScripts() //check for correct spellEffect bool found = false; - for(int i=0; i<3; ++i) + for(int i = 0; i < MAX_EFFECT_INDEX; ++i) { // skip empty effects - if( !spellInfo->Effect[i] ) + if (!spellInfo->Effect[i]) continue; - if( spellInfo->Effect[i] == SPELL_EFFECT_SCRIPT_EFFECT ) + if (spellInfo->Effect[i] == SPELL_EFFECT_SCRIPT_EFFECT) { found = true; break; } } - if(!found) + if (!found) sLog.outErrorDb("Table `spell_scripts` has unsupported spell (Id: %u) without SPELL_EFFECT_SCRIPT_EFFECT (%u) spell effect",itr->first,SPELL_EFFECT_SCRIPT_EFFECT); } } @@ -4459,7 +4459,7 @@ void ObjectMgr::LoadEventScripts() SpellEntry const * spell = sSpellStore.LookupEntry(i); if (spell) { - for(int j=0; j<3; ++j) + for(int j = 0; j < MAX_EFFECT_INDEX; ++j) { if( spell->Effect[j] == SPELL_EFFECT_SEND_EVENT ) { @@ -7957,11 +7957,11 @@ void ObjectMgr::LoadTrainerSpell() // calculate learned spell for profession case when stored cast-spell trainerSpell.learnedSpell = spell; - for(int i = 0; i <3; ++i) + for(int i = 0; i < MAX_EFFECT_INDEX; ++i) { - if(spellinfo->Effect[i] != SPELL_EFFECT_LEARN_SPELL) + if (spellinfo->Effect[i] != SPELL_EFFECT_LEARN_SPELL) continue; - if(SpellMgr::IsProfessionOrRidingSpell(spellinfo->EffectTriggerSpell[i])) + if (SpellMgr::IsProfessionOrRidingSpell(spellinfo->EffectTriggerSpell[i])) { trainerSpell.learnedSpell = spellinfo->EffectTriggerSpell[i]; break; diff --git a/src/game/Player.cpp b/src/game/Player.cpp index 3afeca776..e93cbe37c 100644 --- a/src/game/Player.cpp +++ b/src/game/Player.cpp @@ -7205,9 +7205,9 @@ void Player::CastItemCombatSpell(Unit* Target, WeaponAttackType attType) uint32 enchant_id = item->GetEnchantmentId(EnchantmentSlot(e_slot)); SpellItemEnchantmentEntry const *pEnchant = sSpellItemEnchantmentStore.LookupEntry(enchant_id); if(!pEnchant) continue; - for (int s=0;s<3;s++) + for (int s = 0; s < 3; ++s) { - if(pEnchant->type[s]!=ITEM_ENCHANTMENT_TYPE_COMBAT_SPELL) + if (pEnchant->type[s]!=ITEM_ENCHANTMENT_TYPE_COMBAT_SPELL) continue; SpellEntry const *spellInfo = sSpellStore.LookupEntry(pEnchant->spellid[s]); @@ -7302,7 +7302,7 @@ void Player::CastItemUseSpell(Item *item,SpellCastTargets const& targets,uint8 c uint32 enchant_id = item->GetEnchantmentId(EnchantmentSlot(e_slot)); SpellItemEnchantmentEntry const *pEnchant = sSpellItemEnchantmentStore.LookupEntry(enchant_id); if(!pEnchant) continue; - for (int s=0;s<3;s++) + for (int s = 0; s < 3; ++s) { if(pEnchant->type[s]!=ITEM_ENCHANTMENT_TYPE_USE_SPELL) continue; diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp index 6d618b2ba..4808255d3 100644 --- a/src/game/SpellEffects.cpp +++ b/src/game/SpellEffects.cpp @@ -1677,7 +1677,7 @@ void Spell::EffectDummy(SpellEffectIndex eff_idx) if (!pEnchant) return; - for (int s=0;s<3;s++) + for (int s = 0; s < 3; ++s) { if (pEnchant->type[s]!=ITEM_ENCHANTMENT_TYPE_COMBAT_SPELL) continue; diff --git a/src/game/SpellMgr.cpp b/src/game/SpellMgr.cpp index 3057981b8..1b2595ba1 100644 --- a/src/game/SpellMgr.cpp +++ b/src/game/SpellMgr.cpp @@ -1872,7 +1872,7 @@ SpellEntry const* SpellMgr::SelectAuraRankForPlayerLevel(SpellEntry const* spell return spellInfo; bool needRankSelection = false; - for(int i=0;i<3;++i) + for(int i = 0; i < MAX_EFFECT_INDEX; ++i) { if (IsPositiveEffect(spellInfo->Id, SpellEffectIndex(i)) && ( spellInfo->Effect[i] == SPELL_EFFECT_APPLY_AURA || @@ -2340,7 +2340,7 @@ void SpellMgr::LoadSpellScriptTarget() continue; bool found = false; - for(int j=0; j<3; ++j) + for(int j = 0; j < MAX_EFFECT_INDEX; ++j) { if( spellInfo->EffectImplicitTargetA[j] == TARGET_SCRIPT || spellInfo->EffectImplicitTargetA[j] != TARGET_SELF && spellInfo->EffectImplicitTargetB[j] == TARGET_SCRIPT ) { @@ -2617,7 +2617,7 @@ bool SpellMgr::IsSpellValid(SpellEntry const* spellInfo, Player* pl, bool msg) bool need_check_reagents = false; // check effects - for(int i=0; i<3; ++i) + for(int i = 0; i < MAX_EFFECT_INDEX; ++i) { switch(spellInfo->Effect[i]) { diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp index ad758c8f7..fbe389383 100644 --- a/src/game/Unit.cpp +++ b/src/game/Unit.cpp @@ -6439,13 +6439,15 @@ bool Unit::HandleDummyAuraProc(Unit *pVictim, uint32 damage, Aura* triggeredByAu case 54939: { // Lookup base amount mana restore - for (int i=0; i<3;++i) + for (int i = 0; i < MAX_EFFECT_INDEX; ++i) + { if (procSpell->Effect[i] == SPELL_EFFECT_ENERGIZE) { int32 mana = procSpell->EffectBasePoints[i]; CastCustomSpell(this, 54986, NULL, &mana, NULL, true, castItem, triggeredByAura); break; } + } return true; } // Sacred Shield (buff) @@ -12849,9 +12851,9 @@ uint32 Unit::GetCastingTimeForBonus( SpellEntry const *spellProto, DamageEffectT bool DirectDamage = false; bool AreaEffect = false; - for ( uint32 i=0; i<3;++i) + for (uint32 i = 0; i < MAX_EFFECT_INDEX; ++i) { - switch ( spellProto->Effect[i] ) + switch (spellProto->Effect[i]) { case SPELL_EFFECT_SCHOOL_DAMAGE: case SPELL_EFFECT_POWER_DRAIN: @@ -12862,7 +12864,7 @@ uint32 Unit::GetCastingTimeForBonus( SpellEntry const *spellProto, DamageEffectT DirectDamage = true; break; case SPELL_EFFECT_APPLY_AURA: - switch ( spellProto->EffectApplyAuraName[i] ) + switch (spellProto->EffectApplyAuraName[i]) { case SPELL_AURA_PERIODIC_DAMAGE: case SPELL_AURA_PERIODIC_HEAL: @@ -12879,12 +12881,12 @@ uint32 Unit::GetCastingTimeForBonus( SpellEntry const *spellProto, DamageEffectT break; } - if(IsAreaEffectTarget(Targets(spellProto->EffectImplicitTargetA[i])) || IsAreaEffectTarget(Targets(spellProto->EffectImplicitTargetB[i]))) + if (IsAreaEffectTarget(Targets(spellProto->EffectImplicitTargetA[i])) || IsAreaEffectTarget(Targets(spellProto->EffectImplicitTargetB[i]))) AreaEffect = true; } // Combined Spells with Both Over Time and Direct Damage - if ( overTime > 0 && CastingTime > 0 && DirectDamage ) + if (overTime > 0 && CastingTime > 0 && DirectDamage) { // mainly for DoTs which are 3500 here otherwise uint32 OriginalCastTime = GetSpellCastTime(spellProto); @@ -12893,22 +12895,22 @@ uint32 Unit::GetCastingTimeForBonus( SpellEntry const *spellProto, DamageEffectT // Portion to Over Time float PtOT = (overTime / 15000.0f) / ((overTime / 15000.0f) + (OriginalCastTime / 3500.0f)); - if ( damagetype == DOT ) + if (damagetype == DOT) CastingTime = uint32(CastingTime * PtOT); - else if ( PtOT < 1.0f ) + else if (PtOT < 1.0f) CastingTime = uint32(CastingTime * (1 - PtOT)); else CastingTime = 0; } // Area Effect Spells receive only half of bonus - if ( AreaEffect ) + if (AreaEffect) CastingTime /= 2; // -5% of total per any additional effect - for ( uint8 i=0; i 175 ) + if (CastingTime > 175) { CastingTime -= 175; } diff --git a/src/shared/revision_nr.h b/src/shared/revision_nr.h index 3f21ab039..a904bd127 100644 --- a/src/shared/revision_nr.h +++ b/src/shared/revision_nr.h @@ -1,4 +1,4 @@ #ifndef __REVISION_NR_H__ #define __REVISION_NR_H__ - #define REVISION_NR "9414" + #define REVISION_NR "9415" #endif // __REVISION_NR_H__