Fix some codacy detected issues

This commit is contained in:
H0zen 2018-04-12 21:59:49 +01:00 committed by Antz
parent e69d69cfab
commit 603389992d
5 changed files with 17 additions and 17 deletions

View file

@ -6892,12 +6892,12 @@ bool ChatHandler::HandleAccountSetAddonCommand(char* args)
bool ChatHandler::HandleSendMailHelper(MailDraft& draft, char* args)
{
// format: "subject text" "mail text"
char* msgSubject = ExtractQuotedArg(&args);
if (!msgSubject)
std::string msgSubject = ExtractQuotedArg(&args);
if (msgSubject.empty())
{ return false; }
char* msgText = ExtractQuotedArg(&args);
if (!msgText)
std::string msgText = ExtractQuotedArg(&args);
if (msgText.empty())
{ return false; }
// msgSubject, msgText isn't NUL after prev. check
@ -6939,12 +6939,12 @@ bool ChatHandler::HandleSendMassMailCommand(char* args)
bool ChatHandler::HandleSendItemsHelper(MailDraft& draft, char* args)
{
// format: "subject text" "mail text" item1[:count1] item2[:count2] ... item12[:count12]
char* msgSubject = ExtractQuotedArg(&args);
if (!msgSubject)
std::string msgSubject = ExtractQuotedArg(&args);
if (msgSubject.empty())
{ return false; }
char* msgText = ExtractQuotedArg(&args);
if (!msgText)
std::string msgText = ExtractQuotedArg(&args);
if (msgText.empty())
{ return false; }
// extract items
@ -7074,8 +7074,8 @@ bool ChatHandler::HandleSendMoneyHelper(MailDraft& draft, char* args)
{
/// format: "subject text" "mail text" money
char* msgSubject = ExtractQuotedArg(&args);
if (!msgSubject)
std::string msgSubject = ExtractQuotedArg(&args);
if (msgSubject.empty())
{ return false; }
char* msgText = ExtractQuotedArg(&args);