[8702] removed startup-error for creature_loot_template id=0

for alterac valley we've defined Player-loot inside creature_loot_template
with id=0
this hack is used, so that we won't need to create an extra table
player_loot_template for just one case

if later more player-loot will be needed, we should implement
new table and remove this

also added sql-fix for reputation of last commit
it will just fix those which are hated by faction 729/730

sql/characters.sql

@@ -21,7 +21,7 @@
 
 DROP TABLE IF EXISTS `character_db_version`;
 CREATE TABLE `character_db_version` (
-  `required_8596_01_characters_bugreport` bit(1) default NULL
+  `required_8702_01_characters_character_reputation` bit(1) default NULL
 ) ENGINE=MyISAM DEFAULT CHARSET=utf8 ROW_FORMAT=FIXED COMMENT='Last applied sql update to DB';
 
 --

sql/updates/8702_01_characters_character_reputation.sql

@@ -0,0 +1,3 @@
+ALTER TABLE character_db_version CHANGE COLUMN required_8596_01_characters_bugreport required_8702_01_characters_character_reputation bit;
+
+UPDATE character_reputation SET standing = 0 WHERE faction IN (729, 730) AND standing < 0;

sql/updates/Makefile.am

@@ -138,6 +138,7 @@ pkgdata_DATA = \
 	8676_01_mangos_creature_template.sql \
 	8688_01_mangos_creature_template.sql \
 	8693_01_mangos_spell_proc_event.sql \
+	8702_01_characters_character_reputation.sql \
 	README
 
 ## Additional files to include when running 'make dist'
@@ -256,4 +257,5 @@ EXTRA_DIST = \
 	8676_01_mangos_creature_template.sql \
 	8688_01_mangos_creature_template.sql \
 	8693_01_mangos_spell_proc_event.sql \
+	8702_01_characters_character_reputation.sql \
 	README

src/game/LootMgr.cpp

@@ -1093,6 +1093,10 @@ void LoadLootTemplates_Creature()
     for(LootIdSet::const_iterator itr = ids_setUsed.begin(); itr != ids_setUsed.end(); ++itr)
         ids_set.erase(*itr);
 
+    // for alterac valley we've defined Player-loot inside creature_loot_template id=0
+    // this hack is used, so that we won't need to create an extra table player_loot_template for just one case
+    ids_set.erase(0);
+
     // output error for any still listed (not referenced from appropriate table) ids
     LootTemplates_Creature.ReportUnusedIds(ids_set);
 }

src/shared/revision_nr.h

@@ -1,4 +1,4 @@
 #ifndef __REVISION_NR_H__
 #define __REVISION_NR_H__
- #define REVISION_NR "8701"
+ #define REVISION_NR "8702"
 #endif // __REVISION_NR_H__

src/shared/revision_sql.h

@@ -1,6 +1,6 @@
 #ifndef __REVISION_SQL_H__
 #define __REVISION_SQL_H__
- #define REVISION_DB_CHARACTERS "required_8596_01_characters_bugreport"
+ #define REVISION_DB_CHARACTERS "required_8702_01_characters_character_reputation"
  #define REVISION_DB_MANGOS "required_8693_01_mangos_spell_proc_event"
  #define REVISION_DB_REALMD "required_8332_01_realmd_realmcharacters"
 #endif // __REVISION_SQL_H__