From 6e1605caefd69037da5a1f75c0e4970df0414443 Mon Sep 17 00:00:00 2001 From: NoFantasy Date: Mon, 15 Nov 2010 22:35:12 +0100 Subject: [PATCH] [10725] Add a few comments for SUMMON_PROP_TYPE_CRITTER Signed-off-by: NoFantasy --- src/game/DBCStructure.h | 2 +- src/game/SpellEffects.cpp | 3 +++ src/shared/revision_nr.h | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/game/DBCStructure.h b/src/game/DBCStructure.h index 2ac228f18..ba3ff0522 100644 --- a/src/game/DBCStructure.h +++ b/src/game/DBCStructure.h @@ -1632,7 +1632,7 @@ struct SummonPropertiesEntry uint32 Group; // 1, enum SummonPropGroup uint32 FactionId; // 2, 14 rows > 0 uint32 Type; // 3, enum SummonPropType - uint32 Slot; // 4, if type = SUMMON_PROP_TYPE_TOTEM, its actual slot 0-6 + uint32 Slot; // 4, if type = SUMMON_PROP_TYPE_TOTEM, its actual slot (0-6). Slot may have other uses, selection of pet type in some cases? uint32 Flags; // 5, enum SummonPropFlags }; diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp index bdb4e0475..b65087a03 100644 --- a/src/game/SpellEffects.cpp +++ b/src/game/SpellEffects.cpp @@ -4094,6 +4094,9 @@ void Spell::EffectSummonType(SpellEffectIndex eff_idx) break; case SUMMON_PROP_TYPE_CRITTER: DoSummonCritter(eff_idx, summon_prop->FactionId); + // TODO: differenciate between regular 'critter' types and 'critter' that are fighting. + // prop_id == 387 are expected to be fighting (but they have postfix 'companion'). + // Note: summon_prop->Slot==6 may be related to how selection are done for this type (need more research) break; case SUMMON_PROP_TYPE_PHASING: case SUMMON_PROP_TYPE_LIGHTWELL: diff --git a/src/shared/revision_nr.h b/src/shared/revision_nr.h index f9488c1b8..8dc075551 100644 --- a/src/shared/revision_nr.h +++ b/src/shared/revision_nr.h @@ -1,4 +1,4 @@ #ifndef __REVISION_NR_H__ #define __REVISION_NR_H__ - #define REVISION_NR "10724" + #define REVISION_NR "10725" #endif // __REVISION_NR_H__