mirror of
https://github.com/mangosfour/server.git
synced 2025-12-15 19:37:02 +00:00
[10378] Avoid double lookup member slot in guild operations.
Also more wide use ObjectGuid in guild code and fixed some uint32->uint64 guid assigns.
This commit is contained in:
parent
f2406c1962
commit
9b3d37f0cf
9 changed files with 189 additions and 190 deletions
|
|
@ -3564,7 +3564,7 @@ bool ChatHandler::HandleGuildUninviteCommand(char *args)
|
|||
if (!targetGuild)
|
||||
return false;
|
||||
|
||||
targetGuild->DelMember (target_guid);
|
||||
targetGuild->DelMember(target_guid);
|
||||
return true;
|
||||
}
|
||||
|
||||
|
|
@ -3593,7 +3593,11 @@ bool ChatHandler::HandleGuildRankCommand(char *args)
|
|||
if (newrank > targetGuild->GetLowestRank ())
|
||||
return false;
|
||||
|
||||
targetGuild->ChangeRank (target_guid,newrank);
|
||||
MemberSlot* slot = targetGuild->GetMemberSlot(target_guid);
|
||||
if (!slot)
|
||||
return false;
|
||||
|
||||
slot->ChangeRank(newrank);
|
||||
return true;
|
||||
}
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue