mangos-mirror/server
0
0
Fork 0
mirror of https://github.com/mangosfour/server.git synced 2025-12-16 04:37:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

[7330] Code warnings and style cleanups. Some bugs fixes.

Browse source 
1) comparison singed and unsigned values
2) redundent includes
3) wrong constructor :-part field initilization
4) unused not-/*name*/-guarded args in template/virtual functions that not required like args.
5) explicitly list not implemented achievement types.

Also bugs fixed:
1) Drop wrong phase mask 0 check in WorldObject::InSamePhase.
2) ArenaTeamMember::ModifyPersonalRating incorrect work with move points in negative with infinity values in result.
3) ArenaTeam::SaveToDB code send uint64 value to string with arg format %u.
This commit is contained in:
VladimirMangos 2009-02-23 22:25:41 +03:00
parent 373af9905d
commit 9b3daf3933
26 changed files with 211 additions and 141 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/game/debugcmds.cpp
View file

@ -88,9 +88,6 @@ bool ChatHandler::HandleSetPoiCommand(const char* args)
return false;
uint32 icon = atol(icon_text);
if ( icon < 0 )
icon = 0;
uint32 flags = atol(flags_text);
sLog.outDetail("Command : POI, NPC = %u, icon = %u flags = %u", target->GetGUIDLow(), icon,flags);
@ -264,8 +261,7 @@ bool ChatHandler::HandleSendChatMsgCommand(const char* args)
bool ChatHandler::HandleSendQuestPartyMsgCommand(const char* args)
{
uint32 msg = atol((char*)args);
if (msg >= 0)
m_session->GetPlayer()->SendPushToPartyResponse(m_session->GetPlayer(), msg);
m_session->GetPlayer()->SendPushToPartyResponse(m_session->GetPlayer(), msg);
return true;
}
@ -282,8 +278,7 @@ bool ChatHandler::HandleGetLootRecipient(const char* /*args*/)
bool ChatHandler::HandleSendQuestInvalidMsgCommand(const char* args)
{
uint32 msg = atol((char*)args);
if (msg >= 0)
m_session->GetPlayer()->SendCanTakeQuestResponse(msg);
m_session->GetPlayer()->SendCanTakeQuestResponse(msg);
return true;
}
@ -583,11 +578,11 @@ bool ChatHandler::HandleSpawnVehicle(const char* args)
return true;
}
bool ChatHandler::HandleSendLargePacketCommand(const char* args)
bool ChatHandler::HandleSendLargePacketCommand(const char* /*args*/)
{
const char* stuffingString = "This is a dummy string to push the packet's size beyond 128000 bytes. ";
std::ostringstream ss;
while(strlen(ss.str().c_str()) < 128000)
while(ss.str().size() < 128000)
ss << stuffingString;
SendSysMessage(ss.str().c_str());
return true;