mangos-mirror/server
0
0
Fork 0
mirror of https://github.com/mangosfour/server.git synced 2025-12-14 16:37:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

[8009] Pass const string reference to functions where possible.

Browse source 
Avoids creating an unnecessary copy of strings.

Signed-off-by: hunuza <hunuza@gmail.com>
This commit is contained in:
hunuza 2009-06-14 11:12:34 +02:00
parent 55836df62f
commit a34e7857f1
5 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/game/Unit.cpp
View file

@ -10495,7 +10495,7 @@ void CharmInfo::SetPetNumber(uint32 petnumber, bool statwindow)
m_unit->SetUInt32Value(UNIT_FIELD_PETNUMBER, 0); m_unit->SetUInt32Value(UNIT_FIELD_PETNUMBER, 0);
} }
void CharmInfo::LoadPetActionBar( std::string data ) void CharmInfo::LoadPetActionBar(const std::string& data )
{ {
InitPetActionBar(); InitPetActionBar();

2
src/game/Unit.h
View file

@ -823,7 +823,7 @@ struct CharmInfo
//return true if successful //return true if successful
bool AddSpellToActionBar(uint32 spellid, ActiveStates newstate = ACT_DECIDE); bool AddSpellToActionBar(uint32 spellid, ActiveStates newstate = ACT_DECIDE);
bool RemoveSpellFromActionBar(uint32 spell_id); bool RemoveSpellFromActionBar(uint32 spell_id);
void LoadPetActionBar(std::string data); void LoadPetActionBar(const std::string& data);
void BuildActionBar(WorldPacket* data); void BuildActionBar(WorldPacket* data);
void SetSpellAutocast(uint32 spell_id, bool state); void SetSpellAutocast(uint32 spell_id, bool state);
void SetActionBar(uint8 index, uint32 spellOrAction,ActiveStates type) void SetActionBar(uint8 index, uint32 spellOrAction,ActiveStates type)

2
src/game/World.h
View file

@ -404,7 +404,7 @@ class World
void SetAllowMovement(bool allow) { m_allowMovement = allow; } void SetAllowMovement(bool allow) { m_allowMovement = allow; }
/// Set a new Message of the Day /// Set a new Message of the Day
void SetMotd(std::string motd) { m_motd = motd; } void SetMotd(const std::string& motd) { m_motd = motd; }
/// Get the current Message of the Day /// Get the current Message of the Day
const char* GetMotd() const { return m_motd.c_str(); } const char* GetMotd() const { return m_motd.c_str(); }

2
src/game/WorldSession.h
View file

@ -58,7 +58,7 @@ struct AccountData
struct AddonInfo struct AddonInfo
{ {
AddonInfo(std::string name, uint8 enabled, uint32 crc) AddonInfo(const std::string& name, uint8 enabled, uint32 crc)
{ {
Name = name; Name = name;
Enabled = enabled; Enabled = enabled;

2
src/shared/revision_nr.h
View file

@ -1,4 +1,4 @@
#ifndef __REVISION_NR_H__ #ifndef __REVISION_NR_H__
#define __REVISION_NR_H__ #define __REVISION_NR_H__
#define REVISION_NR "8008" #define REVISION_NR "8009"
#endif // __REVISION_NR_H__ #endif // __REVISION_NR_H__