[10297] Drop CMSG_SET_FACTION_CHEAT support.

No reported long time and now finaly broken by spillover rep changes.
This commit is contained in:
VladimirMangos 2010-07-31 07:16:42 +04:00
parent 7bdf05901d
commit af50d03f16
6 changed files with 2 additions and 36 deletions

View file

@ -808,32 +808,6 @@ void WorldSession::HandleSetFactionAtWar( WorldPacket & recv_data )
GetPlayer()->GetReputationMgr().SetAtWar(repListID, flag); GetPlayer()->GetReputationMgr().SetAtWar(repListID, flag);
} }
//I think this function is never used :/ I dunno, but i guess this opcode not exists
void WorldSession::HandleSetFactionCheat( WorldPacket & /*recv_data*/ )
{
sLog.outError("WORLD SESSION: HandleSetFactionCheat, not expected call, please report.");
/*
uint32 FactionID;
uint32 Standing;
recv_data >> FactionID;
recv_data >> Standing;
std::list<struct Factions>::iterator itr;
for(itr = GetPlayer()->factions.begin(); itr != GetPlayer()->factions.end(); ++itr)
{
if(itr->ReputationListID == FactionID)
{
itr->Standing += Standing;
itr->Flags = (itr->Flags | 1);
break;
}
}
*/
GetPlayer()->GetReputationMgr().SendStates();
}
void WorldSession::HandleMeetingStoneInfo( WorldPacket & /*recv_data*/ ) void WorldSession::HandleMeetingStoneInfo( WorldPacket & /*recv_data*/ )
{ {
DEBUG_LOG( "WORLD: Received CMSG_MEETING_STONE_INFO" ); DEBUG_LOG( "WORLD: Received CMSG_MEETING_STONE_INFO" );

View file

@ -320,7 +320,7 @@ OpcodeHandler opcodeTable[NUM_MSG_TYPES] =
/*0x123*/ { "SMSG_SET_FACTION_VISIBLE", STATUS_NEVER, &WorldSession::Handle_ServerSide }, /*0x123*/ { "SMSG_SET_FACTION_VISIBLE", STATUS_NEVER, &WorldSession::Handle_ServerSide },
/*0x124*/ { "SMSG_SET_FACTION_STANDING", STATUS_NEVER, &WorldSession::Handle_ServerSide }, /*0x124*/ { "SMSG_SET_FACTION_STANDING", STATUS_NEVER, &WorldSession::Handle_ServerSide },
/*0x125*/ { "CMSG_SET_FACTION_ATWAR", STATUS_LOGGEDIN, &WorldSession::HandleSetFactionAtWar }, /*0x125*/ { "CMSG_SET_FACTION_ATWAR", STATUS_LOGGEDIN, &WorldSession::HandleSetFactionAtWar },
/*0x126*/ { "CMSG_SET_FACTION_CHEAT", STATUS_LOGGEDIN, &WorldSession::HandleSetFactionCheat }, /*0x126*/ { "CMSG_SET_FACTION_CHEAT", STATUS_NEVER, &WorldSession::Handle_Deprecated },
/*0x127*/ { "SMSG_SET_PROFICIENCY", STATUS_NEVER, &WorldSession::Handle_ServerSide }, /*0x127*/ { "SMSG_SET_PROFICIENCY", STATUS_NEVER, &WorldSession::Handle_ServerSide },
/*0x128*/ { "CMSG_SET_ACTION_BUTTON", STATUS_LOGGEDIN, &WorldSession::HandleSetActionButtonOpcode }, /*0x128*/ { "CMSG_SET_ACTION_BUTTON", STATUS_LOGGEDIN, &WorldSession::HandleSetActionButtonOpcode },
/*0x129*/ { "SMSG_ACTION_BUTTONS", STATUS_NEVER, &WorldSession::Handle_ServerSide }, /*0x129*/ { "SMSG_ACTION_BUTTONS", STATUS_NEVER, &WorldSession::Handle_ServerSide },

View file

@ -194,12 +194,6 @@ void ReputationMgr::SendInitialReputations()
m_player->SendDirectMessage(&data); m_player->SendDirectMessage(&data);
} }
void ReputationMgr::SendStates() const
{
for(FactionStateList::const_iterator itr = m_factions.begin(); itr != m_factions.end(); ++itr)
SendState(&(itr->second));
}
void ReputationMgr::SendVisible(FactionState const* faction) const void ReputationMgr::SendVisible(FactionState const* faction) const
{ {
if(m_player->GetSession()->PlayerLoading()) if(m_player->GetSession()->PlayerLoading())

View file

@ -121,7 +121,6 @@ class ReputationMgr
void SendInitialReputations(); void SendInitialReputations();
void SendForceReactions(); void SendForceReactions();
void SendState(FactionState const* faction) const; void SendState(FactionState const* faction) const;
void SendStates() const;
private: // internal helper functions private: // internal helper functions
void Initialize(); void Initialize();

View file

@ -402,7 +402,6 @@ class MANGOS_DLL_SPEC WorldSession
void HandleAreaTriggerOpcode(WorldPacket& recvPacket); void HandleAreaTriggerOpcode(WorldPacket& recvPacket);
void HandleSetFactionAtWar( WorldPacket & recv_data ); void HandleSetFactionAtWar( WorldPacket & recv_data );
void HandleSetFactionCheat( WorldPacket & recv_data );
void HandleSetWatchedFactionOpcode(WorldPacket & recv_data); void HandleSetWatchedFactionOpcode(WorldPacket & recv_data);
void HandleSetFactionInactiveOpcode(WorldPacket & recv_data); void HandleSetFactionInactiveOpcode(WorldPacket & recv_data);

View file

@ -1,4 +1,4 @@
#ifndef __REVISION_NR_H__ #ifndef __REVISION_NR_H__
#define __REVISION_NR_H__ #define __REVISION_NR_H__
#define REVISION_NR "10296" #define REVISION_NR "10297"
#endif // __REVISION_NR_H__ #endif // __REVISION_NR_H__