mirror of
https://github.com/mangosfour/server.git
synced 2025-12-15 01:37:00 +00:00
[7917] Spell effect with SPELL_AURA_MOD_SPELL_CRIT_CHANCE always possitive with possitive aura value.
This commit is contained in:
parent
902252c1e9
commit
e8cd008005
2 changed files with 5 additions and 3 deletions
|
|
@ -339,11 +339,13 @@ bool IsPositiveEffect(uint32 spellId, uint32 effIndex)
|
||||||
case SPELL_AURA_MOD_STAT:
|
case SPELL_AURA_MOD_STAT:
|
||||||
case SPELL_AURA_MOD_DAMAGE_DONE: // dependent from bas point sign (negative -> negative)
|
case SPELL_AURA_MOD_DAMAGE_DONE: // dependent from bas point sign (negative -> negative)
|
||||||
case SPELL_AURA_MOD_HEALING_DONE:
|
case SPELL_AURA_MOD_HEALING_DONE:
|
||||||
{
|
|
||||||
if(spellproto->CalculateSimpleValue(effIndex) < 0)
|
if(spellproto->CalculateSimpleValue(effIndex) < 0)
|
||||||
return false;
|
return false;
|
||||||
break;
|
break;
|
||||||
}
|
case SPELL_AURA_MOD_SPELL_CRIT_CHANCE:
|
||||||
|
if(spellproto->CalculateSimpleValue(effIndex) > 0)
|
||||||
|
return true; // some expected possitive spells have SPELL_ATTR_EX_NEGATIVE
|
||||||
|
break;
|
||||||
case SPELL_AURA_ADD_TARGET_TRIGGER:
|
case SPELL_AURA_ADD_TARGET_TRIGGER:
|
||||||
return true;
|
return true;
|
||||||
case SPELL_AURA_PERIODIC_TRIGGER_SPELL:
|
case SPELL_AURA_PERIODIC_TRIGGER_SPELL:
|
||||||
|
|
|
||||||
|
|
@ -1,4 +1,4 @@
|
||||||
#ifndef __REVISION_NR_H__
|
#ifndef __REVISION_NR_H__
|
||||||
#define __REVISION_NR_H__
|
#define __REVISION_NR_H__
|
||||||
#define REVISION_NR "7916"
|
#define REVISION_NR "7917"
|
||||||
#endif // __REVISION_NR_H__
|
#endif // __REVISION_NR_H__
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue