Commit graph

3147 commits

Author SHA1 Message Date
Ambal
190c5e6338 [8744] Fix 'warning: deleting ‘void*’ is undefined' in SqlOperations.h/SqlOperations.cpp, caused by [8736]. Thanks to Shendor for pointing the problem.
Signed-off-by: Ambal <pogrebniak@gala.net>
2009-10-27 11:41:58 +02:00
VladimirMangos
a4e3b3e6aa [8743] Fix cooldowns for passive spells
Passive spell cooldowns only for client show.
It sets by  non passive spells with same category
triggered from passive spell auras or in code explictly.

* Ignore cooldown at cast passive spells
* Not set coldowns at passive spell cast itself.
2009-10-27 09:29:01 +03:00
VladimirMangos
15ab6794d3 [8742] Avoid aura remove triggered casts and packets send at logout/delete
This is must speedup logout and solve some crash cases or unexpected effects.

Also fix some nonsense code with memory lost possibility.
2009-10-27 04:20:11 +03:00
NoFantasy
7b6f4accd1 [8741] Remove trainer npcflags for player that can not train from npc.
Tracking of class and profession trainer should then work as expected client side, but database still need to apply flag values based on trainer function.

Signed-off-by: NoFantasy <nofantasy@nf.no>
2009-10-27 01:26:45 +01:00
VladimirMangos
10a659a29a [8740] Make alreadyLoaded specialization select at call more explicit.
Base at report that at some platforms specialzation ignored (??).
2009-10-26 15:34:59 +03:00
VladimirMangos
6cab460f6b [8739] Call cleaniup code at remove player from Map before Map unlinking.
This fix crash when aura remove triggering spell casting.
2009-10-26 15:23:08 +03:00
VladimirMangos
a22c0f05b9 [8738] Restore some some VC90 build modes work after TBB lib add.
* Avoid use broken lib/*_debug_nppch dirs, and restore use debug version for debug_nopch mode
* Avoid unexpected creating .tlb file in bin subdirs
* Set to correct values debug_nopch mode fields in tbb.vcproj
2009-10-26 12:37:37 +03:00
VladimirMangos
eef1faa7ff [8737] Restore some some VC80 build modes work after TBB lib add.
* Hide TBB libs in lib dirs in simialr way as hide ACE libs.
* Avoid use broken lib/*_debug_nppch dirs, and restore use debug version for debug_nopch mode
* Avoid unexpected creating .tlb fiel in bin subdirs
* Restore 0.15-dev as current developed release version in mangosd.
* Set to correct values debug_nopch mode fields in tbb.vcproj

Note: VC90 fixes will be in next commit.
2009-10-26 10:58:12 +03:00
Ambal
b0ea8848a5 [8736] operator new[] based version of strdup() function to get bonuses from Intel Memory allocator mainly in DB code
Signed-off-by: Ambal <pogrebniak@gala.net>
2009-10-26 01:05:12 +02:00
Ambal
a2ed351365 [8735] New memory allocator for MaNGOS, based on Intel Threading Building Blocks library. Performance gains depend greatly on OS you use!
You should add two libraries into your server binaries:
tbb.so/tbbmalloc.so on *nix and tbb(_debug).dll/tbbmalloc(_debug).dll on Windows!!!

Define USE_STANDARD_MALLOC while compiling 'framework' project to use OS' default memory allocator!

Signed-off-by: Ambal <pogrebniak@gala.net>
2009-10-26 00:59:35 +02:00
VladimirMangos
9e4b833054 [8734] Re-implement talent 31789
* Allow apply to enemies of attacked party member
* Correctly apply effect to 3 attackers
2009-10-25 10:18:48 +03:00
VladimirMangos
9746a97174 [8733] Access to chat channels by case-insensitive channel names.
But remember original case of name.
2009-10-25 08:48:20 +03:00
darkstalker
04911535ea [8732] Not drop at save action button assign to value that recently removed from it.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-10-25 06:53:31 +03:00
VladimirMangos
fad1fb92f4 [8731] Restore difficulty 1 spawn use for creatures with special difficulty 1 versions.
* Rename creature template `heroic_entry` => `difficulty_entry_1`
  Possible need add 2 more fields for 2-3
* Use 2 more EventAI EFLAG_* flags for 2-3 difficulty support, update checks.
* Update area trigger code.

Note: support for specialized creature version for difficulties 2-3 not added yet
      and will be used same as difficulty 1 mode.

TODO: Rename area triggers heroickey/etc fields ?
2009-10-25 06:23:00 +03:00
ApoC
00c2035cc7 [8730] Fixed spell 51770 after my recent changes in auras trigger system.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-25 03:33:09 +01:00
VladimirMangos
ce3d0170f6 [8729] Fix crash added in [8725]. Sorry. 2009-10-25 03:25:02 +03:00
Andeeria
8baee4a73f [8728] Store current realmid for online account in realm Db account table.
* Replace old `account`.`online` field by `account`.`active_realm_id`.
  It have 0 if account offline.

NOTE: this break all scripts that use `online` field for seelct online characters, and it required update.
But from other side this reolve
* Bug with reset online state active realm at restart another realm.
* Let easy select online accounts for some specific realm if need.

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-10-25 03:22:08 +03:00
ApoC
b078ceb76c [8727] Cleanup in ObjectAccessor::FindHelper.
* This commit also restores compilability under some platforms and gcc combinations.

Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-25 00:56:52 +02:00
Corfen
54a9c6c225 [8726] Fixed spell proc flags for spell 62600.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-24 23:11:01 +02:00
VladimirMangos
b49cf2df28 [8725] Fixed bug with crash at forced logout in combat in instance.
In fact this old bug that just has been triggred more often after recent code changes,
so with some chance maybe some other logout related crashes fixed.

Also small cleanup in avoid double calls RemoveFromWorld and CleanupsBeforeDelete in some cases.
2009-10-25 01:07:28 +04:00
KiriX
7323966738 [8724] Fixed energize amount for spell 48389
Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-24 20:47:42 +02:00
VladimirMangos
1101e3f6b0 [8723] Rename table achievement_criteria_data => achievement_criteria_requirement
And make related renames in code for types, variables and functions.
To make more clear difference achievement createria type from old achievment criteria data type
in DB and code.
2009-10-24 20:50:20 +04:00
tomrus88
de73c52a77 Fixed group loot display bug. 2009-10-24 19:31:38 +04:00
ApoC
f451298784 [8722] Fixed possible creash.
Crash may happen if you try summon pet by spell and certain NPC is not in
your DB (than CreatureInfo* is NULL).

Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-24 14:01:48 +02:00
leak
455a053b3d [8721] Allow guildmaster to withdraw money before first bank tab is purchased.
Attached sql file needs to be run to repair existing structure.

Signed-off-by: unknown <Jakub@.(none)>
2009-10-24 09:25:44 +02:00
tomrus88
3cc7f36006 [8720] Added missing ReqItem 5 and 6 to database.
(backported from commit 7a722b8)
2009-10-24 04:07:57 +04:00
VladimirMangos
e79aa4dee2 [8719] More early detection possible crash sources at object deletion.
* If object still in world at delete
* If object still listed in client update queue

Possible with this crash reports will more informative and let find porblem.
2009-10-24 02:09:35 +04:00
VladimirMangos
d7ae5e3af0 [8718] Remove most GetObjectInWorld functions and move some map local to Map
Also mape pet guid counter per-map (in different expecte to be global pet number)
2009-10-24 01:16:40 +04:00
ApoC
40b0a2cd92 [8717] Fixed SPELL_EFFECT_TAMECREATURE broken after [8686]
Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-23 22:31:16 +02:00
NoFantasy
67c991b216 [8716] Update of enum HolidayIds, add missing names
Signed-off-by: NoFantasy <nofantasy@nf.no>
2009-10-23 21:39:28 +02:00
AlexDereka
f286a2e64e [8715] Fixed possible crashes and some typos 2009-10-23 17:09:51 +04:00
Ambal
b1888bb343 [8714] Fix compilation on Visual Studio 2010 Beta 2.
Signed-off-by: Ambal <pogrebniak@gala.net>
2009-10-23 14:51:35 +03:00
Corfen
2588cdabfc [8713] Moved calculation of absorbed damage amount into Unit::HandleProcTriggerSpell for spell 62606.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-23 00:33:06 +02:00
ApoC
86a6c952b8 [8712] Fixed commit [8708]
* Now final damage counted also with spell bonus.

Thanks Corfen for pointing this out.

Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-22 21:56:42 +02:00
ChipLeo
64316d2af1 [8711] Fixed work .instance unbind all
C-strings can't be compared by !=

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-10-22 22:14:12 +04:00
VladimirMangos
b942616ded [8710] Make vehicle guid counter per-map local.
Also update/drop/move to Map some dependent functions.
2009-10-22 17:43:41 +04:00
Tassader2
53b6d28a24 [8709] Show spell miss as miss, not resist
Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-22 14:20:31 +02:00
KiriX
eb26f27a21 [8708] Fixed damage from spell 1120 and ranks when target below or equal 25% of health.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-22 14:12:56 +02:00
balrok
f1800cf05a [8707] fixed linuxbuild 2009-10-22 13:23:49 +02:00
VladimirMangos
3860ec2427 [8706] Fixed typo in [8704] 2009-10-22 06:51:40 +04:00
VladimirMangos
d482193cea [8705] Move DynamicObject guid counting from global levle to map.
This is first step in guid counting for map local object types at map level.
Map local countin let
1) have more wide guid space and then more seldom have problems with guid counter overflow
2) possible implement (later) restart map at guid overflow without server shutdown.
3) let use static guids (not for DynamicOPbject that not stored in DB anyway) in instances instead dynamic allocated.
2009-10-22 06:49:35 +04:00
VladimirMangos
ae9ae781fc [8704] Fixed crash "Object with certain key already in but objects are different!"
* It possible in result events
1) creature move from respawn grid
2) respawn grid unloaded by timeout, but not current grid for creature
3) respawn grid loaded before current grid with creture unload
4) duplicate attempt created in old grid

Until recent guid storage move to map we create duplicate creature with same (continent) or diff guid.
With diff strange possible result in it work in world.
2009-10-22 06:43:23 +04:00
VladimirMangos
f762b57fea [8703] Remove templates and some used functions from ObjectAccessor. 2009-10-22 02:46:16 +04:00
balrok
69abc9ece4 [8702] removed startup-error for creature_loot_template id=0
for alterac valley we've defined Player-loot inside creature_loot_template
with id=0
this hack is used, so that we won't need to create an extra table
player_loot_template for just one case

if later more player-loot will be needed, we should implement
new table and remove this

also added sql-fix for reputation of last commit
it will just fix those which are hated by faction 729/730
2009-10-21 23:32:45 +02:00
ApoC
b4ea5a6d19 [8701] Fixes and inprovements in pool system.
* Fixed object is removed from guid->object map but still spawned in world under some conditions
* Fixed possibility to spawn already spawned object
* Fixed objects despawning (missing part for explicitly chanced objects added)

Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-21 23:19:56 +02:00
balrok
f59f7d2a2e [8700] fixed very high reputation in alterac valley
bug happened when one team owned a mine at the end of the match
and is caused through an uninitalized variable
through that players could gain or lose _very_ much reputation

sorry :x
2009-10-21 21:45:16 +02:00
laise
211b50ce63 [8699] Fix instance bound difficulty selection.
This must fix crashes at enter to heroic mode instances and raids showup after client switch.

Signed-off-by: VladimirMangos <vladimir@getmangos.com>

I can't repeat crashes with existed raids after changes apply but possible in some cases
need drop content of related DB table for resolve some crashes.
2009-10-21 22:51:43 +04:00
balrok
97c94cff56 fixed problems with isInvisbleForAlive
removed redundant check at MoveInLos
this check is already done in istargetableForAttack
thx to NoFantasy

fixed in isVisibleForOrDetect that isInvisbleForAlive
wasn't checked.. and therefore all spiritserviceprovider
got visible
thx to NetSky
2009-10-21 20:00:07 +02:00
VladimirMangos
ffc2f97d3b [8698] Better way check spawn masks (for specific map)
Also note: i has been totaly wrong in my last notes in prev. commit :((
Old "heroic raid" fine map to new normal 25. Sorry.
2009-10-21 21:31:44 +04:00
VladimirMangos
314687092f [8697] Check creature/GO spawnmask at server loading.
Note: this check only out of range value in masks.
And not detect another possible DB problem:

After last client switch spawnmask for raid dengeons need update for correct work.
In expection same spawn for both normal or both heroic modes:
raid normal spawn mask from 1 to 3 (1|2)
raid heroic spawn mask from 2 to 12 (4|8)

In other case heroic spawn will used for 25-normal mode with empty heroic mode instances.
2009-10-21 19:25:51 +04:00