Case description: Spell save fail at attempt save into `character_spell` "new" spell loaded from DB
with exactly same settings after it learned from spell cast triggered by loading another spell from DB.
Reapeatable for shamans with known talent 16268.
Also speedup code with remove redundent Player::_removeSpell function.
56342 and ranks - proc on trap activation
34497 and ranks - mana restor amount
56333 and ranks
add some cast as trap activation
Signed-off-by: DiSlord <dislord@nomail.com>
* Fixed profession unlearn using skill unlearn button in skill list
* Update action bar to spell low rank at unlearn spell only for .unlearn command.
This will avoid show unexpected "Learned spell" chat message for low rank at unlearing
high rank and at all ranks unlearning.
* Support Htrade shift link (it created by client at click by crafting profession spell icon in spellbook)
in spell comands.
* Support "all" second arg for .learn for learning not provided spell id but it's all ranks.
* Drop support range for .unlearn command but support instead "all" second arg for unlearn not specific spell id but it's all ranks.
* In .list auras output print spell names as shift links for better readable view.
* Add to beggining Chat.cpp lists all supported by commands shift-links (client generated and server-side)
* Mark spells learned in result character creating, another spell learning, skill grow,
quest reward as dependent and not store its in `character_spell`.
* Prevent re-learning known spell in expected state
* Prevent re-learning low rank spell as active if higher rank known.
* New type of non-stacked ranked spells check: skill dependent spell bonuses.
* Activate (show propetly and cast if need) lesser spell rank
for non-stackable in spellbooks spells at unlearn high rank
Fixed work all Huter traps target selection
More check in ObjectAccessor::Get Object
More generic work 22 TARGET_CASTER_COORDINATES target type
Signed-off-by: DiSlord <dislord@nomail.com>
Implement SPELL_AURA_PERIODIC_HEALTH_FUNNEL
Apply SPELL_AURA_PERIODIC_HEALTH_FUNNEL mod to aura periodic time
Add support SPELL_ATTR_EX5_START_PERIODIC_AT_APPLY flag
Apply duration mod to channeling spells
Fix mage 44401 and correct drop its charge
Signed-off-by: DiSlord <dislord@nomail.com>
Preper at loading more stricted taxi nodes mask for normal taxi network
with excliuded quest only nodes (used from spells with SPELL_EFFECT_SEND_TAXI.
Use prepered mask at search nearest to taxi master taxi node.
