Commit graph

1047 commits

Author SHA1 Message Date
Antz
9d20fe2b32 Initial project location adjustment 2020-02-17 09:22:43 +00:00
Antz
f1c9e0f94b [Sync] Project header sync 2020-02-17 09:22:26 +00:00
Schmoozerd
ae7348f6b0 [12774] Merged cmangos last changes, special thanks for xfurry, Dramacydal, cala, Schmoozerd,
I'm not taking any credits of this commit.

Implement spell effects 62042, 62278 and 64767
Also limit the targets for 62577 and 62603
----------
Update git_id to reflect recent sql formatting changes
----------
Update to a safer code version and also add GO caster scenarios
----------
Allow aura 62038 to stack at every 3 seconds
----------
Improve handling of TargetMMGen
This will have impact on Chase and Follow Movement.
----------
* Refactor code to check if a new position is required for the MMGen into the new function RequiresNewPosition
* Refactor code to get the current targeted distance into function GetDynamicTargetDistance
* Change ChaseMMGen (angle = 0.0f case) chase to best contact point, not zero angle.

Thanks to Cala and X-Savior for testing. Special thanks to cala for also suggesting improved values for the magic numbers
----------
Improve ObjectPosSelector
Now a spot already occupied by the searcher will be prefered
----------
Get rid of bounding radius in GetNearPoint[2D] and ObjectPosSelector
----------
This changes how ObjectPosSelector is used.
It changes the way how the functions Object::GetNearPoint and Object::GetNearPoint2d behave.
----------
So you need to check all places where these functions are used if they are still used correctly.
----------
Especially check your scripts!
----------
Remove not required duplicate indexes
----------
Implement TARGET_92 as TARGET_SUMMONER
This target is used only as TargetA and the related spells are used only by temporary summoned creatures
----------
Implement some spell effects used by Hodir in Ulduar
Dummy spells 62797, 63499, 63545 and 64543
Periodic dummy auras: 61968, 62038, 62039 and 65272
Limit targets for spells: 62797, 63545, 64543, 62476 and 62477
----------
Implement some spells used at Algalon encounter
Spell aura entries 64345, 62018 and 64412
Positive target exception for spell 64996
Aura stacking exception for spells 62169, 62168, 65250 and 64417
----------
Implement effect for spell 63633
----------
EventAI - Ingame output of script state
----------
With this the command .npc aiinfo will give more output about the current state.
Remark that this output is only given if the LogFilter for EventAIDev mode is disabled
----------
FindGit.cmake already ships with CMake
No reason for us to ship it too. Also, we had an outdated version which
had not been used anyway, because we set the include path in such a way,
that the CMake delivered version is always found first.
----------
FindOpenSSL.cmake already ships with CMake
No reason for us to ship it too. Also, we had an outdated version which
had not been used anyway, because we set the include path in such a way,
that the CMake delivered version is always found first.
----------
EventAI - Add more developing error output
----------
Fix some target-type handling for EventAI
Also increase log-output for bad target-types
----------
Fix crash due to bad compiler (author Xfurry)
----------
Add special condition id for Ulduar
Will be used to check the availability of the siege vehicles for players
----------
Update spells 62374 and 62907
* limit spell targets of spell 62374
* implement spell effect for spell 62907
----------
Remove effect for spell 64503
Will be handled in script library. For details please check 8502cdfa64
----------
Implement spells 64489 and 64673
Both are used by Auriaya (Ulduar)
----------
Implement some spells for Ignis the Furnace Master
Spell entries: 62717, 62381, 62488, 62707, 64475 and 64503
----------
Implement spells 61187 and 61190
----------
CMake: generic way to build a script library
Added new parameter INCLUDE_BINDINGS_DIR which can be set to the name of a
folder inside src/bindings/.

Includes the script library in src/bindings/ with the defined name.
The name must correspond to the name of the folder and the folder must contain
a valid CMakeLists.txt

Note: if you currently use a script library, you will probably get a merge
problem on src/bindings/CMakeLists.txt as you will have modified this file
manually. Please use the new version of this file and rerun CMake once with the
parameter -DINCLUDE_BINDINGS_DIR=ScriptDev2 (if you are not using SD2 but
another script library, replace ScriptDev2 with the name of the folder in
src/bindings/).

If you do not use a script library you should not have any merge problems
and you don't need to do anything.
----------
Add CMake source groups to target 'game'
This is the exact same grouping as it is currently in the VC 2012 files.
These groupings will have to be refactored at some point as they are not
very logical.
----------
Add CMake source groups to target 'framework'
This is the exact same grouping as it is currently in the VC 2012 files.
This is part of cmangos/issues#67
----------
Add CMake source groups to target 'shared'
This is the exact same grouping as it is currently in the VC 2012 files.
----------
Add new parameter 'expansion' to command 'account create'
----------
Update some Sunwell Plateau spells

Limit targets and allow positive effect for spell 46650
Implement effect for spells 46289 and 46637
Remove effect for spell 44845 - will be handled in script library
----------
Implement some custom use for Effect Activate Object spells
This will fix the summoning events for the Wind Stones, Ice Stones, Skettis bosses and quest 11865
----------
Sync mangos.sql with other versions
----------
Redump sql databases to unify formatting
The main reason for this was because classic/cata has updated the sql formatting and manually syncing would be a pain so redumping from master->tbc->classic->cata is easier.

Only the formatting was changed. The values were not changed at all.

mysqldump was used however manual modifications had to be done.

Dump the database:
C:/mysql/bin/mysqldump.exe mangos > sql/mangos.sql

Split insert values into multiple rows:
Replace "),(" with "),\n("
Replace "VALUES (" with "VALUES\n("

Remove the character sets by replacing them with an empty string

Custom formatting of mangos.sql:
Move db_version to the very top
Create all dbscripts_on_* tables based on dbscripts_on_creature_movement
Preserve our custom insert formatting of spell_affect (tbc/classic), spell_bonus_data, spell_chain, spell_elixir, spell_proc_event, spell_proc_item_enchant, spell_template, spell_threat
Remove autoincrement values from insert values of pet_name_generation and remove AUTO_INCREMENT=261 value from its table structure

Custom formatting of characters.sql:
Move character_db_version to the very top

Custom formatting of realmd.sql:
Move realmd_db_version to the very top
----------
Immediately remove corpses when ForcedDespawn is used
Thanks to Neotmiren for pointing, special thanks to cala for testing!
----------
Fix use of config values related to quest-status and level
This fixes use of negative value in config values Quests.LowLevelHideDiff and Quests.HighLevelHideDiff
Also add some documentation around the related code
Thanks to Neotmiren for pointing and to cala for testing.
----------
Loot-System: Fix reference loading check
This fixes a false error output for loot references that are only used with spell loot.
Thanks to X-Savior for properly reporting both error messages and use case
----------
Add missing spell 61437 to playercreate spells for bloodelves
Thanks to NeatElves for porting from TC and pointing to this
----------
Fix load bar step for alendarMgr::LoadCalendarsFromDB
----------
Cody Style Improvements
Also remove an unused variable (thanks to Den for this!)
----------
Implement the spells used in the Chess Event encounter
Combat spell entries: 37775, 37824, 39338, 39342, 39341, 39344, 45260
Melee spells: 37142, 37143, 37147, 37149, 37150, 37220, 37227, 37228, 37337, 37339, 37345, 37348
Chess movement spells: 30012, 32312, 37388, 30284, 37144, 37146, 37148, 37151, 37152, 37153
Aura stacking exception: 32261 and 39400
----------
And more hotfixes with these format strings
----------
Hotfix to recent text loading functions
----------
Use possible changed model names with vmap extraction
----------
Fix some warnings
----------
Store how many texts are loaded for validity checks. Use this with EventAI
----------
EventAI: Use generic DoDisplayText and loading of additional text data
----------
Add generic DoDisplayText function and use additional data of dbscripts table
----------
Add const-correctness to Text related functions
----------
Add database changes to support more data for DB Script texts
----------
Add stacking exception for spells 39993 and 40041
----------
Allow spell effect 86 - Activate Object to use the misc value
----------
Allow player pets to swim
----------
Enable resummoning of warlock pets
----------
Do not remove FLY auras on Evade
Also consider npcs which have SPELL_AURA_FLY as being able to fly
----------
EventAI: Improve code
* Drop rather pointless bool to check if the number of assigned events is empty
* Before the phase was resetted on death if and only if the npc has Events defined
* DoMeleeAttackIfReady could have been called even though combat state could have changed while processing events
----------
EventAI: Implement ACTION_T_SET_THROW_MASK (46)
This Action can be used to set which AIEvents should be thrown automatically, if you need more flexibility, you can always use the manual ACTION_TH_THROW_AI_EVENT version.
* Also clean some error-log output a bit.
----------
Forward original caster GUID to script library
----------
Fixup commit 12511 Thanks to Zakamurite for pointing
Also thanks to him for giving a helping hand in correcting the commit
----------
Implement some spells for Felmyst encounter
Spell entries: 45714, 45717 and 45918. Limit targets of spell 45391
Also add stacking exception for auras 45068 and 45582
----------
Fix invisible spirit healers & such on death near them
This fixes an issue that occurs if you die close to a spirit healer/guide.
----------
Fix take ammo for most ranged spells
Fix spells like Arcane Shot not taking ammo while they should
----------
Check cast spell 51690
----------
Fix SpellDamage modifier of SPELL_AURA_MOD_DAMAGE_DONE_CREATURE
This aura modifies a flat value, not a percent value.
----------
Implement proc effect of spells 67712, 67758
related to items 47316, 47477.
----------
Improve proc of spell 50421
----------
Add and implement server-side spell 23770
----------
EventAI: Improve TargetSelection related ErrorLog output
----------
DBScripts Engine: Change behaviour to search for a different npc when using buddy-search
With this an npc buddy will be interpreted as "another npc with entry"
Also toggle command 31 - TERMINATE_SCRIPT to also look only for other npcs of entry
----------
DBScripts Engine: Allow pets as buddy
Add new flag SCRIPT_FLAG_BUDDY_IS_PET (0x20) that will search not for a normal npc with buddy-search, but also for pets
----------
DBScripts Engine: Support buddy search by guid
* Add new `data_flags` flag SCRIPT_FLAG_BUDDY_BY_GUID (0x10)
If this flag is set, the content of `search_distance` is interpreted as db-guid of the requested buddy
* Also switch most error log output to DB-error log output (though this will include false positives)
----------
2020-02-17 09:20:48 +00:00
sanctum32
1b9c1a44ee [12703] Fix spell 61254
* Also rearrange code for Aura::HandleAuraModIncreaseHealth
* Fix some behaviour with SetHealth/SetPower if set to max health/power (original author @Schmoozerd)
2020-02-17 09:20:42 +00:00
sanctum32
9b3c263b27 [12700] Stop movement of dead npcs (original author @Schmoozerd) 2020-02-17 09:20:40 +00:00
sanctum32
1c381f206b [12694] Fix a stupid mistake from me introduced in [12472] \n
(original author @Schmoozerd)
2020-02-17 09:20:36 +00:00
sanctum32
49bcd5a4ad [12685] Add some safety to rare case of target-selection for unreachable
target
Thanks to Atari for reporting and researching this problem
2020-02-17 09:20:31 +00:00
rsa
60a7bec73f [12675] Fix MoveGen's interrupting after last commit
Signed-off-by: Schmoozerd <schmoozerd@cmangos>

(based on commit [12473] - baa6525)
2020-02-17 09:20:25 +00:00
boxa
394be2c5bf [12674] Rework StopMove to not start movement if already stopped
thx to Schmoozerd for hint
thx to rsa for pointing to bug

Signed-off-by: Schmoozerd <schmoozerd@cmangos>
2020-02-17 09:20:24 +00:00
Schmoozerd
de2cc58be9 [12673] Let Taunt behave more expectedly in case we have non-generic orientation settings 2020-02-17 09:20:23 +00:00
sanctum32
ea6eef5a13 [12661] Implemented SMSG_PLAY_ONE_SHOT_ANIM_KIT packet 2020-02-17 09:20:15 +00:00
sanctum32
46d4f07052 [12660] Implement mount capabilities by Shauren.
Also  update AreaFlags enum, implement mount capabilities check at teleport.

----------------------------
commit is partially based on ec5eabdc69
2020-02-17 09:20:14 +00:00
sanctum32
a253344a02 [12659] Fixed mounts 2020-02-17 09:20:13 +00:00
Antz
1997c1e903 Rebase resync 2020-02-17 09:19:44 +00:00
Dramacydal
94e26af71d [c12646] Fix client movement freeze after map change 2020-02-17 07:26:45 +00:00
Dramacydal
4e824f5672 [c12638] Implement SPELL_AURA_MOD_AUTOATTACK_DAMAGE 2020-02-17 01:17:52 +00:00
billy1arm
ef445ea523 [12632] Revert previous commit (see Notes) 2020-02-17 00:54:15 +00:00
Dramacydal
dad1b10c5b [c12626] Fix SMSG_PLAYER_MOVE being broken for players moving on transports 2020-02-17 00:25:02 +00:00
Schmoozerd
dc3de04d62 [c12616] Simplify use of CombatReach 2020-02-17 00:24:44 +00:00
Xfurry
8a3be45af0 [c12611] Implement virtual void HealedBy 2020-02-17 00:23:14 +00:00
Schmoozerd
207359612d [c12609] Fix send-speed opcode sending 2020-02-17 00:21:11 +00:00
Dramacydal
bf5c6b1ddd [c12562] Cleanup Style 2020-02-16 23:12:16 +00:00
Schmoozerd
d275d04145 [c12558] Allow stacking for PERIODIC_DUMMY auras from different casters 2020-02-16 22:37:29 +00:00
Dramacydal
d4f3fed660 [c12546] Fix usage of SpellEquippedItems and SPELL_AURA_MOD_DAMAGE_DONE & SPELL_AURA_MOD_DAMAGE_PERCENT_DONE auras as a result 2020-02-16 21:51:32 +00:00
Schmoozerd
a27787851c [c12537] Update Authorship information
(based on commit [12388] - 037f217)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
2020-02-16 21:27:46 +00:00
Schmoozerd
a05738717a [c12536] Happy New Year 2013
Update authorship information and prepare for easier ways next year

Signed-off-by: Schmoozerd <schmoozerd@cmangos>

(based on commit [12325] - b7dbcda)
2020-02-16 21:25:01 +00:00
kid10
1aaf756c7e [12221] Implement interface for Vehicles
Signed-off-by: Schmoozerd <schmoozerd@cmangos>
2020-02-16 20:42:39 +00:00
kid10
164c2e137b [12220] Improve Initialisation of COMMAND_ATTACK field
This moves the set command of COMMAND_ATTACK out of CharmInfo::InitPetAction bar, so that this function can be used more genericly for other purposes

Signed-off-by: Schmoozerd <cmangos>
2020-02-16 20:42:38 +00:00
kid10
e635569d08 [12219] Add generic stackign exception to vehicle control and linkedAura auras
Note: This might not be correct, but aura stacking needs some other serious research, so this should be ok for now.
Signed-off-by: Schmoozerd <schmoozerd@cmangos>
2020-02-16 20:42:37 +00:00
Yaki Khadafi
832f9b1a46 [12209] Update mana regen to 4.x
Signed-off-by: Yaki Khadafi <elsoldollo@gmail.com>
2020-02-16 20:42:27 +00:00
Yaki Khadafi
8e84b0ff71 [12198] - Remove weapon skillgains, defense skill, thanks @FailzorD for original patch.
- Update dodge, parry, block to cata.
- Some mastery fixes and stylefixes.
- Remove some no longer used functions.

Signed-off-by: Yaki Khadafi <elsoldollo@gmail.com>
2020-02-16 20:42:16 +00:00
stfx
a53ac2aca7 [12152] Remove unused argument from OutdoorPvP::HandlePlayerKillInsideArea 2020-02-16 20:41:30 +00:00
Shyax
6e76dbae3f [12128] Fix more warnings - close #4
* Remove warning: enumeration value '<value>' not handled in switch
* Remove warning: enumeral and non-enumeral type in conditional expression
* Remove warning: too many arguments for format

Signed-off-by: Schmoozerd <schmoozerd@scriptdev2.com>
2020-02-16 20:41:05 +00:00
evil-at-wow
6fa6eb24a5 [12125] Fix some warnings
* Fix compiler warnings "warning: no newline at end of file" (Linux/GCC).
* Fix compiler warnings "warning: '<class>::<member>' will be initialized after <class>::<member>" (Linux/GCC).
* Fix compiler warnings "warning: unused parameter '<param>'" (Linux/GCC).
* Fix a signed/unsigned warning

Signed-off-by: Schmoozerd <schmoozerd@scriptdev2.com>
2020-02-16 20:41:02 +00:00
Schmoozerd
02ce53b7dd [12124] Improve error output for Pets without proper faction
Also fix typo in EventAi doc, thanks to stfx for pointing
2020-02-16 20:41:00 +00:00
rsa
de95d1d480 [12123] Move BattleGround code to separate BattleGround directory. Also some corrects to unload BG's 2020-02-16 20:40:57 +00:00
Reamer
e90caf7349 [12111] Add Unit::KnockBackWithAngle function
Also wrap up the packet sending for a knockbacked player to WorldSession::SendKnockBack

Signed-off-by: Schmoozerd <schmoozerd@scriptdev2.com>
2020-02-16 20:23:03 +00:00
kid10
88e18898e2 [12108] Add RemoveSpellsCausingAura to remove auras of type and caster 2020-02-16 20:00:05 +00:00
Yaki Khadafi
3153bd2129 [0146] Cleanup deprecated item mods and combat ratings
Signed-off-by: Yaki Khadafi <ElSolDolLo@gmail.com>
2020-02-16 19:51:43 +00:00
Yaki Khadafi
9a00d62017 [142] Implement worgen transformations
Signed-off-by: Yaki Khadafi <ElSolDolLo@gmail.com>
2020-02-16 19:38:50 +00:00
Xfurry
e955c3bc8f Add Outdoor PvP handlers to various files 2020-02-16 19:05:40 +00:00
Salja
73ec9c2ce4 [0114] Updated "item_template" Thanks Fabi Fix some DBC problems, some clean.
Signed-off-by: Salja <salja2012@hotmail.de>
2020-02-16 16:19:43 +00:00
Yaki Khadafi
a6b1264405 [0113] Again
Signed-off-by: Yaki Khadafi <ElSolDolLo@gmail.com>
2020-02-16 16:19:42 +00:00
Yaki Khadafi
1e11c2af24 [0112] Typo
Signed-off-by: Yaki Khadafi <ElSolDolLo@gmail.com>
2020-02-16 16:19:41 +00:00
Yaki Khadafi
93c5b1cf1d [0111] Implement rest of spell scaling
Signed-off-by: Yaki Khadafi <ElSolDolLo@gmail.com>
2020-02-16 16:19:19 +00:00
Yaki Khadafi
e0a8e30cc3 [0093] Enabled and updated lots of opcodes, mostly spell-related. All structures checked .
Signed-off-by: Yaki Khadafi <ElSolDolLo@gmail.com>
2020-02-16 15:32:25 +00:00
Yaki Khadafi
19d898c836 [0091] Define SPELL_ATTR_EX8_IGNORE_TARGET_FOR_COMBO_POINTS
Signed-off-by: Yaki Khadafi <ElSolDolLo@gmail.com>
2020-02-16 15:31:09 +00:00
Salja
10d308bbaf [0085] Updated critical heal to Cataclysm. Thanks Sovak
Signed-off-by: Salja <salja2012@hotmail.de>
2020-02-16 11:57:04 +00:00
LordJZ
8010d254b6 Fix SMSG_POWER_UPDATE, thanks @Zakamurite for noticing. 2020-02-16 08:29:43 +00:00
Yaki Khadafi
e7d0275ae2 [0067] Set- canfly/forcemoveroot/waterwalk packets, SMSG_PLAY_SPELL_VISUAL
Signed-off-by: Yaki Khadafi <ElSolDolLo@gmail.com>
2020-02-16 08:29:40 +00:00