Commit graph

480 commits

Author SHA1 Message Date
VladimirMangos
f99f477fe8 [8169] Implement new optional table spell_check and console command .debug spellcheck
* Table expected to be store data mirror same data in code:
  - explicit spell ids with related expected spell properties like effects, spell family or auras
  - implicit requirements for select some spell sets like spell family masks, icons or visual values
* For check can be used .debug spellcheck _console_ only command.
* Main purpose table and related command check code parts for outdated data at client switch.
  It also can be used for check data in patch writing time to be sure code correctness.
2009-07-12 22:15:56 +04:00
NetSky
394cf9264d [8153] Fixed some implicit float->int cast warnings.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-07-09 11:10:28 +04:00
ApoC
0f6d312e59 [8140] Fixed dummy spell proc for 31876 and ranks.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-07-07 00:53:55 +02:00
ApoC
fccba20c9d [8139] Implemented aura SPELL_AURA_ABILITY_PERIODIC_CRIT(286).
This commit affects spells 49868, 58435, 63068, 63091, 63503,
64915, 64925.

Signed-off-by: ApoC <apoc@nymfe.net>
2009-07-06 22:48:34 +02:00
ApoC
08f1c95874 [8133] Do not scale with level damage for SPELL_AURA_MOD_DECREASE_SPEED.
May be other auras will need to be excluded also (auras modify AP,
Armor ...) but this one is the most annoying :)

This commit should fix non-movable behavior after being hitted by some
NPC spell with slowing effect.

Signed-off-by: ApoC <apoc@nymfe.net>
2009-07-06 03:30:31 +02:00
ApoC
f064ef9c49 [8124] Fixed removing cooldown of 23922 and ranks by 50227
Signed-off-by: ApoC <apoc@nymfe.net>
2009-07-05 17:36:06 +02:00
m4cm4n
7c5f254012 [8113] Fixed setting mover for Posses/Charm auras and Vehicle enter/exit.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-07-04 12:51:15 +02:00
ApoC
d17a49f6dc [8112] Fixed proc conditions for 63156 and ranks
* Fixed proc spell flags.
* Fixed proc only on victim's certain level of HP.

signed-off-by: ApoC <apoc@nymfe.net>
2009-07-04 11:41:38 +02:00
Lightguard
06dcbce4ee [8110] Implement aura SPELL_AURA_MOD_AOE_DAMAGE_AVOIDANCE (229).
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-07-03 13:41:36 +04:00
Ambal
9f938a9ed4 [8103] More wide use IsInWorld checks and delayed at teleport operations.
* IsInWorld used to prevent return unexpected not in world objects.
* Delayed operations need to process its in world state.

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-07-01 14:00:29 +04:00
VladimirMangos
1baec77845 [8098] Support uint32 spell ids in code.
* Propertly work with uint32 spell ids in player action bar
* Fix in same time bug with not save equipment set button with id==0
* Merge misc field in character_action and playercreateinfo_action to action field as 3 byte
* Propertly load uint32 spell ids from character_spell
* Fixed types for some pet/creature related structure for spell id storing.
2009-06-30 11:25:32 +04:00
Lightguard
df064ebd9f [8082] Update Diminishing Returns.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-06-27 11:32:52 +04:00
Ambient
1b085414ab [8081] Remove player only targeting limitation for spell 25899, 20911 for triggering part.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-06-27 05:58:42 +04:00
VladimirMangos
21a6a26386 [8077] Resolve mixed store and use 2 different flags values types in single field.
* Create new monster move field in Creature class and use it in all cases when expected use MONSTER_MOVE_* flags.
* Store and use MOVEMENTFLAG_* values in field in MovementInfo structure of Player class.
* Cleanups and fix related code.

NOTE: DB in creature_addon store values similar MONSTER_MOVE_* flags, scritps also expected set only this flags.
2009-06-26 01:57:34 +04:00
thenecromancer
00fc1d7593 [8076] Fixed well known walk-after-taxi bug.
Also thanks to jolan, yad02, nos4r2zod for deep reseach problem.

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-06-25 09:17:10 +04:00
SeT
d4017afadd [8068] Fixed crash from 33201 and ranks, remove outdated rank case.
Signed-off-by: SeT <can15@ngs.ru>
(cherry picked from commit e52f1f4e530a435edb156de5083e39b2ef23bbb5)

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-06-22 15:59:47 +04:00
Alez
17a82a063e [8062] Update triggering spell for talent 51625 and ranks.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-06-21 16:27:00 +04:00
XTZGZoReX
9b9fe55981 [8056] Move SMSG_CLEAR_COOLDOWN into function and use it. Other cleanups.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-06-21 03:07:54 +04:00
Den
d97f2bb92f [8055] Now spell 20911 and variations provided only mana percent back.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-06-21 01:31:07 +04:00
Corfen
f018f4c15c [8050] Fixed healing from spell 63108.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-06-20 02:52:11 +02:00
VladimirMangos
0b4c37f751 [8035] Return found guardian in search function. Update caller. 2009-06-17 19:37:08 +04:00
Tanatos
57ac3bdfef [8028] Missing part of [7879] commit.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-06-16 14:11:05 +02:00
Ambal
b76c4c2f3c [8026] Obtain object's map directly by calling appropriate WorldObject::GetMap()/GetBaseMap() functions instead of accessing MapManager. Code cleanups. Big thanks Infinity for tests.
Signed-off-by: AlexDereka <dereka.alex@gmail.com>
2009-06-16 12:47:02 +04:00
VladimirMangos
309ac7ead0 [8023] Move guardian list at Unit level and unsummon guardians at owner-creature death/unload.
This expected to fix well known crash at intances unload with creature with summoned guardians.
Note: this "fix" special case but not original source of problem in general.
2009-06-15 23:46:13 +04:00
Beaste
9d8aa63d5c [8021] Implement triggering part of shaman talent 51483 and ranks.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-06-15 16:37:32 +04:00
nos4r2zod
82d3e2ae7d [8011] Send energize packets in correct order to avoid strange client behaviour.
If you send SMSG_SPELLENERGIZELOG after SMSG_POWER_UPDATE client shows mana gain twice.

Signed-off-by: hunuza <hunuza@gmail.com>
2009-06-14 12:06:50 +02:00
DonTomika
dcba023261 [8010] Show overheal in combat log.
Signed-off-by: hunuza <hunuza@gmail.com>
2009-06-14 11:33:52 +02:00
hunuza
a34e7857f1 [8009] Pass const string reference to functions where possible.
Avoids creating an unnecessary copy of strings.

Signed-off-by: hunuza <hunuza@gmail.com>
2009-06-14 11:21:26 +02:00
ApoC
a8a4836e1a [8000] Corrected calculation of healing amount for 47230 and ranks.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-06-12 15:57:48 +02:00
nos4r2zod
31957a22d6 [7990] Trigering "on hit" combat spell only at related to current hit weapon.
Also check at loading that only weapon item templates have "on hit" spell triggers.

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-06-11 01:29:33 +04:00
tomrus88
1f87157edf Merge commit 'origin/master' into 310
Conflicts:
	src/game/UpdateData.cpp
2009-06-07 21:42:02 +04:00
ApoC
4668323c83 [7973] Implemented proc for 25899.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-06-07 02:16:09 +02:00
ApoC
ffad65fe01 [7972] Fixed 20186 to use base max mana instead of max current mana.
Thx. to Ambient who pointed it out.

Signed-off-by: ApoC <apoc@nymfe.net>
2009-06-07 02:14:28 +02:00
ApoC
30c054ae38 [7965] Implemented proc for 20911 spell.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-06-05 16:23:28 +02:00
ApoC
877f81c37b [7964] Use NULL instead of 0 for "empty" pointers.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-06-05 14:13:22 +02:00
ApoC
5848ada3eb [7963] Fixed energize value for 20186 proc.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-06-05 13:58:38 +02:00
tomrus88
4236f7c75c Merge branch 'master' into 310 2009-06-05 14:54:05 +04:00
ApoC
fb21b00480 [7959] Inserted newline to make gcc happy.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-06-05 03:09:29 +02:00
Lightguard
07fe1cfd04 [7955] Fixed healing amount of 47230 and ranks.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-06-04 21:42:32 +02:00
tomrus88
b9b2e254b5 Merge branch 'master' into 310 2009-06-03 16:03:44 +04:00
NoFantasy
be6e3923d1 [7948] Use SetFaction instead explcit field set, other cleanups.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-06-03 15:35:33 +04:00
tomrus88
cffbb8661b Merge commit 'origin/master' into 310
Conflicts:
	src/game/Player.cpp
	src/game/SpellAuras.cpp
2009-06-02 15:01:26 +04:00
Corfen
454c756025 [7943] Stunned targets should not be immune to fear effects.
Signed-off-by: hunuza <hunuza@gmail.com>
2009-06-02 12:33:59 +02:00
VladimirMangos
7d6bf1fdbf [7932] Store in DB only spell part of pet action bar, set other to default state (reaction saved). 2009-06-01 04:44:02 +04:00
tomrus88
cae3f0a532 Merge commit 'origin/master' into 310
Conflicts:
	src/game/SpellAuras.cpp
2009-05-31 12:16:25 +04:00
VladimirMangos
79dab3dae5 [7922] Implement param2 for ACTION_T_COMBAT_MOVEMENT for allow control start/stop melee combat state for creature at start/stop movement in combat.
Also small fix for avoid unexpected set pet speed to owner speed for non-player case. In player case this hack speed setting still required.
2009-05-31 04:35:38 +04:00
Den
d2e0e3c439 [7919] Aura 50 apply percent to all crit healing amount not only to crit healing bonus.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-05-31 02:33:20 +04:00
VladimirMangos
2a27a44e2a [7918] Improve portability in work with uint64 string format specifiers and in code literals.
* Replace platform seelction MaNGOS code for select format descriptor for uint64 by using ACE define.
  I64FMTD renamed to UI64FMTD for more clear name.
* Add new define UI64LIT (base at ACE seelction) for build portables uint64 literals.
  Please always use UI64LIT(0x00001) instead less portable 0x00001LL
2009-05-30 22:44:20 +04:00
daveh
902252c1e9 [7916] Fixed pet action bar setup.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-05-30 06:08:39 +04:00
tomrus88
e454cb693d Merge branch 'master' into 310
Conflicts:
	src/game/GameObject.h
	src/game/MiscHandler.cpp
	src/game/Player.cpp
	src/game/QueryHandler.cpp
	src/game/QuestHandler.cpp
	src/game/SkillHandler.cpp
	src/game/SpellAuras.cpp
	src/game/SpellEffects.cpp
	src/game/Unit.cpp
	src/game/WorldSession.h
2009-05-29 19:15:43 +04:00