Commit graph

1900 commits

Author SHA1 Message Date
balrok
f59f7d2a2e [8700] fixed very high reputation in alterac valley
bug happened when one team owned a mine at the end of the match
and is caused through an uninitalized variable
through that players could gain or lose _very_ much reputation

sorry :x
2009-10-21 21:45:16 +02:00
laise
211b50ce63 [8699] Fix instance bound difficulty selection.
This must fix crashes at enter to heroic mode instances and raids showup after client switch.

Signed-off-by: VladimirMangos <vladimir@getmangos.com>

I can't repeat crashes with existed raids after changes apply but possible in some cases
need drop content of related DB table for resolve some crashes.
2009-10-21 22:51:43 +04:00
VladimirMangos
ffc2f97d3b [8698] Better way check spawn masks (for specific map)
Also note: i has been totaly wrong in my last notes in prev. commit :((
Old "heroic raid" fine map to new normal 25. Sorry.
2009-10-21 21:31:44 +04:00
VladimirMangos
314687092f [8697] Check creature/GO spawnmask at server loading.
Note: this check only out of range value in masks.
And not detect another possible DB problem:

After last client switch spawnmask for raid dengeons need update for correct work.
In expection same spawn for both normal or both heroic modes:
raid normal spawn mask from 1 to 3 (1|2)
raid heroic spawn mask from 2 to 12 (4|8)

In other case heroic spawn will used for 25-normal mode with empty heroic mode instances.
2009-10-21 19:25:51 +04:00
VladimirMangos
7ffb8e20ff [8696] Replace pure virtual functions for better error output. 2009-10-21 18:11:10 +04:00
VladimirMangos
012b54a63d [8695] Fix negative auras remain time calculation at loading for pets.
In similar ways as recently fixed for players.
2009-10-21 04:50:42 +04:00
balrok
fcf854c0bb [8694] GMs should see units with "invisibleForAlive()" 2009-10-21 00:07:11 +02:00
Corfen
86b60901bf [8693] Fixed glyph 45785
Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-20 23:54:34 +02:00
DonTomika
6a2e23cac0 [8692] Fixed trigger part of spell 31944.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-20 23:40:51 +02:00
balrok
ac6e13d0e3 [8691] fix battleground spiritguides
they are now alive and so some spellchecks got invalid
2009-10-20 23:37:47 +02:00
balrok
20e8982075 [8690] added unit auraFlag variable
this can be used for faster checking if an unit has a specific
aura applied..
also implemented the alive-invisible auras now with this way
2009-10-20 23:37:31 +02:00
balrok
46389e4e1c [8689] implement function Unit::isInvisibleForAlive
with that i've implemented all known auras which makes
units invisible for alive.. but that's currently quite hacky
i think best would be if we could set a unit-flag after those auras
getting applied
2009-10-20 23:37:21 +02:00
balrok
e990d5c509 [8688] proper implementation of creatures ghost-flags
this reverts 8676 (9c50d9e70314b0cd9eb0fe3bac8040d64a9965a5)
the new flag is from wdb-files so your database should be
already alright

also i've dropped the function Player::CanInteractWithNPCs
cause it was used only in one place and didn't seem to make anything
easier

NOTE for this flag:
it just means that the creature can be seen by ghost-players
too..
so they are still visible for alive players.. unless a special
aura or ther unitflag (spiritguide/healer) disables this..
(see next commit for it)
2009-10-20 23:34:13 +02:00
ApoC
58139610eb [8687] Fixes in TARGET_FOCUS_OR_SCRIPTED_GAMEOBJECT.
* Removed my too script check on data load.
* Allow looking up fo DB target also if spell has required focus set.
* Makes DB targets optional not required.

Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-20 23:21:44 +02:00
ApoC
5bae4fccf8 [8686] Fixed logic of triggering spells from SPELL_AURA_PERIODIC_TRIGGER_SPELL and SPELL_AURA_PERIODIC_TRIGGER_SPELL_WITH_VALUE.
This patch should correct target selection for triggered spells
with target type TARGET_SELF.

Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-20 20:13:06 +02:00
NoFantasy
cd43a0a192 [8685] Add a few more creature type_flag enum names (meaning still unknown) 2009-10-20 19:28:36 +02:00
reeshack
efe057112d [8684] Typos in code for talent 30675 and ranks affect at spell 421 ranks 7 & 8 casting.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-10-20 18:37:16 +04:00
VladimirMangos
8271e7eb99 [8683] Correctly update negetive aura duration at loading.
Thanks to ApoC for problem reseach.
2009-10-20 16:45:31 +04:00
VladimirMangos
2db2600d65 [8682] Restore build at Unix/Linux
Not tested, but fix repoted build problem.
2009-10-20 14:53:50 +04:00
NoFantasy
20a5cbcdca [8681] Update one creature type flag name and correct typos in comments.
Signed-off-by: NoFantasy <nofantasy@nf.no>
2009-10-20 11:18:05 +02:00
seirge
f015e77a07 [8680] Spawn objects only in loaded grids (not just created)
Real object creating in grid make sense only if grid data already loaded, in other cases
gameevent/pool related object will loaded at normal grid data loading.

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-10-20 11:34:01 +04:00
VladimirMangos
dcadfb7cae [8679] Remove 2 now unneeded includes. 2009-10-20 01:12:37 +04:00
VladimirMangos
8bf52f7c63 [8678] Move objects updates store and proccessing for send to client in per map way. 2009-10-19 23:46:58 +04:00
VladimirMangos
abb77cfdbf [8677] Move most client update data functions to object itself from ObjectAccessor.
Also use virtual function BuildUpdateData (old ObjectAccessor::_buildUpdateObject)
that different for world objects and items.
2009-10-19 15:03:06 +04:00
balrok
a2ff999fd3 [8676] implemented dead-visible creature flags_extra
with this flag you can specify a creature to be only
visible for dead players - this removes all hacks from
spiritguides/spirithealers from code and allows some other
special creatures

i decided to not implement an extra deathstate cause
actualy those creatures are almost equal to living ones
2009-10-18 21:28:36 +02:00
m4cm4n
aa87b7007c [8675] Implemented dummy effects for spells 49357, 52845.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-18 21:02:31 +02:00
ApoC
356f1da19b [8674] Fixed mistake in my commit [8657]
I accidentaly put code into wrong switch.

Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-18 20:18:23 +02:00
ApoC
ef2992f175 [8673] Typo fix from prev. commit. :(
Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-18 19:57:38 +02:00
ApoC
3558829283 [8672] Fixed condition in prev. commit.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-18 19:33:04 +02:00
XTZGZoReX
0e1854a936 [8671] Correctly send SMSG_PET_TAME_FAILED with appropriate value when taming fail instead of spell fail.
I also removed conditions from Spell::EffectTameCreature which are checked in Spell::CheckCast.

Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-18 19:16:48 +02:00
pasdVn
906b2784a2 [8670] Apply SPELL_AURA_MOD_EXPERTISE in related hit chance calculations for creatures
(backported from commit 315a1cd)

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-10-18 18:28:12 +04:00
Seizerkiller
990824a88c [8669] Apply creature DB dmg modifier to base damage instead full.
This fix problem with unexpected fixed damage spells scaling.

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-10-18 18:15:06 +04:00
balrok
81e79ce199 [8668] change log: outError to outDebug typo in AddHonor 2009-10-18 14:18:13 +02:00
seirge
7eda96614d [8667] Correctly respawn pooled object in case the same object is selected for respawn.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-18 12:10:42 +02:00
ApoC
df3cc2ce00 [8666] Sorted switch for dummy effect spell generic part by spell id.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-18 12:10:32 +02:00
hunuza
ec10a5bf3c [8665] Correctly implement XP bonus auras.
Signed-off-by: hunuza <hunuza@gmail.com>
2009-10-18 11:44:01 +02:00
VladimirMangos
c0ffd1b48c [8664] Update auras list notes for 3.2.2a state 2009-10-18 07:22:26 +04:00
VladimirMangos
9a9ecddea3 [8663] Implement aura SPELL_AURA_MOD_ATTACKER_SPELL_CRIT_DAMAGE (205) 2009-10-18 06:21:04 +04:00
VladimirMangos
0a65c6218c [8662] Typo fixes in aura names. 2009-10-18 05:25:19 +04:00
VladimirMangos
2e884f4228 [8661] Fixes and improvments in absorb/reduction damage ignore auras work.
* Use stored in aura amount percent damage ignore for auras SPELL_AURA_MOD_IGNORE_ABSORB_FOR_SPELL
* Implement apply percent damage ignore for absorb (SPELL_AURA_MOD_IGNORE_ABSORB_SCHOOL (194))
  and redunction (SPELL_AURA_MOD_IGNORE_DAMAGE_REDUCTION_SCHOOL (269)).
  Later need recheck what from this 2 auras applied to armor reduction
  (currently 269 used only in single spell and this spell is single affecting armor
  and single normal school damage applied with 194 aura)
  Also unclear is this must applied to DoTs, expected that not need.
* Implement talent 53375 boots for spell 31884.
2009-10-18 05:02:33 +04:00
hunuza
2412777007 [8660] Fix spell triggering of spell 25371.
Signed-off-by: hunuza <hunuza@gmail.com>
2009-10-17 11:07:29 +02:00
VladimirMangos
9fd87a644b [8659] Restore less restcricted call format for Unit::AddThreat
Mostly for scripting use, core cases already fixed anyway.
2009-10-17 12:39:26 +04:00
VladimirMangos
b258a17ba4 [8658] Threat calculation fixes and improvements.
* Add single arg version Unit::AddThreat for just adding to threat list.
* Req. provide schollmask and crit flag for any real threat value for proper threats mod apply.
* Send crit flag in DealDamage as MELEE_HIT_CRIT for spell damage for later send to threat call.
* For not affected by modifiers threat values use SPELL_SCHOOL_MASK_NONE.
* Implement aura SPELL_AURA_MOD_CRITICAL_THREAT (used only in itemset 529 effect).
2009-10-17 11:02:30 +04:00
ApoC
ba62cdbe8f [8657] Mark spell 44689 as negative.
This allows aura to be counted down in logoff.

Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-17 00:56:39 +02:00
ApoC
aa42097331 [8656] Removed wrong static keyword.
Thx Vladimir for pointing it out.

Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-17 00:33:30 +02:00
VladimirMangos
29444467a9 [8655] Remove problematic defines from Common.h
Its create conflicts with ACE code.
More cleanup need (with replace use ACE_OS function versions
but stuck for example still used old sockets libarary.
2009-10-17 02:25:28 +04:00
VladimirMangos
bc1f6c7d3f [8654] Allow loading some type gameobjects without diplay id set.
But make its always inviisble for client.
2009-10-17 02:16:36 +04:00
ApoC
45c9c136ba [8653] Implemented per map guids store.
This patch implements storing guid->object pairs on per map level, this leads
to less locking in ObjectAccessor in case of further multithreaded map update.

For case of cross map guid looking (auras cases) all maps are linked into
ObjectAccessor and can be traversed for this lookup.

Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-17 00:12:31 +02:00
ApoC
40b0612dfc [8652] Lock typo fixed.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-16 20:45:57 +02:00
VladimirMangos
cf7ec4c456 [8651] Not send unexpected reply whisper to sender for addon messages.
Thanks to Leo9@mangos.lighthouseapp.com for provided client side testing addons.
2009-10-16 17:51:50 +04:00