Fix incorrect streamout buffer index in GS + refactor various code (#258)

src/util/Zir/Core/IR.h

@@ -289,7 +289,7 @@ namespace ZpIR
 	// IR register constant definition stored in basic block
 	struct IRRegConstDef
 	{
-		IRRegConstDef() {};
+		IRRegConstDef() = default;
 		// todo - support for constants with more than one element?
 
 		IRRegConstDef& setU32(uint32 v) { value_u32 = v; type = DataType::U32; return *this; };
@@ -513,7 +513,7 @@ namespace ZpIR
 				LOC_TYPE_ATTRIBUTE = 3,
 			};
 		public:
-			ShaderImportLocation() {}
+			ShaderImportLocation() = default;
 			ShaderImportLocation(LocationSymbolName loc) 
 			{
 				uint64 v = (uint64)loc;
@@ -598,7 +598,7 @@ namespace ZpIR
 				LOC_TYPE_OUTPUT = 2,
 			};
 		public:
-			ShaderExportLocation() {}
+			ShaderExportLocation() = default;
 			ShaderExportLocation(LocationSymbolName loc)
 			{
 				uint64 v = (uint64)loc;

src/util/Zir/EmitterGLSL/ZpIREmitGLSL.cpp

@@ -12,9 +12,7 @@ class DualStringBuffer
 public:
 	DualStringBuffer() : m_offsetBegin(N / 2), m_offsetEnd(N / 2) { }
 
-	~DualStringBuffer()
-	{
-	}
+	~DualStringBuffer() = default;
 
 	static_assert(sizeof(char) == sizeof(uint8));
 

src/util/containers/IntervalBucketContainer.h

@@ -15,7 +15,7 @@ class IntervalBucketContainer
 
 public:
 
-	IntervalBucketContainer() {};
+	IntervalBucketContainer() = default;
 
 	// range is defined as inclusive rangeStart and exclusive rangeEnd
 	void addRange(TAddr rangeStart, TAddr rangeEnd, TData* data)

src/util/containers/RangeStore.h

@@ -13,10 +13,7 @@ public:
 		size_t lastIterationIndex;
 	}rangeEntry_t;
 
-	RangeStore()
-	{
-
-	}
+	RangeStore() = default;
 
 	size_t getBucket(_ADDR addr)
 	{

src/util/containers/SmallBitset.h

@@ -6,7 +6,7 @@ template<size_t N>
 class SmallBitset
 {
 public:
-	SmallBitset() {};
+	SmallBitset() = default;
 	static_assert(N <= 32);
 	
 	bool test(size_t index) const

src/util/containers/flat_hash_map.hpp

@@ -166,9 +166,7 @@ namespace ska
 				: distance_from_desired(distance_from_desired)
 			{
 			}
-			~sherwood_v3_entry()
-			{
-			}
+			~sherwood_v3_entry() = default;
 			static sherwood_v3_entry* empty_default_table()
 			{
 				static sherwood_v3_entry result[min_lookups] = { {}, {}, {}, {special_end_value} };
@@ -297,9 +295,7 @@ namespace ska
 			using pointer = value_type*;
 			using const_pointer = const value_type*;
 
-			sherwood_v3_table()
-			{
-			}
+			sherwood_v3_table() = default;
 			explicit sherwood_v3_table(size_type bucket_count, const ArgumentHash& hash = ArgumentHash(), const ArgumentEqual& equal = ArgumentEqual(), const ArgumentAlloc& alloc = ArgumentAlloc())
 				: EntryAlloc(alloc), Hasher(hash), Equal(equal)
 			{
@@ -1324,9 +1320,7 @@ namespace ska
 		using mapped_type = V;
 
 		using Table::Table;
-		flat_hash_map()
-		{
-		}
+		flat_hash_map() = default;
 
 		inline V& operator[](const K& key)
 		{
@@ -1442,9 +1436,7 @@ namespace ska
 		using key_type = T;
 
 		using Table::Table;
-		flat_hash_set()
-		{
-		}
+		flat_hash_set() = default;
 
 		template<typename... Args>
 		std::pair<typename Table::iterator, bool> emplace(Args &&... args)