Vulkan: Minimize errors with feedback loop detection for AMD Radeon RX GPUs + Qualcomm SoCs

This commit is contained in:
KeatonTheBot 2025-04-27 00:14:15 -05:00
parent 2f48a5007a
commit 038f8352e0
3 changed files with 22 additions and 23 deletions

View file

@ -1524,6 +1524,9 @@ namespace Ryujinx.Graphics.Vulkan
} }
private bool ChangeFeedbackLoop(FeedbackLoopAspects aspects) private bool ChangeFeedbackLoop(FeedbackLoopAspects aspects)
{
// AMD Radeon RX GPUs + Qualcomm SoCs only
if ((Gd.Vendor == Vendor.Amd && Gd.GpuRenderer.Contains("RX")) || Gd.Vendor == Vendor.Qualcomm)
{ {
if (_feedbackLoop != aspects) if (_feedbackLoop != aspects)
{ {
@ -1540,6 +1543,7 @@ namespace Ryujinx.Graphics.Vulkan
return true; return true;
} }
}
return false; return false;
} }

View file

@ -148,7 +148,7 @@ namespace Ryujinx.Graphics.Vulkan
if (_dirty.HasFlag(DirtyFlags.FeedbackLoop) && gd.Capabilities.SupportsDynamicAttachmentFeedbackLoop) if (_dirty.HasFlag(DirtyFlags.FeedbackLoop) && gd.Capabilities.SupportsDynamicAttachmentFeedbackLoop)
{ {
RecordFeedbackLoop(gd.DynamicFeedbackLoopApi, commandBuffer, gd); RecordFeedbackLoop(gd.DynamicFeedbackLoopApi, commandBuffer);
} }
_dirty = DirtyFlags.None; _dirty = DirtyFlags.None;
@ -190,10 +190,7 @@ namespace Ryujinx.Graphics.Vulkan
} }
} }
private readonly void RecordFeedbackLoop(ExtAttachmentFeedbackLoopDynamicState api, CommandBuffer commandBuffer, VulkanRenderer gd) private readonly void RecordFeedbackLoop(ExtAttachmentFeedbackLoopDynamicState api, CommandBuffer commandBuffer)
{
// AMD Radeon RX GPUs + Qualcomm SoCs only
if ((gd.Vendor == Vendor.Amd && gd.GpuRenderer.Contains("RX")) || gd.Vendor == Vendor.Qualcomm)
{ {
ImageAspectFlags aspects = (_feedbackLoopAspects & FeedbackLoopAspects.Color) != 0 ? ImageAspectFlags.ColorBit : 0; ImageAspectFlags aspects = (_feedbackLoopAspects & FeedbackLoopAspects.Color) != 0 ? ImageAspectFlags.ColorBit : 0;
@ -205,5 +202,4 @@ namespace Ryujinx.Graphics.Vulkan
api.CmdSetAttachmentFeedbackLoopEnable(commandBuffer, aspects); api.CmdSetAttachmentFeedbackLoopEnable(commandBuffer, aspects);
} }
} }
}
} }

View file

@ -7,7 +7,6 @@ namespace Ryujinx.Graphics.Vulkan
{ {
struct PipelineState : IDisposable struct PipelineState : IDisposable
{ {
private const int RequiredSubgroupSize = 32;
private const int MaxDynamicStatesCount = 9; private const int MaxDynamicStatesCount = 9;
public PipelineUid Internal; public PipelineUid Internal;