diff --git a/src/Ryujinx.Audio/Renderer/Dsp/Command/AuxiliaryBufferCommand.cs b/src/Ryujinx.Audio/Renderer/Dsp/Command/AuxiliaryBufferCommand.cs index adc20cb4f..2c48bf055 100644 --- a/src/Ryujinx.Audio/Renderer/Dsp/Command/AuxiliaryBufferCommand.cs +++ b/src/Ryujinx.Audio/Renderer/Dsp/Command/AuxiliaryBufferCommand.cs @@ -31,11 +31,6 @@ namespace Ryujinx.Audio.Renderer.Dsp.Command public bool IsEffectEnabled { get; private set; } - public AuxiliaryBufferCommand() - { - - } - public AuxiliaryBufferCommand Initialize( uint bufferOffset, byte inputBufferOffset, diff --git a/src/Ryujinx.Audio/Renderer/Dsp/Command/BiquadFilterAndMixCommand.cs b/src/Ryujinx.Audio/Renderer/Dsp/Command/BiquadFilterAndMixCommand.cs index 6fb6ebdc9..f46f3a95b 100644 --- a/src/Ryujinx.Audio/Renderer/Dsp/Command/BiquadFilterAndMixCommand.cs +++ b/src/Ryujinx.Audio/Renderer/Dsp/Command/BiquadFilterAndMixCommand.cs @@ -34,11 +34,6 @@ namespace Ryujinx.Audio.Renderer.Dsp.Command public bool HasVolumeRamp { get; private set; } public bool IsFirstMixBuffer { get; private set; } - public BiquadFilterAndMixCommand() - { - - } - public BiquadFilterAndMixCommand Initialize( float volume0, float volume1, diff --git a/src/Ryujinx.Audio/Renderer/Dsp/Command/BiquadFilterCommand.cs b/src/Ryujinx.Audio/Renderer/Dsp/Command/BiquadFilterCommand.cs index 496c83a58..7a6d4a83d 100644 --- a/src/Ryujinx.Audio/Renderer/Dsp/Command/BiquadFilterCommand.cs +++ b/src/Ryujinx.Audio/Renderer/Dsp/Command/BiquadFilterCommand.cs @@ -21,11 +21,6 @@ namespace Ryujinx.Audio.Renderer.Dsp.Command private BiquadFilterParameter2 _parameter; - public BiquadFilterCommand() - { - - } - public BiquadFilterCommand Initialize( int baseIndex, ref BiquadFilterParameter2 filter, diff --git a/src/Ryujinx.Audio/Renderer/Dsp/Command/CaptureBufferCommand.cs b/src/Ryujinx.Audio/Renderer/Dsp/Command/CaptureBufferCommand.cs index a3b8b37da..12894502f 100644 --- a/src/Ryujinx.Audio/Renderer/Dsp/Command/CaptureBufferCommand.cs +++ b/src/Ryujinx.Audio/Renderer/Dsp/Command/CaptureBufferCommand.cs @@ -30,11 +30,6 @@ namespace Ryujinx.Audio.Renderer.Dsp.Command public bool IsEffectEnabled { get; private set; } - public CaptureBufferCommand() - { - - } - public CaptureBufferCommand Initialize(uint bufferOffset, byte inputBufferOffset, ulong sendBufferInfo, bool isEnabled, uint countMax, CpuAddress outputBuffer, uint updateCount, uint writeOffset, int nodeId) { diff --git a/src/Ryujinx.Audio/Renderer/Dsp/Command/ClearMixBufferCommand.cs b/src/Ryujinx.Audio/Renderer/Dsp/Command/ClearMixBufferCommand.cs index b8a7efd1f..bb1c1da57 100644 --- a/src/Ryujinx.Audio/Renderer/Dsp/Command/ClearMixBufferCommand.cs +++ b/src/Ryujinx.Audio/Renderer/Dsp/Command/ClearMixBufferCommand.cs @@ -10,11 +10,6 @@ namespace Ryujinx.Audio.Renderer.Dsp.Command public uint EstimatedProcessingTime { get; set; } - public ClearMixBufferCommand() - { - - } - public ClearMixBufferCommand Initialize(int nodeId) { Enabled = true; diff --git a/src/Ryujinx.Audio/Renderer/Dsp/Command/CopyMixBufferCommand.cs b/src/Ryujinx.Audio/Renderer/Dsp/Command/CopyMixBufferCommand.cs index 5fc8e7258..209fe1e81 100644 --- a/src/Ryujinx.Audio/Renderer/Dsp/Command/CopyMixBufferCommand.cs +++ b/src/Ryujinx.Audio/Renderer/Dsp/Command/CopyMixBufferCommand.cs @@ -13,11 +13,6 @@ namespace Ryujinx.Audio.Renderer.Dsp.Command public ushort InputBufferIndex { get; private set; } public ushort OutputBufferIndex { get; private set; } - public CopyMixBufferCommand() - { - - } - public CopyMixBufferCommand Initialize(uint inputBufferIndex, uint outputBufferIndex, int nodeId) { Enabled = true; diff --git a/src/Ryujinx.Audio/Renderer/Dsp/Command/DataSourceVersion2Command.cs b/src/Ryujinx.Audio/Renderer/Dsp/Command/DataSourceVersion2Command.cs index 8b72687da..10723b3db 100644 --- a/src/Ryujinx.Audio/Renderer/Dsp/Command/DataSourceVersion2Command.cs +++ b/src/Ryujinx.Audio/Renderer/Dsp/Command/DataSourceVersion2Command.cs @@ -3,7 +3,6 @@ using Ryujinx.Audio.Renderer.Common; using Ryujinx.Audio.Renderer.Server.Voice; using System; using Ryujinx.Audio.Renderer.Parameter; -using Ryujinx.Memory; using WaveBuffer = Ryujinx.Audio.Renderer.Common.WaveBuffer; namespace Ryujinx.Audio.Renderer.Dsp.Command diff --git a/src/Ryujinx.Audio/Renderer/Dsp/Command/DepopForMixBuffersCommand.cs b/src/Ryujinx.Audio/Renderer/Dsp/Command/DepopForMixBuffersCommand.cs index 6986043c7..1331d5c60 100644 --- a/src/Ryujinx.Audio/Renderer/Dsp/Command/DepopForMixBuffersCommand.cs +++ b/src/Ryujinx.Audio/Renderer/Dsp/Command/DepopForMixBuffersCommand.cs @@ -21,11 +21,6 @@ namespace Ryujinx.Audio.Renderer.Dsp.Command public Memory DepopBuffer { get; private set; } - public DepopForMixBuffersCommand() - { - - } - public DepopForMixBuffersCommand Initialize(Memory depopBuffer, uint bufferOffset, uint mixBufferCount, int nodeId, uint sampleRate) { Enabled = true; diff --git a/src/Ryujinx.Audio/Renderer/Dsp/Command/DeviceSinkCommand.cs b/src/Ryujinx.Audio/Renderer/Dsp/Command/DeviceSinkCommand.cs index aeb187b41..80405ee75 100644 --- a/src/Ryujinx.Audio/Renderer/Dsp/Command/DeviceSinkCommand.cs +++ b/src/Ryujinx.Audio/Renderer/Dsp/Command/DeviceSinkCommand.cs @@ -25,11 +25,6 @@ namespace Ryujinx.Audio.Renderer.Dsp.Command public Memory Buffers { get; private set; } - public DeviceSinkCommand() - { - - } - public DeviceSinkCommand Initialize(uint bufferOffset, DeviceSink sink, int sessionId, Memory buffers, int nodeId) { Enabled = true; diff --git a/src/Ryujinx.Audio/Renderer/Dsp/Command/FillBufferCommand.cs b/src/Ryujinx.Audio/Renderer/Dsp/Command/FillBufferCommand.cs index c14eeac2b..d3baac9a1 100644 --- a/src/Ryujinx.Audio/Renderer/Dsp/Command/FillBufferCommand.cs +++ b/src/Ryujinx.Audio/Renderer/Dsp/Command/FillBufferCommand.cs @@ -19,11 +19,6 @@ namespace Ryujinx.Audio.Renderer.Dsp.Command public int Length { get; private set; } public float Value { get; private set; } - public FillBufferCommand() - { - - } - public FillBufferCommand Initialize(SplitterDestination destination, int length, float value, int nodeId) { Enabled = true; diff --git a/src/Ryujinx.Audio/Renderer/Dsp/Command/MixCommand.cs b/src/Ryujinx.Audio/Renderer/Dsp/Command/MixCommand.cs index 0dca27bca..138d9c777 100644 --- a/src/Ryujinx.Audio/Renderer/Dsp/Command/MixCommand.cs +++ b/src/Ryujinx.Audio/Renderer/Dsp/Command/MixCommand.cs @@ -22,11 +22,6 @@ namespace Ryujinx.Audio.Renderer.Dsp.Command public float Volume { get; private set; } - public MixCommand() - { - - } - public MixCommand Initialize(uint inputBufferIndex, uint outputBufferIndex, int nodeId, float volume) { Enabled = true; diff --git a/src/Ryujinx.Audio/Renderer/Dsp/Command/MixRampCommand.cs b/src/Ryujinx.Audio/Renderer/Dsp/Command/MixRampCommand.cs index be6aec5a6..16d11eee9 100644 --- a/src/Ryujinx.Audio/Renderer/Dsp/Command/MixRampCommand.cs +++ b/src/Ryujinx.Audio/Renderer/Dsp/Command/MixRampCommand.cs @@ -24,11 +24,6 @@ namespace Ryujinx.Audio.Renderer.Dsp.Command public int LastSampleIndex { get; private set; } - public MixRampCommand() - { - - } - public MixRampCommand Initialize(float volume0, float volume1, uint inputBufferIndex, uint outputBufferIndex, int lastSampleIndex, Memory state, int nodeId) { Enabled = true; diff --git a/src/Ryujinx.Audio/Renderer/Dsp/Command/MixRampGroupedCommand.cs b/src/Ryujinx.Audio/Renderer/Dsp/Command/MixRampGroupedCommand.cs index b08a78ee6..996be4931 100644 --- a/src/Ryujinx.Audio/Renderer/Dsp/Command/MixRampGroupedCommand.cs +++ b/src/Ryujinx.Audio/Renderer/Dsp/Command/MixRampGroupedCommand.cs @@ -24,11 +24,6 @@ namespace Ryujinx.Audio.Renderer.Dsp.Command public Memory State { get; private set; } - public MixRampGroupedCommand() - { - - } - public MixRampGroupedCommand Initialize( uint mixBufferCount, uint inputBufferIndex, diff --git a/src/Ryujinx.Audio/Renderer/Dsp/Command/MultiTapBiquadFilterAndMixCommand.cs b/src/Ryujinx.Audio/Renderer/Dsp/Command/MultiTapBiquadFilterAndMixCommand.cs index 6cc6b4897..ab93f006f 100644 --- a/src/Ryujinx.Audio/Renderer/Dsp/Command/MultiTapBiquadFilterAndMixCommand.cs +++ b/src/Ryujinx.Audio/Renderer/Dsp/Command/MultiTapBiquadFilterAndMixCommand.cs @@ -38,11 +38,6 @@ namespace Ryujinx.Audio.Renderer.Dsp.Command public bool HasVolumeRamp { get; private set; } public bool IsFirstMixBuffer { get; private set; } - public MultiTapBiquadFilterAndMixCommand() - { - - } - public MultiTapBiquadFilterAndMixCommand Initialize( float volume0, float volume1, diff --git a/src/Ryujinx.Audio/Renderer/Dsp/Command/MultiTapBiquadFilterCommand.cs b/src/Ryujinx.Audio/Renderer/Dsp/Command/MultiTapBiquadFilterCommand.cs index fad864982..ca76c653b 100644 --- a/src/Ryujinx.Audio/Renderer/Dsp/Command/MultiTapBiquadFilterCommand.cs +++ b/src/Ryujinx.Audio/Renderer/Dsp/Command/MultiTapBiquadFilterCommand.cs @@ -20,11 +20,6 @@ namespace Ryujinx.Audio.Renderer.Dsp.Command public int OutputBufferIndex { get; private set; } public bool[] IsInitialized { get; private set; } - public MultiTapBiquadFilterCommand() - { - - } - public MultiTapBiquadFilterCommand Initialize(int baseIndex, ReadOnlySpan filters, Memory biquadFilterStateMemory, int inputBufferOffset, int outputBufferOffset, ReadOnlySpan isInitialized, int nodeId) { Parameters = filters.ToArray(); diff --git a/src/Ryujinx.Audio/Renderer/Dsp/Command/PerformanceCommand.cs b/src/Ryujinx.Audio/Renderer/Dsp/Command/PerformanceCommand.cs index c5d7d8ef1..b0af16c13 100644 --- a/src/Ryujinx.Audio/Renderer/Dsp/Command/PerformanceCommand.cs +++ b/src/Ryujinx.Audio/Renderer/Dsp/Command/PerformanceCommand.cs @@ -23,11 +23,6 @@ namespace Ryujinx.Audio.Renderer.Dsp.Command public Type PerformanceType { get; set; } - public PerformanceCommand() - { - - } - public PerformanceCommand Initialize(ref PerformanceEntryAddresses performanceEntryAddresses, Type performanceType, int nodeId) { if (PerformanceEntryAddresses is not null) diff --git a/src/Ryujinx.Audio/Renderer/Dsp/Command/UpsampleCommand.cs b/src/Ryujinx.Audio/Renderer/Dsp/Command/UpsampleCommand.cs index f9c17863f..f9c951b2d 100644 --- a/src/Ryujinx.Audio/Renderer/Dsp/Command/UpsampleCommand.cs +++ b/src/Ryujinx.Audio/Renderer/Dsp/Command/UpsampleCommand.cs @@ -22,11 +22,6 @@ namespace Ryujinx.Audio.Renderer.Dsp.Command public Memory OutBuffer { get; private set; } - public UpsampleCommand() - { - - } - public UpsampleCommand Initialize(uint bufferOffset, UpsamplerInfo info, uint inputCount, Span inputBufferOffset, uint bufferCount, uint sampleCount, uint sampleRate, int nodeId) { Enabled = true; diff --git a/src/Ryujinx.Audio/Renderer/Dsp/Command/VolumeCommand.cs b/src/Ryujinx.Audio/Renderer/Dsp/Command/VolumeCommand.cs index ef5a28bd2..73930bc07 100644 --- a/src/Ryujinx.Audio/Renderer/Dsp/Command/VolumeCommand.cs +++ b/src/Ryujinx.Audio/Renderer/Dsp/Command/VolumeCommand.cs @@ -22,11 +22,6 @@ namespace Ryujinx.Audio.Renderer.Dsp.Command public float Volume { get; private set; } - public VolumeCommand() - { - - } - public VolumeCommand Initialize(float volume, uint bufferIndex, int nodeId) { Enabled = true; diff --git a/src/Ryujinx.Audio/Renderer/Dsp/Command/VolumeRampCommand.cs b/src/Ryujinx.Audio/Renderer/Dsp/Command/VolumeRampCommand.cs index 47753dc79..20f6d66c6 100644 --- a/src/Ryujinx.Audio/Renderer/Dsp/Command/VolumeRampCommand.cs +++ b/src/Ryujinx.Audio/Renderer/Dsp/Command/VolumeRampCommand.cs @@ -19,11 +19,6 @@ namespace Ryujinx.Audio.Renderer.Dsp.Command public float Volume0 { get; private set; } public float Volume1 { get; private set; } - public VolumeRampCommand() - { - - } - public VolumeRampCommand Initialize(float volume0, float volume1, uint bufferIndex, int nodeId) { Enabled = true; diff --git a/src/Ryujinx.Audio/Renderer/Server/CommandBuffer.cs b/src/Ryujinx.Audio/Renderer/Server/CommandBuffer.cs index b6f435860..b86f335bb 100644 --- a/src/Ryujinx.Audio/Renderer/Server/CommandBuffer.cs +++ b/src/Ryujinx.Audio/Renderer/Server/CommandBuffer.cs @@ -10,7 +10,6 @@ using Ryujinx.Audio.Renderer.Server.Upsampler; using Ryujinx.Audio.Renderer.Server.Voice; using Ryujinx.Common; using System; -using System.Runtime.CompilerServices; using CpuAddress = System.UInt64; namespace Ryujinx.Audio.Renderer.Server @@ -98,8 +97,6 @@ namespace Ryujinx.Audio.Renderer.Server case CommandType.BiquadFilter: _biquadFilterCommandPool.Release((BiquadFilterCommand)command); break; - case CommandType.BiquadFilterFloatCoeff: - throw new NotImplementedException(); case CommandType.Mix: _mixCommandPool.Release((MixCommand)command); break; @@ -157,8 +154,6 @@ namespace Ryujinx.Audio.Renderer.Server case CommandType.MultiTapBiquadFilter: _multiTapBiquadFilterCommandPool.Release((MultiTapBiquadFilterCommand)command); break; - case CommandType.MultiTapBiquadFilterFloatCoeff: - throw new NotImplementedException(); case CommandType.CaptureBuffer: _captureBufferCommandPool.Release((CaptureBufferCommand)command); break; @@ -168,24 +163,20 @@ namespace Ryujinx.Audio.Renderer.Server case CommandType.BiquadFilterAndMix: _biquadFilterAndMixCommandPool.Release((BiquadFilterAndMixCommand)command); break; - case CommandType.BiquadFilterAndMixFloatCoeff: - throw new NotImplementedException(); case CommandType.MultiTapBiquadFilterAndMix: _multiTapBiquadFilterAndMixCommandPool.Release((MultiTapBiquadFilterAndMixCommand)command); break; - case CommandType.MultiTapBiquadFilterAndMixFloatCoef: - throw new NotImplementedException(); - case CommandType.AuxiliaryBufferGrouped: - throw new NotImplementedException(); - case CommandType.FillMixBuffer: - throw new NotImplementedException(); - case CommandType.BiquadFilterCrossFade: - throw new NotImplementedException(); - case CommandType.MultiTapBiquadFilterCrossFade: - throw new NotImplementedException(); case CommandType.FillBuffer: _fillBufferCommandPool.Release((FillBufferCommand)command); break; + case CommandType.BiquadFilterFloatCoeff: + case CommandType.MultiTapBiquadFilterFloatCoeff: + case CommandType.BiquadFilterAndMixFloatCoeff: + case CommandType.MultiTapBiquadFilterAndMixFloatCoef: + case CommandType.AuxiliaryBufferGrouped: + case CommandType.FillMixBuffer: + case CommandType.BiquadFilterCrossFade: + case CommandType.MultiTapBiquadFilterCrossFade: default: throw new NotImplementedException(); } diff --git a/src/Ryujinx.Common/Pools/ObjectPool.cs b/src/Ryujinx.Common/Pools/ObjectPool.cs index dd2a708ea..de8534332 100644 --- a/src/Ryujinx.Common/Pools/ObjectPool.cs +++ b/src/Ryujinx.Common/Pools/ObjectPool.cs @@ -1,6 +1,5 @@ using System; using System.Collections.Concurrent; -using System.Threading; namespace Ryujinx.Common {