From f9780b33bb5cfa4758ff4ad2fb6eec4999f38073 Mon Sep 17 00:00:00 2001 From: KeatonTheBot Date: Wed, 18 Jun 2025 00:00:00 -0500 Subject: [PATCH] misc: chore: Use 'foreach' statement in place of Gommon ForEach in "delete all" mod manager crash fix * Simplify statement for valid mod folder checking --- src/Ryujinx/UI/ViewModels/ModManagerViewModel.cs | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/Ryujinx/UI/ViewModels/ModManagerViewModel.cs b/src/Ryujinx/UI/ViewModels/ModManagerViewModel.cs index 7d0876acf..18bf53b22 100644 --- a/src/Ryujinx/UI/ViewModels/ModManagerViewModel.cs +++ b/src/Ryujinx/UI/ViewModels/ModManagerViewModel.cs @@ -4,7 +4,6 @@ using Avalonia.Controls.ApplicationLifetimes; using Avalonia.Platform.Storage; using Avalonia.Threading; using DynamicData; -using Gommon; using Ryujinx.Ava.Common.Locale; using Ryujinx.Ava.UI.Helpers; using Ryujinx.Ava.UI.Models; @@ -261,12 +260,7 @@ namespace Ryujinx.Ava.UI.ViewModels var destinationDir = ModLoader.GetApplicationDir(ModLoader.GetSdModsBasePath(), _applicationId.ToString("x16")); // TODO: More robust checking for valid mod folders - var isDirectoryValid = true; - - if (directories.Length == 0) - { - isDirectoryValid = false; - } + var isDirectoryValid = directories.Length != 0; if (!isDirectoryValid) { @@ -324,7 +318,7 @@ namespace Ryujinx.Ava.UI.ViewModels public void DeleteAll() { - Mods.ForEach(it => Delete(it, false)); + foreach (var it in Mods) Delete(it, false); Mods.Clear(); OnPropertyChanged(nameof(ModCount)); Sort();