From 8e17126738e45a160cd4cc4b652bc379a4380e6e Mon Sep 17 00:00:00 2001 From: ramenrrami Date: Wed, 15 Oct 2025 10:54:53 +0200 Subject: [PATCH] jit: inline ARM32 instruction logging and remove redundant traces --- src/jit/decoder/arm32.cpp | 22 +++++++--------------- src/jit/decoder/arm32.h | 1 - 2 files changed, 7 insertions(+), 16 deletions(-) diff --git a/src/jit/decoder/arm32.cpp b/src/jit/decoder/arm32.cpp index 1cf9c0d..013f82e 100644 --- a/src/jit/decoder/arm32.cpp +++ b/src/jit/decoder/arm32.cpp @@ -85,7 +85,13 @@ void arm32_add_instruction(arm32_decoder_t* decoder, const char* name, const cha } ++decoder->instruction_count; - arm32_log_instruction_info(info); + LOG_TRACE("========================================"); + LOG_TRACE("Instruction Registered: %s", info->name); + LOG_TRACE("Mask: 0x%08X", info->mask); + LOG_TRACE("Expected: 0x%08X", info->expected); + LOG_TRACE("Priority: %d", info->priority); + LOG_TRACE("========================================"); + /* TODO(GloriousTacoo:jit): Add instruction to lookup table. */ } @@ -132,19 +138,5 @@ void arm32_parse_bitstring(const char* bitstring, uint32_t* mask, uint32_t* expe } } } -void arm32_log_instruction_info(const arm32_instruction_info_t* info) -{ - if (info == nullptr) - { - LOG_TRACE("Attempted to log a null instruction info pointer!"); - return; - } - LOG_TRACE("========================================"); - LOG_TRACE("Instruction Registered: %s", info->name); - LOG_TRACE("Mask: 0x%08X", info->mask); - LOG_TRACE("Expected: 0x%08X", info->expected); - LOG_TRACE("Priority: %d", info->priority); - LOG_TRACE("========================================"); -} } // namespace pound::jit::decoder diff --git a/src/jit/decoder/arm32.h b/src/jit/decoder/arm32.h index 6308899..c984d45 100644 --- a/src/jit/decoder/arm32.h +++ b/src/jit/decoder/arm32.h @@ -48,7 +48,6 @@ void arm32_add_instruction(arm32_decoder_t* decoder, const char* name, arm32_opc arm32_handler_fn handler); void arm32_ADD_imm_handler(arm32_decoder_t* decoder, arm32_instruction_t instruction); -void arm32_log_instruction_info(const arm32_instruction_info_t* info); } // namespace pound::jit::decoder #endif // POUND_JIT_DECODER_ARM32_H \ No newline at end of file