Localize all (I think...) previously hardcoded english strings in the setup wizard

assets/locales.json

@@ -25067,6 +25067,56 @@
         "zh_TW": ""
       }
     },
+    {
+      "ID": "SetupWizardKeysPageHelpText",
+      "Translations": {
+        "ar_SA": "",
+        "de_DE": "",
+        "el_GR": "",
+        "en_US": "Not sure how to get your keys?",
+        "es_ES": "",
+        "fr_FR": "",
+        "he_IL": "",
+        "it_IT": "",
+        "ja_JP": "",
+        "ko_KR": "",
+        "no_NO": "",
+        "pl_PL": "",
+        "pt_BR": "",
+        "ru_RU": "",
+        "sv_SE": "",
+        "th_TH": "",
+        "tr_TR": "",
+        "uk_UA": "",
+        "zh_CN": "",
+        "zh_TW": ""
+      }
+    },
+    {
+      "ID": "SetupWizardKeysPageSkipText",
+      "Translations": {
+        "ar_SA": "",
+        "de_DE": "",
+        "el_GR": "",
+        "en_US": "Skipped setting up keys as you already have a valid key installation and did not choose a folder to install from.\nClick '{0}' if you wish to reinstall your keys.",
+        "es_ES": "",
+        "fr_FR": "",
+        "he_IL": "",
+        "it_IT": "",
+        "ja_JP": "",
+        "ko_KR": "",
+        "no_NO": "",
+        "pl_PL": "",
+        "pt_BR": "",
+        "ru_RU": "",
+        "sv_SE": "",
+        "th_TH": "",
+        "tr_TR": "",
+        "uk_UA": "",
+        "zh_CN": "",
+        "zh_TW": ""
+      }
+    },
     {
       "ID": "SetupWizardFirmwarePageTitle",
       "Translations": {
@@ -25217,6 +25267,156 @@
         "zh_TW": ""
       }
     },
+    {
+      "ID": "SetupWizardFirmwarePageInstallSuccessNotificationTitle",
+      "Translations": {
+        "ar_SA": "",
+        "de_DE": "",
+        "el_GR": "",
+        "en_US": "Firmware installed",
+        "es_ES": "",
+        "fr_FR": "",
+        "he_IL": "",
+        "it_IT": "",
+        "ja_JP": "",
+        "ko_KR": "",
+        "no_NO": "",
+        "pl_PL": "",
+        "pt_BR": "",
+        "ru_RU": "",
+        "sv_SE": "",
+        "th_TH": "",
+        "tr_TR": "",
+        "uk_UA": "",
+        "zh_CN": "",
+        "zh_TW": ""
+      }
+    },
+    {
+      "ID": "SetupWizardFirmwarePageInstallSuccessNotificationText",
+      "Translations": {
+        "ar_SA": "",
+        "de_DE": "",
+        "el_GR": "",
+        "en_US": "Installed firmware version {0}.",
+        "es_ES": "",
+        "fr_FR": "",
+        "he_IL": "",
+        "it_IT": "",
+        "ja_JP": "",
+        "ko_KR": "",
+        "no_NO": "",
+        "pl_PL": "",
+        "pt_BR": "",
+        "ru_RU": "",
+        "sv_SE": "",
+        "th_TH": "",
+        "tr_TR": "",
+        "uk_UA": "",
+        "zh_CN": "",
+        "zh_TW": ""
+      }
+    },
+    {
+      "ID": "SetupWizardFirmwarePageInstallFailNotificationTitle",
+      "Translations": {
+        "ar_SA": "",
+        "de_DE": "",
+        "el_GR": "",
+        "en_US": "Firmware not installed",
+        "es_ES": "",
+        "fr_FR": "",
+        "he_IL": "",
+        "it_IT": "",
+        "ja_JP": "",
+        "ko_KR": "",
+        "no_NO": "",
+        "pl_PL": "",
+        "pt_BR": "",
+        "ru_RU": "",
+        "sv_SE": "",
+        "th_TH": "",
+        "tr_TR": "",
+        "uk_UA": "",
+        "zh_CN": "",
+        "zh_TW": ""
+      }
+    },
+    {
+      "ID": "SetupWizardFirmwarePageInstallFailNotificationText",
+      "Translations": {
+        "ar_SA": "",
+        "de_DE": "",
+        "el_GR": "",
+        "en_US": "It seems some error occurred when trying to install the firmware at path '{0}'.\nDid that folder contain a firmware dump?",
+        "es_ES": "",
+        "fr_FR": "",
+        "he_IL": "",
+        "it_IT": "",
+        "ja_JP": "",
+        "ko_KR": "",
+        "no_NO": "",
+        "pl_PL": "",
+        "pt_BR": "",
+        "ru_RU": "",
+        "sv_SE": "",
+        "th_TH": "",
+        "tr_TR": "",
+        "uk_UA": "",
+        "zh_CN": "",
+        "zh_TW": ""
+      }
+    },
+    {
+      "ID": "SetupWizardFirmwarePageHelpText",
+      "Translations": {
+        "ar_SA": "",
+        "de_DE": "",
+        "el_GR": "",
+        "en_US": "Not sure how to get your firmware off of your Switch?",
+        "es_ES": "",
+        "fr_FR": "",
+        "he_IL": "",
+        "it_IT": "",
+        "ja_JP": "",
+        "ko_KR": "",
+        "no_NO": "",
+        "pl_PL": "",
+        "pt_BR": "",
+        "ru_RU": "",
+        "sv_SE": "",
+        "th_TH": "",
+        "tr_TR": "",
+        "uk_UA": "",
+        "zh_CN": "",
+        "zh_TW": ""
+      }
+    },
+    {
+      "ID": "SetupWizardFirmwarePageSkipText",
+      "Translations": {
+        "ar_SA": "",
+        "de_DE": "",
+        "el_GR": "",
+        "en_US": "Skipped setting up firmware as you already have a valid firmware installation and did not choose a folder or file to install from.\nClick '{0}' if you wish to overwrite your firmware.",
+        "es_ES": "",
+        "fr_FR": "",
+        "he_IL": "",
+        "it_IT": "",
+        "ja_JP": "",
+        "ko_KR": "",
+        "no_NO": "",
+        "pl_PL": "",
+        "pt_BR": "",
+        "ru_RU": "",
+        "sv_SE": "",
+        "th_TH": "",
+        "tr_TR": "",
+        "uk_UA": "",
+        "zh_CN": "",
+        "zh_TW": ""
+      }
+    },
     {
       "ID": "SetupWizardGameDirsPageTitle",
       "Translations": {
@@ -25242,6 +25442,81 @@
         "zh_TW": ""
       }
     },
+    {
+      "ID": "SetupWizardGameDirsPageDescription",
+      "Translations": {
+        "ar_SA": "",
+        "de_DE": "",
+        "el_GR": "",
+        "en_US": "{0} can be pointed at any number of folders to look for your games, updates, and DLC content.\nAt least one folder must be specified in game directories before continuing.",
+        "es_ES": "",
+        "fr_FR": "",
+        "he_IL": "",
+        "it_IT": "",
+        "ja_JP": "",
+        "ko_KR": "",
+        "no_NO": "",
+        "pl_PL": "",
+        "pt_BR": "",
+        "ru_RU": "",
+        "sv_SE": "",
+        "th_TH": "",
+        "tr_TR": "",
+        "uk_UA": "",
+        "zh_CN": "",
+        "zh_TW": ""
+      }
+    },
+    {
+      "ID": "SetupWizardGameDirsPageNoFoldersSelectedError",
+      "Translations": {
+        "ar_SA": "",
+        "de_DE": "",
+        "el_GR": "",
+        "en_US": "At least one folder for games must be selected; otherwise the UI will be empty.",
+        "es_ES": "",
+        "fr_FR": "",
+        "he_IL": "",
+        "it_IT": "",
+        "ja_JP": "",
+        "ko_KR": "",
+        "no_NO": "",
+        "pl_PL": "",
+        "pt_BR": "",
+        "ru_RU": "",
+        "sv_SE": "",
+        "th_TH": "",
+        "tr_TR": "",
+        "uk_UA": "",
+        "zh_CN": "",
+        "zh_TW": ""
+      }
+    },
+    {
+      "ID": "SetupWizardGameDirsPageHelpText",
+      "Translations": {
+        "ar_SA": "",
+        "de_DE": "",
+        "el_GR": "",
+        "en_US": "Not sure how to get your games, updates, and/or DLC onto your PC?",
+        "es_ES": "",
+        "fr_FR": "",
+        "he_IL": "",
+        "it_IT": "",
+        "ja_JP": "",
+        "ko_KR": "",
+        "no_NO": "",
+        "pl_PL": "",
+        "pt_BR": "",
+        "ru_RU": "",
+        "sv_SE": "",
+        "th_TH": "",
+        "tr_TR": "",
+        "uk_UA": "",
+        "zh_CN": "",
+        "zh_TW": ""
+      }
+    },
     {
       "ID": "SetupWizardFinalPageTitle",
       "Translations": {
@@ -25316,6 +25591,31 @@
         "zh_CN": "",
         "zh_TW": ""
       }
+    },
+    {
+      "ID": "SetupWizardHelpLinkButton",
+      "Translations": {
+        "ar_SA": "",
+        "de_DE": "",
+        "el_GR": "",
+        "en_US": "Click here to view a guide.",
+        "es_ES": "",
+        "fr_FR": "",
+        "he_IL": "",
+        "it_IT": "",
+        "ja_JP": "",
+        "ko_KR": "",
+        "no_NO": "",
+        "pl_PL": "",
+        "pt_BR": "",
+        "ru_RU": "",
+        "sv_SE": "",
+        "th_TH": "",
+        "tr_TR": "",
+        "uk_UA": "",
+        "zh_CN": "",
+        "zh_TW": ""
+      }
     }
   ]
 }

src/Ryujinx/UI/SetupWizard/Pages/Fw/SetupFirmwarePageContext.cs

@@ -19,13 +19,14 @@ namespace Ryujinx.Ava.UI.SetupWizard.Pages
 {
     public partial class SetupFirmwarePageContext() : SetupWizardPageContext(LocaleKeys.SetupWizardFirmwarePageTitle)
     {
-        [ObservableProperty]
+        [ObservableProperty] public partial string FirmwareSourcePath { get; set; }
-        public partial string FirmwareSourcePath { get; set; }
 
         [RelayCommand]
         private static async Task BrowseFile(TextBox tb)
         {
-            Optional<IStorageFile> result = await RyujinxApp.MainWindow.ViewModel.StorageProvider.OpenSingleFilePickerAsync(new FilePickerOpenOptions
+            Optional<IStorageFile> result =
+                await RyujinxApp.MainWindow.ViewModel.StorageProvider.OpenSingleFilePickerAsync(
+                    new FilePickerOpenOptions
                     {
                         Title = LocaleManager.Instance[LocaleKeys.SetupWizardFirmwarePageFilePopupTitle],
                         FileTypeFilter = new List<FilePickerFileType>
@@ -60,7 +61,9 @@ namespace Ryujinx.Ava.UI.SetupWizard.Pages
         [RelayCommand]
         private static async Task BrowseFolder(TextBox tb)
         {
-            Optional<IStorageFolder> result = await RyujinxApp.MainWindow.ViewModel.StorageProvider.OpenSingleFolderPickerAsync(new FolderPickerOpenOptions 
+            Optional<IStorageFolder> result =
+                await RyujinxApp.MainWindow.ViewModel.StorageProvider.OpenSingleFolderPickerAsync(
+                    new FolderPickerOpenOptions
                     {
                         Title = LocaleManager.Instance[LocaleKeys.SetupWizardFirmwarePageFolderPopupTitle]
                     });
@@ -81,14 +84,14 @@ namespace Ryujinx.Ava.UI.SetupWizard.Pages
 
             grid.Children.Add(new TextBlock
             {
-                Text = "Not sure how to get your firmware off of your Switch?",
+                Text = LocaleManager.Instance[LocaleKeys.SetupWizardFirmwarePageHelpText],
                 HorizontalAlignment = HorizontalAlignment.Center,
                 GridRow = 0
             });
 
             grid.Children.Add(new HyperlinkButton
             {
-                Content = "Click here to view a guide.",
+                Content = LocaleManager.Instance[LocaleKeys.SetupWizardHelpLinkButton],
                 NavigateUri = new Uri(SharedConstants.DumpFirmwareWikiUrl),
                 HorizontalAlignment = HorizontalAlignment.Center,
                 GridRow = 1
@@ -102,8 +105,12 @@ namespace Ryujinx.Ava.UI.SetupWizard.Pages
             if (string.IsNullOrEmpty(FirmwareSourcePath) && RyujinxSetupWizard.HasFirmware)
             {
                 NotificationManager.Information(
-                    title: LocaleManager.Instance[LocaleKeys.DialogConfirmationTitle],
+                    title: LocaleManager.Instance[LocaleKeys.RyujinxInfo],
-                    "Skipped setting up firmware as you already have a valid firmware installation and did not choose a folder or file to install from.\n\nClick 'Back' if you wish to overwrite your firmware.");
+                    text: LocaleManager.GetFormatted(
+                        LocaleKeys.SetupWizardFirmwarePageSkipText,
+                        LocaleManager.Instance[LocaleKeys.SetupWizardActionBack]
+                    )
+                );
                 return Result.Success; // This handles the user selecting no file/dir and just hitting Next.
             }
 
@@ -117,18 +124,24 @@ namespace Ryujinx.Ava.UI.SetupWizard.Pages
                 if (installedFwVer != null)
                 {
                     NotificationManager.Information(
-                        "Firmware installed",
+                        LocaleManager.Instance[LocaleKeys.SetupWizardFirmwarePageInstallSuccessNotificationTitle],
-                        $"Installed firmware version {installedFwVer.VersionString}."
+                        LocaleManager.GetFormatted(
+                            LocaleKeys.SetupWizardFirmwarePageInstallSuccessNotificationTitle,
+                            installedFwVer.VersionString
+                        )
                     );
                 }
                 else
                 {
                     NotificationManager.Error(
-                        "Firmware not installed",
+                        LocaleManager.Instance[LocaleKeys.SetupWizardFirmwarePageInstallFailNotificationTitle],
-                        $"It seems some error occurred when trying to install the firmware at path '{FirmwareSourcePath}'." +
+                        LocaleManager.GetFormatted(
-                        "\nDid that folder contain a firmware dump?"
+                            LocaleKeys.SetupWizardFirmwarePageInstallFailNotificationText,
+                            FirmwareSourcePath
+                        )
                     );
                 }
+
                 RyujinxApp.MainWindow.ViewModel.RefreshFirmwareStatus(installedFwVer, allowNullVersion: true);
 
                 // Purge Applet Cache.

src/Ryujinx/UI/SetupWizard/Pages/GameDirs/SetupGameDirsPage.axaml

@@ -11,8 +11,8 @@
         Margin="10"
         Spacing="10"
         Orientation="Vertical" HorizontalAlignment="Stretch">
+        <TextBlock Classes="h1" Text="{ext:Locale SetupWizardGameDirsPageDescription}" />
         <TextBlock Classes="h1" Text="{ext:Locale SettingsTabGeneralGameDirectories}" />
-
         <StackPanel
             Margin="10,0,0,0"
             HorizontalAlignment="Stretch"

src/Ryujinx/UI/SetupWizard/Pages/GameDirs/SetupGameDirsPageContext.cs

@@ -27,8 +27,8 @@ namespace Ryujinx.UI.SetupWizard.Pages
         {
             if (GameDirs.Count is 0)
             {
-                NotificationManager.Error("At least one folder for games must be selected; otherwise the UI will be empty.");
+                NotificationManager.Error(LocaleManager.Instance[LocaleKeys.SetupWizardGameDirsPageNoFoldersSelectedError]);
-                return Result.Failure(RetryError.Shared);
+                return Result.Fail;
             }
 
             ConfigurationState.Instance.UI.GameDirs.Value = GameDirs.ToList();
@@ -49,14 +49,14 @@ namespace Ryujinx.UI.SetupWizard.Pages
 
             grid.Children.Add(new TextBlock
             {
-                Text = "Not sure how to get your games, updates, and/or DLC onto your PC?",
+                Text = LocaleManager.Instance[LocaleKeys.SetupWizardGameDirsPageHelpText],
                 HorizontalAlignment = HorizontalAlignment.Center,
                 GridRow = 0
             });
 
             grid.Children.Add(new HyperlinkButton
             {
-                Content = "Click here to view a guide.",
+                Content = LocaleManager.Instance[LocaleKeys.SetupWizardHelpLinkButton],
                 HorizontalAlignment = HorizontalAlignment.Center,
                 NavigateUri = new Uri(SharedConstants.DumpContentWikiUrl),
                 GridRow = 1
@@ -65,9 +65,4 @@ namespace Ryujinx.UI.SetupWizard.Pages
             return grid;
         }
     }
-
-    public struct RetryError : IErrorState
-    {
-        public static readonly RetryError Shared = new();
-    }
 }

src/Ryujinx/UI/SetupWizard/Pages/Keys/SetupKeysPageContext.cs

@@ -31,14 +31,14 @@ namespace Ryujinx.Ava.UI.SetupWizard.Pages
 
             grid.Children.Add(new TextBlock
             {
-                Text = "Not sure how to get your keys?",
+                Text = LocaleManager.Instance[LocaleKeys.SetupWizardKeysPageHelpText],
                 HorizontalAlignment = HorizontalAlignment.Center,
                 GridRow = 0
             });
 
             grid.Children.Add(new HyperlinkButton
             {
-                Content = "Click here to view a guide.",
+                Content = LocaleManager.Instance[LocaleKeys.SetupWizardHelpLinkButton],
                 HorizontalAlignment = HorizontalAlignment.Center,
                 NavigateUri = new Uri(SharedConstants.DumpKeysWikiUrl),
                 GridRow = 1
@@ -70,8 +70,11 @@ namespace Ryujinx.Ava.UI.SetupWizard.Pages
             if (string.IsNullOrEmpty(KeysFolderPath) && RyujinxApp.MainWindow.VirtualFileSystem.HasKeySet)
             {
                 NotificationManager.Information(
-                    title: LocaleManager.Instance[LocaleKeys.DialogConfirmationTitle],
+                    title: LocaleManager.Instance[LocaleKeys.RyujinxInfo],
-                    "Skipped setting up keys as you already have a valid key installation and did not choose a folder to install from.\n\nClick 'Back' if you wish to reinstall your keys.");
+                    text: LocaleManager.GetFormatted(
+                        LocaleKeys.SetupWizardKeysPageSkipText,
+                        LocaleManager.Instance[LocaleKeys.SetupWizardActionBack]
+                    ));
                 return Result.Success; // This handles the user selecting no folder and just hitting Next.
             }
 

src/Ryujinx/UI/SetupWizard/RyujinxSetupWizard.Steps.cs

@@ -68,12 +68,7 @@ namespace Ryujinx.Ava.UI.SetupWizard
             if (!result)
                 return false;
 
-            var res = gdContext.CompleteStep();
+            if (!gdContext.CompleteStep())
-
-            if (res.IsOf<RetryError>())
-                return false;
-
-            if (!res)
                 goto Retry;
 
             return true;

src/Ryujinx/UI/SetupWizard/RyujinxSetupWizard.cs

@@ -62,7 +62,7 @@ namespace Ryujinx.Ava.UI.SetupWizard
                 // Fuck it, weird window height hack to do it instead.
                 // 120 is not exact, just a random number. Looks fine though.
                 NotificationPosition.TopCenter,
-                margin: new Thickness(0, _window.Height - 120, 0, 0)
+                margin: new Thickness(0, _window.Height - 135, 0, 0)
             );
 
             RyujinxSetupWizardWindow.IsOpen = true;