Shader: skip initialization of all clip distances on macOS.

This commit is contained in:
V380-Ori 2025-11-26 15:54:06 +02:00
parent 39f55b2af3
commit af7d4c586c
6 changed files with 22 additions and 3 deletions

View file

@ -10,6 +10,7 @@ namespace Ryujinx.Graphics.GAL
public readonly bool HasFrontFacingBug;
public readonly bool HasVectorIndexingBug;
public readonly bool HasClipDistanceInitBug;
public readonly bool NeedsFragmentOutputSpecialization;
public readonly bool ReduceShaderPrecision;
@ -79,6 +80,7 @@ namespace Ryujinx.Graphics.GAL
SystemMemoryType memoryType,
bool hasFrontFacingBug,
bool hasVectorIndexingBug,
bool hasClipDistanceInitBug,
bool needsFragmentOutputSpecialization,
bool reduceShaderPrecision,
bool supportsAstcCompression,
@ -141,6 +143,7 @@ namespace Ryujinx.Graphics.GAL
MemoryType = memoryType;
HasFrontFacingBug = hasFrontFacingBug;
HasVectorIndexingBug = hasVectorIndexingBug;
HasClipDistanceInitBug = hasClipDistanceInitBug;
NeedsFragmentOutputSpecialization = needsFragmentOutputSpecialization;
ReduceShaderPrecision = reduceShaderPrecision;
SupportsAstcCompression = supportsAstcCompression;

View file

@ -201,6 +201,8 @@ namespace Ryujinx.Graphics.Gpu.Shader
public bool QueryHostHasVectorIndexingBug() => _context.Capabilities.HasVectorIndexingBug;
public bool QueryHostHasClipDistanceInitBug() => _context.Capabilities.HasClipDistanceInitBug;
public int QueryHostStorageBufferOffsetAlignment() => _context.Capabilities.StorageBufferOffsetAlignment;
public int QueryHostSubgroupSize() => _context.Capabilities.ShaderSubgroupSize;

View file

@ -153,6 +153,7 @@ namespace Ryujinx.Graphics.OpenGL
memoryType: SystemMemoryType.BackendManaged,
hasFrontFacingBug: intelWindows,
hasVectorIndexingBug: amdWindows,
hasClipDistanceInitBug: false,
needsFragmentOutputSpecialization: false,
reduceShaderPrecision: false,
supportsAstcCompression: HwCapabilities.SupportsAstcCompression,

View file

@ -202,6 +202,15 @@ namespace Ryujinx.Graphics.Shader
return false;
}
/// <summary>
/// Queries host about the presence of the clip distance initialization bug.
/// </summary>
/// <returns>True if the bug is present on the host device used, false otherwise</returns>
bool QueryHostHasClipDistanceInitBug()
{
return false;
}
/// <summary>
/// Queries host storage buffer alignment required.
/// </summary>

View file

@ -259,11 +259,14 @@ namespace Ryujinx.Graphics.Shader.Translation
context.Store(StorageKind.Output, IoVariable.Position, null, Const(c), ConstF(c == 3 ? 1f : 0f));
}
if (context.Program.ClipDistancesWritten != 0)
if (!context.TranslatorContext.GpuAccessor.QueryHostHasClipDistanceInitBug())
{
for (int i = 0; i < 8; i++)
if (context.Program.ClipDistancesWritten != 0)
{
context.Store(StorageKind.Output, IoVariable.ClipDistance, null, Const(i), ConstF(0f));
for (int i = 0; i < 8; i++)
{
context.Store(StorageKind.Output, IoVariable.ClipDistance, null, Const(i), ConstF(0f));
}
}
}
}

View file

@ -744,6 +744,7 @@ namespace Ryujinx.Graphics.Vulkan
memoryType: memoryType,
hasFrontFacingBug: IsIntelWindows,
hasVectorIndexingBug: IsQualcommProprietary,
hasClipDistanceInitBug: IsMoltenVk,
needsFragmentOutputSpecialization: IsMoltenVk,
reduceShaderPrecision: IsMoltenVk,
supportsAstcCompression: features2.Features.TextureCompressionAstcLdr && supportsAstcFormats,