use a helper to get key path instead of checking mode & userpath existing every time

src/Ryujinx.Common/Configuration/AppDataManager.cs

@@ -31,6 +31,11 @@ namespace Ryujinx.Common.Configuration
         public static string KeysDirPath { get; private set; }
         public static string KeysDirPathUser { get; }
 
+        public static string GetKeysDir() =>
+            Mode is LaunchMode.UserProfile && Directory.Exists(KeysDirPathUser)
+                ? KeysDirPathUser
+                : KeysDirPath;
+
         public static string LogsDirPath { get; private set; }
 
         public const string DefaultNandDir = "bis";

src/Ryujinx.HLE/FileSystem/VirtualFileSystem.cs

@@ -230,15 +230,20 @@ namespace Ryujinx.HLE.FileSystem
             string consoleKeyFile = null;
             string devKeyFile = null;
 
-            if (AppDataManager.Mode == AppDataManager.LaunchMode.UserProfile)
+            LoadSetAtPath(AppDataManager.GetKeysDir());
-            {
-                LoadSetAtPath(AppDataManager.KeysDirPathUser);
-            }
-
-            LoadSetAtPath(AppDataManager.KeysDirPath);
 
             HasKeySet = (prodKeyFile != null && titleKeyFile != null) || prodKeyFile != null;
             
+            
+            ExternalKeyReader.ReadKeyFile(
+                KeySet, 
+                prodKeyFile, 
+                devKeyFile, 
+                titleKeyFile, 
+                consoleKeyFile);
+
+            return;
+
             void LoadSetAtPath(string basePath)
             {
                 string localProdKeyFile = Path.Combine(basePath, "prod.keys");
@@ -266,13 +271,6 @@ namespace Ryujinx.HLE.FileSystem
                     devKeyFile = localDevKeyFile;
                 }
             }
-
-            ExternalKeyReader.ReadKeyFile(
-                KeySet, 
-                prodKeyFile, 
-                devKeyFile, 
-                titleKeyFile, 
-                consoleKeyFile);
         }
 
         public void ImportTickets(IFileSystem fs)

src/Ryujinx.HLE/HOS/Services/Nfc/AmiiboDecryption/AmiiboBinReader.cs

@@ -334,7 +334,7 @@ namespace Ryujinx.HLE.HOS.Services.Nfc.AmiiboDecryption
 
         private static string GetKeyRetailBinPath()
         {
-            return Path.Combine(AppDataManager.KeysDirPath, "key_retail.bin");
+            return Path.Combine(AppDataManager.GetKeysDir(), "key_retail.bin");
         }
 
         public static bool HasAmiiboKeyFile => File.Exists(GetKeyRetailBinPath());

src/Ryujinx/Headless/HeadlessRyujinx.cs

@@ -156,13 +156,10 @@ namespace Ryujinx.Headless
                 option.UserProfile = profile.Name;
 
             // Check if keys exists.
-            if (!File.Exists(Path.Combine(AppDataManager.KeysDirPath, "prod.keys")))
+            if (!File.Exists(Path.Combine(AppDataManager.GetKeysDir(), "prod.keys")))
-            {
-                if (!(AppDataManager.Mode == AppDataManager.LaunchMode.UserProfile && File.Exists(Path.Combine(AppDataManager.KeysDirPathUser, "prod.keys"))))
             {
                 Logger.Error?.Print(LogClass.Application, "Keys not found");
             }
-            }
 
             ReloadConfig();
 

src/Ryujinx/Program.cs

@@ -189,13 +189,10 @@ namespace Ryujinx.Ava
             DriverUtilities.InitDriverConfig(ConfigurationState.Instance.Graphics.BackendThreading == BackendThreading.Off);
 
             // Check if keys exists.
-            if (!File.Exists(Path.Combine(AppDataManager.KeysDirPath, "prod.keys")))
+            if (!File.Exists(Path.Combine(AppDataManager.GetKeysDir(), "prod.keys")))
-            {
-                if (!(AppDataManager.Mode == AppDataManager.LaunchMode.UserProfile && File.Exists(Path.Combine(AppDataManager.KeysDirPathUser, "prod.keys"))))
             {
                 MainWindow.ShowKeyErrorOnLoad = true;
             }
-            }
 
             if (CommandLineState.LaunchPathArg != null)
             {

src/Ryujinx/UI/SetupWizard/Pages/Keys/SetupKeysPageContext.cs

@@ -83,16 +83,9 @@ namespace Ryujinx.Ava.UI.SetupWizard.Pages
 
             try
             {
-                string systemDirectory = AppDataManager.KeysDirPath;
-                if (AppDataManager.Mode == AppDataManager.LaunchMode.UserProfile &&
-                    Directory.Exists(AppDataManager.KeysDirPathUser))
-                {
-                    systemDirectory = AppDataManager.KeysDirPathUser;
-                }
-
                 Logger.Info?.Print(LogClass.Application, $"Installing keys from {KeysFolderPath}");
 
-                ContentManager.InstallKeys(KeysFolderPath, systemDirectory);
+                ContentManager.InstallKeys(KeysFolderPath, AppDataManager.GetKeysDir());
 
                 NotificationManager.Information(
                     title: LocaleManager.Instance[LocaleKeys.RyujinxInfo],

src/Ryujinx/UI/ViewModels/MainWindowViewModel.cs

@@ -1018,12 +1018,7 @@ namespace Ryujinx.Ava.UI.ViewModels
         {
             try
             {
-                string systemDirectory = AppDataManager.KeysDirPath;
+                string systemDirectory = AppDataManager.GetKeysDir();
-                if (AppDataManager.Mode == AppDataManager.LaunchMode.UserProfile &&
-                    Directory.Exists(AppDataManager.KeysDirPathUser))
-                {
-                    systemDirectory = AppDataManager.KeysDirPathUser;
-                }
 
                 string dialogTitle =
                     LocaleManager.Instance.UpdateAndGetDynamicValue(LocaleKeys.DialogKeysInstallerKeysInstallTitle);