mirror of
https://github.com/alexkulya/pandaria_5.4.8.git
synced 2025-12-30 19:37:05 +00:00
17 lines
No EOL
841 B
Markdown
17 lines
No EOL
841 B
Markdown
Coding and Pull Requests
|
|
-----------
|
|
|
|
* We generally follow the Sun/Oracle coding standards.
|
|
* No tabs; use 4 spaces instead.
|
|
* No trailing whitespaces.
|
|
* No CRLF line endings, LF only, put your gits 'core.autocrlf' on 'true'.
|
|
* The number of commits in a pull request should be kept to a minimum (squish them into one most of the time - use common sense!).
|
|
* No merges should be included in pull requests unless the pull request's purpose is a merge.
|
|
* Pull requests should be tested (does it compile? AND does it work?) before submission.
|
|
* Any major additions should have documentation ready and provided if applicable (this is usually the case).
|
|
* Try to follow test driven development where applicable.
|
|
|
|
-----------
|
|
Useful Links
|
|
-----------
|
|
squashing commits -- http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html |