mangos-mirror/server
0
0
Fork 0
mirror of https://github.com/mangosfour/server.git synced 2025-12-16 13:37:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

[8603] corrected comment of last commit

Browse source 
the problem was in Unit::setFeared
which got called after removing a fearaura

inside setFeared there is a check for isAlive()
which will return true in this case, cause m_deathState
is updated only after RemoveAllAurasOnDeath()

a fix could be to set m_deathState earlier, but
then auras which require a spellcast on remove
won't work anymore..
(not sure if we actualy have such auras)

but if in future more functions will require special code there,
moving the m_deathState setting should be considered

big thx to Naicisum for explanation and investigation
This commit is contained in:
balrok 2009-10-09 01:15:50 +02:00
parent 5a48fe3c96
commit c999490aa2
2 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/game/Unit.cpp
View file

@ -10014,7 +10014,8 @@ void Unit::setDeathState(DeathState s)
RemoveGuardians(); RemoveGuardians();
UnsummonAllTotems(); UnsummonAllTotems();
// avoid that corpses run in fear // after removing a Fearaura (in RemoveAllAurasOnDeath)
// Unit::SetFeared is called and makes that creatures attack player again
StopMoving(); StopMoving();
ModifyAuraState(AURA_STATE_HEALTHLESS_20_PERCENT, false); ModifyAuraState(AURA_STATE_HEALTHLESS_20_PERCENT, false);

2
src/shared/revision_nr.h
View file

@ -1,4 +1,4 @@
#ifndef __REVISION_NR_H__ #ifndef __REVISION_NR_H__
#define __REVISION_NR_H__ #define __REVISION_NR_H__
#define REVISION_NR "8602" #define REVISION_NR "8603"
#endif // __REVISION_NR_H__ #endif // __REVISION_NR_H__