Value can be -9 to 9. Value point to actual rewarded value in dbc store.
This id can then fully replace current use of RewRepValueN, as this field will most likely be reserved for custom reputation rewards (override RewRepValueId).
Old system/DB data will still work like normal, but be aware this may change in not too far away future.
Signed-off-by: NoFantasy <nofantasy@nf.no>
Also rename an existing field to RewHonorAddition.
Note: calculation of real reward must be corrected accordingly.
Signed-off-by: NoFantasy <nofantasy@nf.no>
* It was wasting CPU power as cell-level locking is not needed.
* Future multithreading will be on map-level.
* CellLock was just a 'proxy' between Cell and CellPair and in some cases carried redundant data.
* Some minor cleanup in Cell::Visit/Map::Visit.
... and other FFA areas. Problem is result chnages in related flags work after old 3.x switch.
* Added high-level functions for FFAPvP state set for unit
* Apply FFA PvP to all controlled units also at set, and at summon/load
* Implemented proper combat rating fields update like other stats fields.
This will prevent reset combat ratings at .reset stats for example.
* Skill loading moved after InitStatsForLevel for prevent reset fields setup
as part of aura apply from skill set triggered spell casts.
This fix for example talent 53125 work (combat rating set at skill loading)
* use UI64FMTD instead of "%u" for uint64 output
* on most *NIX systems, I64FMT is "%016lX" and not "%016llX"
* also fix typo: renamed GridMap::loadHeihgtData to GridMap::loadHeightData
Note: there are still many warnings from the 3rd party libraries g3dlite and ACE. Those warnings won't be fixed with that commit.
Also, a few warnings from MaNGOS are left, they'll be fixed later.
Signed-off-by: XTZGZoReX <xtzgzorex@gmail.com>
* Not unsummon warlock pets at logout.
* Prevent overwrite current saved pet at save secondary pet (with temporary unsummoned first).
This possible at arena for example.
* Not fixed: in char list at login pet don't must be show with character if character saved at mount in game.
Not critical and maybe not need fix as feature ;)
* No unsummon temporary pet at non-fly mounting.
* Implement client side disable pet's action bar for mountted owner time
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
* implement server side action disabled case (action bar modify, aggro reaction and autocast)
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
* Add constructores for spellmode creating instead explcit fields init
* Use uint32 for family mask 2 instead unneded uint64
Also drop one from manual applies for uno-existed now spell.