Commit graph

3098 commits

Author SHA1 Message Date
VladimirMangos
1f741a16b3 [9898] Implement redundent values check in spell_bonus_data
Also do table content cleanup base at added feature.

Original check code provided by nos4r2zod.
2010-05-15 11:25:21 +04:00
VladimirMangos
6e92d43237 [9897] Avoid multiply AP bonus coeff. with spell power bonus.
Problem exist in original code before recent commits.
2010-05-15 11:17:38 +04:00
nos4r2zod
b2b8ca1d70 [9896] Cleanup spell bonus coeff use code
* Avoid coeff calculation if target value is 0.0f
* Avoid use spell_bonus_data coeffs for creature damage.

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-05-15 11:17:17 +04:00
nos4r2zod
e880e7d236 [9895] Move DotFactor+GetSpellCastTimeForBonus call to CalculateDefaultCoefficient
* This coeff used if not spell_bonus_data provided for spell
* Continue prev. commit line expected that creature casts not affected by DotFactor

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-05-15 11:16:02 +04:00
nos4r2zod
4951f846dd [9894] Move GetCastingTimeForBonus and some other code to GetSpellCastTimeForBonus.
Important changes:

* Chaged way caluclation "-5% of total per any additional effect" to percent
  apply instead use raw value that correct only for 3500 cast time spells.
* GetSpellCastTimeForBonus result now alwasy not applied to creature casted spells
  Before it not applied only to instant spells. Please test if this ok in all cases.
* Leech effect modify spell casting time move into GetCastingTimeForBonus and then called
  also for melee spells. But only creature spells exist with melee class damage and its
  not affected by GetCastingTimeForBonus anyway now.

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-05-15 11:15:05 +04:00
nos4r2zod
34a1cc31d0 [9893] Fixed some spelling typos in function/structure names.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-05-15 11:14:03 +04:00
j4r0d
19b5d777cd [9892] Cleanups for BattleGroundEY code
Signed-off-by: VladimirMangos <vladimir@getmangos.com>

Also prevent send uninitilized mark data in case BATTLEGROUND_EY end.
Simplify related code.
2010-05-14 23:29:49 +04:00
NoFantasy
312a076491 [9891] Implement *_scripts for creature_movement
New field script_id in creature_movement can be filled for each waypoint point and run the corresponding script from creature_movement_scripts.
Script_id can be any value and several points/creatures can share the same script (with limits of course, such as script depending on location and other factors).

DB projects are advised to move current text, spells and emotes data in creature_movement fields as these fields are strictly no longer needed and may be fully removed in the future.

Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-05-14 12:16:54 +02:00
NoFantasy
5a72466935 [9890] Add TYPEMASK_WORLDOBJECT to enum TypeMask
Check typemask and replace a few dynamic_cast with more simple casts.

Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-05-13 17:51:49 +02:00
NoFantasy
31ec245b68 [9889] Extend features available for SCRIPT_COMMAND_TALK
* Allow other than Creature to talk.
* Add "buddy-talk", using creature entry in datalong2 (the npc who will do the talk instead of the original source). Value in datalong3 is how far to look for the buddy.
* Add data_flags making it possible to have conversations between units, controlling who does the talking and to whom, including make player do the talking when player is not already the source.

Notes and details are added in the comments for SCRIPT_COMMAND_TALK

Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-05-13 16:39:04 +02:00
Laise
0344a8e838 [9888] Party restore IsKnowHowFlyIn and add area arg 2010-05-13 15:15:46 +03:00
Laise
a002f22916 [9887] Fix special mounts using in Dalaran 2010-05-13 14:42:55 +03:00
VladimirMangos
080727cbfa [9886] Implement new commands for account search
* .lookup account email, .lookup account ip, .lookup account name
* For new commands and for .lookup player versions use first arg as part of email/ip/name search
* Use similar output format for player/account lists.
2010-05-13 11:44:03 +04:00
tomrus88
a3e61dc560 [9885] Added VS2010 projects for maps extractor.
(based on commit 211997d)
2010-05-13 06:20:52 +04:00
Laise
188db9691f [9884] Code style fixes thx to hunuza & Wowka321 2010-05-12 17:43:15 +03:00
NoFantasy
b208effca6 [9883] Change SCRIPT_COMMAND_TALK to support CHAT_TYPE_* using enum ChatType
Making data consistent with other, similar tables like EventAI's text tables.
This convert existing data and also adds support for all chat types.

Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-05-12 14:09:38 +02:00
Laise
41c58f3be9 [9882] Add support for mounts dependent from riding skill and location 2010-05-12 13:34:10 +03:00
NoFantasy
faf3e287c7 [9881] Add additional fields to *_scripts tables for storage of more data.
Currently not in use by any SCRIPT_COMMAND_* but we have secret plans to be revealed in the future!

Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-05-12 12:02:38 +02:00
VladimirMangos
fecf6fdb72 [9880] Prepare world state inint packet data in more clean way.
* Avoid use hardcoded field amount values
* Avoid use world state update packets just after world state init packet
* Attempt make code look less horrible in general.
2010-05-12 09:28:03 +04:00
VladimirMangos
d3c34e93c9 [9879] Update battleground weekend world state at start/stop event. 2010-05-12 09:24:05 +04:00
GriffonHeart
c4247ece32 [9878] Set for client battleground weekend event world state.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-05-12 06:24:06 +04:00
Insider42
2edc375e48 [9877] One more meteor-like spell.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-05-12 05:26:10 +04:00
VladimirMangos
d04dd4e5bf [9876] Fixed TARGET_ALL_FRIENDLY_UNITS_AROUND_CASTER work
TARGET_ALL_FRIENDLY_UNITS_AROUND_CASTER expected seelction friendly targets
for spell caster around spell caster (so ignore original caster faction).
This meaning that for begative spell also selected friendly targets for
spell caster object.
2010-05-12 03:33:06 +04:00
Laise
5a572b9991 [9875] Fix immunity ignoring for delayed spells 2010-05-11 22:35:39 +03:00
reeshack
789f2f8167 [9874] Fix auras with custom periodic damage not entering spell/melee bonus damage done methods
Signed-off-by: Laise <fenrisse@gmail.com>
2010-05-11 22:20:57 +03:00
zergtmn
aa8a36afd4 [9873] Drop outdated code for 18788
Signed-off-by: Laise <fenrisse@gmail.com>
2010-05-11 16:19:21 +03:00
Insider42
a4c5734256 [9872] Update damage/energize calculation for 1454 and ranks.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-05-11 14:48:04 +04:00
VladimirMangos
b36cc9b258 [9871] Implement movement impairing effects for spell 58875.
Original part suggested by Insider42.
2010-05-11 14:08:17 +04:00
NoFantasy
3790084fb1 [9870] Add script id to all remaining SCRIPT_COMMAND_* error message outputs.
Note that script id can be id from different DB tables. It will however make it easier to find the source of any error.
More code cleanup and style corrections.

Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-05-11 11:46:18 +02:00
NoFantasy
d02313d94c [9869] Extend SCRIPT_COMMAND_QUEST_EXPLORED to allow player<->player as source/target
Additional code cleanup and output script id in error messages.

Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-05-11 11:00:58 +02:00
Insider42
c5008073f3 [9868] Impliment glyph 42905.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-05-11 12:52:53 +04:00
zhenya
fd131fb408 [9867] Prevent another potion drink until combat end.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-05-11 11:29:55 +04:00
VladimirMangos
3a2c28ca68 [9866] More weapon damage split spells. 2010-05-11 10:47:55 +04:00
Insider42
c4ee01422d [9865] Add support split damage for spells 66765, 67333.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>

Also small cleanup in mangos_spell_check.sql
2010-05-11 10:30:16 +04:00
zergtmn
fc91380b25 [9864] Use proper arg for player name send.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-05-11 08:32:32 +04:00
MaS0n
4e8c18e9de [9863] Implement SPELL_EFFECT_BREAK_PLAYER_TARGETING (93)
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-05-11 08:09:41 +04:00
VladimirMangos
6fb07911f9 [9862] Defines for some spelentry arrays.
* Move and rename MAX_REAGENTS to DBC Strcuture.h.
  It used only afore access to SpellEntry field and so part of strcuture definition.
* Add MAX_SPELL_TOTEMS and MAX_SPELL_TOTEM_CATEGORIES for same reasons, and use in code.
2010-05-11 00:06:47 +04:00
tomrus88
ff2cda6af1 [9861] Backporting some code chnages from 400 branch.
(based on 400's commit 0f37423)
(based on 400's commit 636cfef)
(based on 400's commit 0bbe3a7)
(based on 400's commit ce86b56)
(based on 400's commit b74c6a8)
2010-05-10 23:45:49 +04:00
NoFantasy
a0d9ffcc5f [9860] Add script effect of spell 54182
Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-05-10 20:43:03 +02:00
NoFantasy
8c81f0d058 [9859] Add dummy effect of spell 51964
Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-05-10 19:56:57 +02:00
Laise
884e4f8ecc [9858] Restore work of 1064 and ranks, broken in [9854] 2010-05-10 19:30:09 +03:00
Laise
aa59339e1a [9857] Fix double damage dealing of 63625 and ranks. Thanks to Revils 2010-05-10 12:06:10 +03:00
NoFantasy
aff0d77692 [9856] Add dummy effect of spell 51840
Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-05-09 23:15:49 +02:00
Laise
fc4c64b549 [9855] Fix some sqls from prev. commit 2010-05-09 20:36:47 +03:00
Laise
4c3d2805bd [9854] Fix negative amounts for spell base damage/healing and fix heal effects to correctly benefit from heal increasing/reducing auras 2010-05-09 20:33:36 +03:00
NoFantasy
7915d60765 [9853] Add dummy effect of spell 61832
Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-05-09 19:11:29 +02:00
NoFantasy
92d26dbebf [9852] Disable forced alteration of specialFlags in quest_template at startup.
This will allow quest 10162 to work properly with the expected data in quest_template (no specialFlags is needed), but will still give a startup error for spell 33824.

Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-05-09 09:56:28 +02:00
Laise
5c17458fb8 [9851] Restore work of 1856 and ranks 2010-05-08 13:47:31 +03:00
VladimirMangos
921b0d668f [9850] Fixed target selection for area spells casted from aura at enemy.
* Spell::GetCastingObject must be use for selection visual/point cast,
  not for friend/enemy checks. Add extanded GetAffectiveCasterObject
  for proper provide for referecned checks wild gameobject casted case.

* Also support chain damage spells casted by gameobjects.
2010-05-08 01:21:41 +04:00
hunuza
d1130af777 [9849] Implement character database clean up.
This can be disabled by config option.

Flag for clean up can be set for example on client version change.

Signed-off-by: hunuza <hunuza@gmail.com>
2010-05-07 23:08:24 +02:00