Action bar copied at spec creating and base at fact that talents not copied
possible cases when action bars not apporpriate for created spec.
So let its drop silencely
* Propertly add/remove required for specs work spells at 63624/63651.
* Copy current spec action bars to new spec at specs count increase, and delete action bars data at spec count decrease.
* Avoid undexpected action button data test for not active spec at loading/copy, but test action buttons data at spec activation.
* Reset active spec to default if active spec removed.
* Remove talent reset at spec switch that useless at this moment.
Also note that for future case this also can be not correct and batter unlearn/learn only talents that different in specs.
After this changes specs must fully work in action bar part without unexpected another effects.
Still needed for complete dual spec:
* support for second glyph set
* implement gossip options
* support for second talent set
Signed-off-by: hunuza <hunuza@gmail.com>
Value can be -9 to 9. Value point to actual rewarded value in dbc store.
This id can then fully replace current use of RewRepValueN, as this field will most likely be reserved for custom reputation rewards (override RewRepValueId).
Old system/DB data will still work like normal, but be aware this may change in not too far away future.
Signed-off-by: NoFantasy <nofantasy@nf.no>
Also rename an existing field to RewHonorAddition.
Note: calculation of real reward must be corrected accordingly.
Signed-off-by: NoFantasy <nofantasy@nf.no>
* It was wasting CPU power as cell-level locking is not needed.
* Future multithreading will be on map-level.
* CellLock was just a 'proxy' between Cell and CellPair and in some cases carried redundant data.
* Some minor cleanup in Cell::Visit/Map::Visit.
... and other FFA areas. Problem is result chnages in related flags work after old 3.x switch.
* Added high-level functions for FFAPvP state set for unit
* Apply FFA PvP to all controlled units also at set, and at summon/load
* Implemented proper combat rating fields update like other stats fields.
This will prevent reset combat ratings at .reset stats for example.
* Skill loading moved after InitStatsForLevel for prevent reset fields setup
as part of aura apply from skill set triggered spell casts.
This fix for example talent 53125 work (combat rating set at skill loading)
