Commit graph

331 commits

Author SHA1 Message Date
GiantCrocodile
46e1f87c04 corrected tabs 2020-02-17 09:21:58 +00:00
Xfurry
fccb0cffc6 Add positive exception for spell 56099 2020-02-17 09:21:56 +00:00
Schmoozerd
ae7348f6b0 [12774] Merged cmangos last changes, special thanks for xfurry, Dramacydal, cala, Schmoozerd,
I'm not taking any credits of this commit.

Implement spell effects 62042, 62278 and 64767
Also limit the targets for 62577 and 62603
----------
Update git_id to reflect recent sql formatting changes
----------
Update to a safer code version and also add GO caster scenarios
----------
Allow aura 62038 to stack at every 3 seconds
----------
Improve handling of TargetMMGen
This will have impact on Chase and Follow Movement.
----------
* Refactor code to check if a new position is required for the MMGen into the new function RequiresNewPosition
* Refactor code to get the current targeted distance into function GetDynamicTargetDistance
* Change ChaseMMGen (angle = 0.0f case) chase to best contact point, not zero angle.

Thanks to Cala and X-Savior for testing. Special thanks to cala for also suggesting improved values for the magic numbers
----------
Improve ObjectPosSelector
Now a spot already occupied by the searcher will be prefered
----------
Get rid of bounding radius in GetNearPoint[2D] and ObjectPosSelector
----------
This changes how ObjectPosSelector is used.
It changes the way how the functions Object::GetNearPoint and Object::GetNearPoint2d behave.
----------
So you need to check all places where these functions are used if they are still used correctly.
----------
Especially check your scripts!
----------
Remove not required duplicate indexes
----------
Implement TARGET_92 as TARGET_SUMMONER
This target is used only as TargetA and the related spells are used only by temporary summoned creatures
----------
Implement some spell effects used by Hodir in Ulduar
Dummy spells 62797, 63499, 63545 and 64543
Periodic dummy auras: 61968, 62038, 62039 and 65272
Limit targets for spells: 62797, 63545, 64543, 62476 and 62477
----------
Implement some spells used at Algalon encounter
Spell aura entries 64345, 62018 and 64412
Positive target exception for spell 64996
Aura stacking exception for spells 62169, 62168, 65250 and 64417
----------
Implement effect for spell 63633
----------
EventAI - Ingame output of script state
----------
With this the command .npc aiinfo will give more output about the current state.
Remark that this output is only given if the LogFilter for EventAIDev mode is disabled
----------
FindGit.cmake already ships with CMake
No reason for us to ship it too. Also, we had an outdated version which
had not been used anyway, because we set the include path in such a way,
that the CMake delivered version is always found first.
----------
FindOpenSSL.cmake already ships with CMake
No reason for us to ship it too. Also, we had an outdated version which
had not been used anyway, because we set the include path in such a way,
that the CMake delivered version is always found first.
----------
EventAI - Add more developing error output
----------
Fix some target-type handling for EventAI
Also increase log-output for bad target-types
----------
Fix crash due to bad compiler (author Xfurry)
----------
Add special condition id for Ulduar
Will be used to check the availability of the siege vehicles for players
----------
Update spells 62374 and 62907
* limit spell targets of spell 62374
* implement spell effect for spell 62907
----------
Remove effect for spell 64503
Will be handled in script library. For details please check 8502cdfa64
----------
Implement spells 64489 and 64673
Both are used by Auriaya (Ulduar)
----------
Implement some spells for Ignis the Furnace Master
Spell entries: 62717, 62381, 62488, 62707, 64475 and 64503
----------
Implement spells 61187 and 61190
----------
CMake: generic way to build a script library
Added new parameter INCLUDE_BINDINGS_DIR which can be set to the name of a
folder inside src/bindings/.

Includes the script library in src/bindings/ with the defined name.
The name must correspond to the name of the folder and the folder must contain
a valid CMakeLists.txt

Note: if you currently use a script library, you will probably get a merge
problem on src/bindings/CMakeLists.txt as you will have modified this file
manually. Please use the new version of this file and rerun CMake once with the
parameter -DINCLUDE_BINDINGS_DIR=ScriptDev2 (if you are not using SD2 but
another script library, replace ScriptDev2 with the name of the folder in
src/bindings/).

If you do not use a script library you should not have any merge problems
and you don't need to do anything.
----------
Add CMake source groups to target 'game'
This is the exact same grouping as it is currently in the VC 2012 files.
These groupings will have to be refactored at some point as they are not
very logical.
----------
Add CMake source groups to target 'framework'
This is the exact same grouping as it is currently in the VC 2012 files.
This is part of cmangos/issues#67
----------
Add CMake source groups to target 'shared'
This is the exact same grouping as it is currently in the VC 2012 files.
----------
Add new parameter 'expansion' to command 'account create'
----------
Update some Sunwell Plateau spells

Limit targets and allow positive effect for spell 46650
Implement effect for spells 46289 and 46637
Remove effect for spell 44845 - will be handled in script library
----------
Implement some custom use for Effect Activate Object spells
This will fix the summoning events for the Wind Stones, Ice Stones, Skettis bosses and quest 11865
----------
Sync mangos.sql with other versions
----------
Redump sql databases to unify formatting
The main reason for this was because classic/cata has updated the sql formatting and manually syncing would be a pain so redumping from master->tbc->classic->cata is easier.

Only the formatting was changed. The values were not changed at all.

mysqldump was used however manual modifications had to be done.

Dump the database:
C:/mysql/bin/mysqldump.exe mangos > sql/mangos.sql

Split insert values into multiple rows:
Replace "),(" with "),\n("
Replace "VALUES (" with "VALUES\n("

Remove the character sets by replacing them with an empty string

Custom formatting of mangos.sql:
Move db_version to the very top
Create all dbscripts_on_* tables based on dbscripts_on_creature_movement
Preserve our custom insert formatting of spell_affect (tbc/classic), spell_bonus_data, spell_chain, spell_elixir, spell_proc_event, spell_proc_item_enchant, spell_template, spell_threat
Remove autoincrement values from insert values of pet_name_generation and remove AUTO_INCREMENT=261 value from its table structure

Custom formatting of characters.sql:
Move character_db_version to the very top

Custom formatting of realmd.sql:
Move realmd_db_version to the very top
----------
Immediately remove corpses when ForcedDespawn is used
Thanks to Neotmiren for pointing, special thanks to cala for testing!
----------
Fix use of config values related to quest-status and level
This fixes use of negative value in config values Quests.LowLevelHideDiff and Quests.HighLevelHideDiff
Also add some documentation around the related code
Thanks to Neotmiren for pointing and to cala for testing.
----------
Loot-System: Fix reference loading check
This fixes a false error output for loot references that are only used with spell loot.
Thanks to X-Savior for properly reporting both error messages and use case
----------
Add missing spell 61437 to playercreate spells for bloodelves
Thanks to NeatElves for porting from TC and pointing to this
----------
Fix load bar step for alendarMgr::LoadCalendarsFromDB
----------
Cody Style Improvements
Also remove an unused variable (thanks to Den for this!)
----------
Implement the spells used in the Chess Event encounter
Combat spell entries: 37775, 37824, 39338, 39342, 39341, 39344, 45260
Melee spells: 37142, 37143, 37147, 37149, 37150, 37220, 37227, 37228, 37337, 37339, 37345, 37348
Chess movement spells: 30012, 32312, 37388, 30284, 37144, 37146, 37148, 37151, 37152, 37153
Aura stacking exception: 32261 and 39400
----------
And more hotfixes with these format strings
----------
Hotfix to recent text loading functions
----------
Use possible changed model names with vmap extraction
----------
Fix some warnings
----------
Store how many texts are loaded for validity checks. Use this with EventAI
----------
EventAI: Use generic DoDisplayText and loading of additional text data
----------
Add generic DoDisplayText function and use additional data of dbscripts table
----------
Add const-correctness to Text related functions
----------
Add database changes to support more data for DB Script texts
----------
Add stacking exception for spells 39993 and 40041
----------
Allow spell effect 86 - Activate Object to use the misc value
----------
Allow player pets to swim
----------
Enable resummoning of warlock pets
----------
Do not remove FLY auras on Evade
Also consider npcs which have SPELL_AURA_FLY as being able to fly
----------
EventAI: Improve code
* Drop rather pointless bool to check if the number of assigned events is empty
* Before the phase was resetted on death if and only if the npc has Events defined
* DoMeleeAttackIfReady could have been called even though combat state could have changed while processing events
----------
EventAI: Implement ACTION_T_SET_THROW_MASK (46)
This Action can be used to set which AIEvents should be thrown automatically, if you need more flexibility, you can always use the manual ACTION_TH_THROW_AI_EVENT version.
* Also clean some error-log output a bit.
----------
Forward original caster GUID to script library
----------
Fixup commit 12511 Thanks to Zakamurite for pointing
Also thanks to him for giving a helping hand in correcting the commit
----------
Implement some spells for Felmyst encounter
Spell entries: 45714, 45717 and 45918. Limit targets of spell 45391
Also add stacking exception for auras 45068 and 45582
----------
Fix invisible spirit healers & such on death near them
This fixes an issue that occurs if you die close to a spirit healer/guide.
----------
Fix take ammo for most ranged spells
Fix spells like Arcane Shot not taking ammo while they should
----------
Check cast spell 51690
----------
Fix SpellDamage modifier of SPELL_AURA_MOD_DAMAGE_DONE_CREATURE
This aura modifies a flat value, not a percent value.
----------
Implement proc effect of spells 67712, 67758
related to items 47316, 47477.
----------
Improve proc of spell 50421
----------
Add and implement server-side spell 23770
----------
EventAI: Improve TargetSelection related ErrorLog output
----------
DBScripts Engine: Change behaviour to search for a different npc when using buddy-search
With this an npc buddy will be interpreted as "another npc with entry"
Also toggle command 31 - TERMINATE_SCRIPT to also look only for other npcs of entry
----------
DBScripts Engine: Allow pets as buddy
Add new flag SCRIPT_FLAG_BUDDY_IS_PET (0x20) that will search not for a normal npc with buddy-search, but also for pets
----------
DBScripts Engine: Support buddy search by guid
* Add new `data_flags` flag SCRIPT_FLAG_BUDDY_BY_GUID (0x10)
If this flag is set, the content of `search_distance` is interpreted as db-guid of the requested buddy
* Also switch most error log output to DB-error log output (though this will include false positives)
----------
2020-02-17 09:20:48 +00:00
sanctum32
a5a5009d44 [12704] Fix (at least) two false positive startup errors
* Fix startup-error related to quest 10162
* Fix startup-error for spell 53821 (original author @Schmoozerd)
2020-02-17 09:20:43 +00:00
Schmoozerd
3d1d3805a2 [12670] Use normal cast time for triggered spells by default
Close cmangos/issues#195

Please report problems that might (or might not) arise

Signed-off-by: Schmoozerd <schmoozerd@cmangos>

(based on commit [12468] - 47aa389)
2020-02-17 09:20:21 +00:00
Antz
1997c1e903 Rebase resync 2020-02-17 09:19:44 +00:00
Dramacydal
6419d8b47a [c12651] Crashfix at server loading 2020-02-17 09:05:19 +00:00
Dramacydal
e34a5b388e [c12649] Implement SPELL_AURA_PHASE_2 2020-02-17 07:27:34 +00:00
Dramacydal
5bb01c478e [c12640] Fix sending player cooldowns after map change/login and Correct logic in SpellMgr::IsSpellProcEventCanTriggeredBy 2020-02-17 01:17:54 +00:00
billy1arm
ef445ea523 [12632] Revert previous commit (see Notes) 2020-02-17 00:54:15 +00:00
Xfurry
a498dcaebd [c12624] Implement spell 57578 2020-02-17 00:24:58 +00:00
Xfurry
da15d50aa2 [c12621] Add stacking exception for spells 57494 and 57492 2020-02-17 00:24:53 +00:00
Xfurry
630546c9df [c12619] Add positive exception for spell 38449 2020-02-17 00:24:49 +00:00
Xfurry
c28e14589f [c12618] Implement some spells used in Sunwell Plateau 2020-02-17 00:24:48 +00:00
Xfurry
a7a0dad043 [c12612] Implement some spells for Black Temple 2020-02-17 00:23:16 +00:00
Schmoozerd
15bb475d40 [c12599] Add support for condition_id to spell_area table 2020-02-17 00:07:38 +00:00
Xfurry
4f86b168c0 [c12598] Implement spells 19869 and 20037 2020-02-17 00:07:10 +00:00
Xfurry
18ceb2392c [c12597] Limit targets of spell 10258 2020-02-17 00:07:07 +00:00
Xfurry
3e12f9e6c7 [c12579] Add negative exception for spells 57508 - 57512 2020-02-16 23:19:57 +00:00
Dramacydal
537d6e98d9 [c12578] Implement spells 53035, 53036 and 53037 2020-02-16 23:19:55 +00:00
Xfurry
e241dd61ca [c12572] Add stacking exception for spells 53456 and 53421 2020-02-16 23:18:37 +00:00
Xfurry
c9aa7b5d3a [c12570] Add stacking exception for spells 50442 and 47941 2020-02-16 23:18:31 +00:00
Xfurry
d1e9390e82 [c12565] Add stacking exception for spells 51019 and 51024 2020-02-16 23:15:01 +00:00
Dramacydal
bf5c6b1ddd [c12562] Cleanup Style 2020-02-16 23:12:16 +00:00
Schmoozerd
a27787851c [c12537] Update Authorship information
(based on commit [12388] - 037f217)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
2020-02-16 21:27:46 +00:00
Schmoozerd
a05738717a [c12536] Happy New Year 2013
Update authorship information and prepare for easier ways next year

Signed-off-by: Schmoozerd <schmoozerd@cmangos>

(based on commit [12325] - b7dbcda)
2020-02-16 21:25:01 +00:00
Schmoozerd
16ecfbcf4d [c12531] Fix recently un-outcommented code to be actually working
(based on commit [12384] - 96d1f0e)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
2020-02-16 20:59:13 +00:00
Yaki Khadafi
8e84b0ff71 [12198] - Remove weapon skillgains, defense skill, thanks @FailzorD for original patch.
- Update dodge, parry, block to cata.
- Some mastery fixes and stylefixes.
- Remove some no longer used functions.

Signed-off-by: Yaki Khadafi <elsoldollo@gmail.com>
2020-02-16 20:42:16 +00:00
Salja
45f0facafe [12182] Crowd control spells PvP duration has been decreased to 8 seconds (down from 10) Thanks Shocker
Signed-off-by: Salja <salja2012@hotmail.de>
2020-02-16 20:41:59 +00:00
rsa
de95d1d480 [12123] Move BattleGround code to separate BattleGround directory. Also some corrects to unload BG's 2020-02-16 20:40:57 +00:00
Yaki Khadafi
48670fda6f [0145] Fix wrong logic in IsPositiveEffect.
Signed-off-by: Yaki Khadafi <ElSolDolLo@gmail.com>
2020-02-16 19:42:26 +00:00
Yaki Khadafi
93c5b1cf1d [0111] Implement rest of spell scaling
Signed-off-by: Yaki Khadafi <ElSolDolLo@gmail.com>
2020-02-16 16:19:19 +00:00
Yaki Khadafi
d16be01744 [0109] More spell cast time calculation research, defined SpellAttributesEx9 and SpellAttributesEx10
Signed-off-by: Yaki Khadafi <ElSolDolLo@gmail.com>
2020-02-16 16:19:17 +00:00
Yaki Khadafi
a7bf0fe70b [0103] Use SpellScaling.dbc to calculate cast time
Signed-off-by: Yaki Khadafi <ElSolDolLo@gmail.com>
2020-02-16 16:18:21 +00:00
Salja
22bfaa12b0 Mage 400 INTO master/434
Signed-off-by: Salja <salja2012@hotmail.de>
2020-02-16 01:59:51 +00:00
Schmoozerd
835d1c7479 [12069] Cleanup comment style 2012-07-22 14:39:31 +02:00
stfx
3707b04330 [12066] Optimize some parts for ++C 2012-07-21 17:15:11 +02:00
Schmoozerd
84080ee5d3 [12065] Fix various warnings 2012-07-20 21:17:04 +02:00
Schmoozerd
e32b9953a1 Cleanup Operator padding 2012-07-20 17:38:23 +02:00
Schmoozerd
08fd085549 Various Cleanups (game S) 2012-07-19 21:52:06 +02:00
Schmoozerd
6de10526cc [12058] Remove more header includes 2012-07-19 04:15:13 +02:00
Schmoozerd
f24fa870c5 [12057] Add some static wrappers for Lookup access to SQLStorages 2012-07-19 01:14:02 +02:00
Schmoozerd
b607d6a3fd [12025] Fix a stupid mistake from 12017 2012-07-03 17:14:42 +02:00
darkstalker
f777665d48 [12021] Fix some warnings
Thx to stfx for porting

Signed-off-by: stfx <stfx@hotmail.de>
Signed-off-by: Schmoozerd <schmoozerd@scriptdev2.com>
2012-06-25 15:40:27 +02:00
Schmoozerd
fb3a990b13 [12017] Add support for getRace() of creatures. Thanks to vladimir for input 2012-06-24 19:40:36 +02:00
Xfurry
77c5ae1684 [12001] Implement target limiting for spell 47669
Signed-off-by: Schmoozerd <schmoozerd@scriptdev2.com>
2012-06-12 23:54:20 +02:00
Schmoozerd
1f24d991e3 [11975] Use a few more enums instead of magic numbers 2012-04-22 23:45:06 +02:00
stfx
f3f3349661 [11973] Various Cleanups
Signed-off-by: Schmoozerd <schmoozerd@scriptdev2.com>
2012-04-22 19:48:05 +02:00
Schmoozerd
7fd1f64319 [11971] Add wrapper HasAttribute to check if a spell has an attribute
Signed-off-by: Schmoozerd <schmoozerd@scriptdev2.com>
2012-04-21 02:02:34 +02:00
Schmoozerd
8068dcf6dd [11875] Update Copyright notice to year 2012
Start timemachine and a Happy new year to all!
2012-01-16 17:43:59 +01:00