* This is let finally hide guid structure in ObjectGuid.h/.cpp code.
* Shared related code.
NOTE: while switch to use new clasess one more problem has been detected
with not-safe code in .pdump work for future per-map multi-threading.
It's need rewrited before will possible safe use in like case.
For current single world thread case it's safe.
Some items with negative by defaul charges not expected to be deletedt at no charges.
In past this fixed by using positive charges amount in like cases in different from
expected negative value. Adding new field for avoid this.
* Use area id instead zone id for home bind zone info as expected.
This will for example proper show capital name in area himebinding for capital; tavern.
* Clarify that player create zone in fact is area (subzone)
* Implement SPELL_EFFECT_BIND for normal homebinding.
Also support spell target position mode used in 53823/53821 spells
* Add Spell::EffectEmpty for mark spell effects that used but not expect any code in handler.
Example weapon spells that used just as known spell markers for client.
Original patch idea inspirit by Sadikum patch suggestion.
* For reload `gossip_menu`, `gossip_menu_option`, `gossip_scripts`,
`npc_gossip`, `points_of_interest` by single command.
* Also fixed reloading `points_of_interest`.
Value can be -9 to 9. Value point to actual rewarded value in dbc store.
This id can then fully replace current use of RewRepValueN, as this field will most likely be reserved for custom reputation rewards (override RewRepValueId).
Old system/DB data will still work like normal, but be aware this may change in not too far away future.
Signed-off-by: NoFantasy <nofantasy@nf.no>
* This must repolve problem with loot.
Before if some mob killed by group member and then leader changed
then group members can't loot this mob body.
* Possible resolve crashes at loot. Now group storage content not dependent from leader changes.
* GAMEOBJECT_TYPE_BUTTON can have linked traps
* Spell::EffectSummonObject also can summon objects with linked traps
Thanks to patman128 for research second case.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
Also rename an existing field to RewHonorAddition.
Note: calculation of real reward must be corrected accordingly.
Signed-off-by: NoFantasy <nofantasy@nf.no>
Values 0-8, used to display XP reward in client log.
Please note that calculation of quest XP has changed, and formula must be corrected accordingly.
Signed-off-by: NoFantasy <nofantasy@nf.no>
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
Also move calculation to function. And avoid use operator[] for access to per-area base xp table data.
