Please note that it may not be correct to handle them all in the same way.
Some more research should be done regarding the whole issue with creatures and faking death (cheaters) and a possible difference between the spells.
Signed-off-by: NoFantasy <nofantasy@nf.no>
Rewrite base at area aura type check
* For positive area aura types show at non-caster target or caster-totem or non-passive aura at caster
* For negative area aura show at non-caster target
* For other auars show at any target if non passive auras or totem-caster
In fact make triggered spell replace main spell for channeling.
This also let drop hack for target death case interrupt channeling for spell.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
* Propertly add/remove required for specs work spells at 63624/63651.
* Copy current spec action bars to new spec at specs count increase, and delete action bars data at spec count decrease.
* Avoid undexpected action button data test for not active spec at loading/copy, but test action buttons data at spec activation.
* Reset active spec to default if active spec removed.
* Remove talent reset at spec switch that useless at this moment.
Also note that for future case this also can be not correct and batter unlearn/learn only talents that different in specs.
After this changes specs must fully work in action bar part without unexpected another effects.
* It was wasting CPU power as cell-level locking is not needed.
* Future multithreading will be on map-level.
* CellLock was just a 'proxy' between Cell and CellPair and in some cases carried redundant data.
* Some minor cleanup in Cell::Visit/Map::Visit.
* Also replace check/take functions for runes by single 2 mode function
* Implement proper check for dead runes case
* Implement proper rune selection for Aura::HandleAuraConvertRune
This allow DoT crits from 2944 and ranks for example.
(based on commit be72957)
Also included improvement from Lynx3d for resilence and crit threat affect.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
* Use stack size in additional spell damage for 31803/53742.
* Use in code calculation for additional spell 20187/20375 damage
Thanks to MrLama for small cleanups and patch updating.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
You need extract new dbc.
Also recommended extract new map/vmaps.
And apply ofc sql updates that including character convertion.
Special thanks to TOM_RUS for continue work at next client versions support :)
