Action bar copied at spec creating and base at fact that talents not copied
possible cases when action bars not apporpriate for created spec.
So let its drop silencely
* Propertly add/remove required for specs work spells at 63624/63651.
* Copy current spec action bars to new spec at specs count increase, and delete action bars data at spec count decrease.
* Avoid undexpected action button data test for not active spec at loading/copy, but test action buttons data at spec activation.
* Reset active spec to default if active spec removed.
* Remove talent reset at spec switch that useless at this moment.
Also note that for future case this also can be not correct and batter unlearn/learn only talents that different in specs.
After this changes specs must fully work in action bar part without unexpected another effects.
... and other FFA areas. Problem is result chnages in related flags work after old 3.x switch.
* Added high-level functions for FFAPvP state set for unit
* Apply FFA PvP to all controlled units also at set, and at summon/load
* Implemented proper combat rating fields update like other stats fields.
This will prevent reset combat ratings at .reset stats for example.
* Skill loading moved after InitStatsForLevel for prevent reset fields setup
as part of aura apply from skill set triggered spell casts.
This fix for example talent 53125 work (combat rating set at skill loading)
* No unsummon temporary pet at non-fly mounting.
* Implement client side disable pet's action bar for mountted owner time
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
* implement server side action disabled case (action bar modify, aggro reaction and autocast)
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
* Add constructores for spellmode creating instead explcit fields init
* Use uint32 for family mask 2 instead unneded uint64
Also drop one from manual applies for uno-existed now spell.
some shapeshift forms will give the player spells
so we need to tell the server that the player has those new
spells else he can't cast them since the server is thinking the player is
cheating
ps forms with spells:
FORM_GHOUL
FORM_THARONJA_SKELETON
FORM_TEST_OF_STRENGTH
FORM_BLB_PLAYER
FORM_TEST
FORM_ZOMBIE
--
so this mostly won't affect any ingame experience.. but good to have this
feature anyway.. :)
also changed errormessage if player has no reagents for spell..
thx to nofantasy
As result, gossip for GO is now possible. Moved related data structures and remove useless from code.
Please note that after some time, table npc_gossip will be fully removed (use menuId in _template in relation to gossip_menu as replacement).
Special thanks to GriffonHeart for help with research, discussions and ideas of code and thanks to Vladimir for helpful input.
Signed-off-by: NoFantasy <nofantasy@nf.no>
Adjust arguments passed in functions accordingly, for easier implementation of gossip for Gameobjects in future.
Some additional code cleanup in affected functions.
