Commit graph

180 commits

Author SHA1 Message Date
balrok
7a2764e0fe [8829] some more places where we call redundant SaveToDB
i also added now my assert with which i've found them..
maybe someone want's to look at other cases too :)
2009-11-18 19:13:03 +01:00
tomrus88
fe55f76a26 Merge remote branch 'origin/master' into 330 2009-11-16 02:01:51 +03:00
balrok
6199396b69 [8821] removed some redundant player->SaveToDB calls
SaveToDB will already be called at "SpawnCorpseBones"
so no need to do this twice
2009-11-15 20:08:57 +01:00
tomrus88
3def8fa353 Merge remote branch 'origin/master' into 330 2009-11-10 17:35:09 +03:00
XTZGZoReX
0734adb746 [8789] Rename several singleton macros to use more consistent names.
* objmgr -> sObjectMgr
 * spellmgr -> sSpellMgr
 * WaypointMgr -> sWaypointMgr
 * poolhandler -> sPoolMgr
 * objaccessor -> sObjectAccessor
 * mapmgr -> sMapMgr
 * sInstanceSaveManager -> sInstanceSaveMgr
 * ticketmgr -> sTicketMgr
 * CreatureEAI_Mgr -> sEventAIMgr
 * auctionmgr -> sAuctionMgr
 * achievementmgr -> sAchievementMgr
2009-11-08 12:11:34 +01:00
XTZGZoReX
dc725ad6b8 [8785] Use macro instead of explicit call to singleton Instance().
* For: ObjectAccessor, MapManager.
2009-11-08 03:54:41 +01:00
XTZGZoReX
1f23884757 Don't use singleton to access static functions.
* This affects especially ObjectMgr functions:
   - GetCreatureInfo
   - GetGameObjectInfo
   - GetInstanceTemplate
   These are in fact static functions.
2009-11-08 03:54:27 +01:00
VladimirMangos
150ac4c76e [8782] Prevent packet problem spam in log at rejected CMSG_WORLD_TELEPORT. 2009-11-07 18:44:22 +03:00
tomrus88
3e934e4d02 Merge commit 'origin/master' into 330 2009-10-26 01:07:32 +03:00
VladimirMangos
fad1fb92f4 [8731] Restore difficulty 1 spawn use for creatures with special difficulty 1 versions.
* Rename creature template `heroic_entry` => `difficulty_entry_1`
  Possible need add 2 more fields for 2-3
* Use 2 more EventAI EFLAG_* flags for 2-3 difficulty support, update checks.
* Update area trigger code.

Note: support for specialized creature version for difficulties 2-3 not added yet
      and will be used same as difficulty 1 mode.

TODO: Rename area triggers heroickey/etc fields ?
2009-10-25 06:23:00 +03:00
tomrus88
d599aea0ba Updated to latest PTR client build 10676. 2009-10-24 19:38:37 +04:00
tomrus88
f46c1aaabb Merge commit 'origin/master' into 330
Conflicts:
	src/game/MiscHandler.cpp
2009-10-10 17:28:59 +04:00
balrok
45f6a474bf [8608] implement BattleGround Alterac Valley
sql won't be included - please look at your database
providers forum

also note, that creature_loot_template id 0
is used for the loot of dead players in this bg
(after a player died and you remove insignia from him..
he not only drops money - he drops some random items too)

further work must be done in better code for adjusting right
levels to creatures - maybe using something similar like it's
done in heroic instances

also quests and creatures needs some scripts in future

thanks to:
netsky - initial start of this patch
bogie - 2nd person writing on this patch
triply, kapatejib, vladimir - code review and suggestions
arrai - for his great tool and help
and all testers / code contributers - I won't write
down a list, else I would forget most probably one ^^
2009-10-09 18:18:22 +02:00
VladimirMangos
308439a335 [8601] Fixed some movement *_ACK packets structure after switch. 2009-10-08 16:02:28 +04:00
tomrus88
90a80471f7 Merge commit 'origin/master' into 330 2009-10-07 16:37:49 +04:00
VladimirMangos
d38866cfbc [8590] Restore build at Unix/Linux. 2009-10-06 15:34:33 +04:00
tomrus88
c9636623bf Added support for 3.3.0 PTR client. 2009-10-06 13:44:48 +04:00
VladimirMangos
a9af7f2b1c Use reset time for normal/heroic from new DBC. Improve basic support for raid difficalties. 2009-10-06 02:12:02 +04:00
tomrus88
2d86aa4535 Misc fixes. 2009-09-14 18:11:15 +04:00
tomrus88
d26712c6ba Merge commit 'origin/master' into 320
Conflicts:
	src/game/CharacterHandler.cpp
	src/game/Opcodes.cpp
	src/game/WorldSession.h
2009-08-29 12:01:39 +04:00
VladimirMangos
5cf72882ad [8433] Implement proper store and use character specific account data.
* Base at TOM_RUS reseach save/load character specific account data in new table `character_account_data`
* Move its in sql update from `account_data` to new table.
* For client packets that can be send in loggined state or just after logout but assocualted
  with recently logout character add new login status STATUS_LOGGEDIN_OR_RECENTLY_LOGGOUT
* Store low guid for loggedin player or recently logout into WorldSession.
2009-08-29 11:26:57 +04:00
tomrus88
fdc20af337 Some fixes. 2009-08-28 22:33:52 +04:00
tomrus88
3882772658 Merge commit 'origin/master' into 320
Conflicts:
	src/game/Player.cpp
2009-08-27 01:54:04 +04:00
VladimirMangos
45dd7140b5 [8422] Implement far sight like spells work for long distance.
* Added basic infrastructure for visibility update in case difference player and current view point.
  Just for note: seletect additional arg way beacuse repeatable search object will slow but store pointer will not safe,
  so use middle case: get view point pointer early as possible at visibility updates.
* Implement dynamic object and creature activisation while it's target of far sight spell effect
* Use this for SPELL_AURA_BIND_SIGHT, SPELL_AURA_FAR_SIGHT and SPELL_EFFECT_ADD_FARSIGHT.
* Note2: some spyglass like spells let look _around_ at long distance, this hard implement in current grid loading system
  Without additional changes and not implemented (you will see empty area without creatures in likes case)

* Also fixed warning spam at CMSG_MOVE_SET_CAN_FLY_ACK receive by use proper packet sructure reading.
2009-08-26 08:30:40 +04:00
tomrus88
ed2b97287b Compile fix. 2009-08-24 01:28:12 +04:00
tomrus88
e7353428b1 Fixed one more opcode.
Added startup check for gameobject displayid==0.
2009-08-24 00:59:23 +04:00
tomrus88
fec1a1954c Merge commit 'origin/master' into 320
Conflicts:
	src/game/MovementHandler.cpp
2009-08-20 16:24:37 +04:00
tomrus88
3097dcda2b Removed useless code. 2009-08-20 16:18:34 +04:00
VladimirMangos
f45253ac8b [8393] Fixed format CMSG_FORCE_MOVE_UNROOT_ACK and CMSG_FORCE_MOVE_ROOT_ACK.
Also avoid packet tail warnings spam at rejected movement packets.
2009-08-20 00:15:34 +04:00
VladimirMangos
35121cdd34 [8389] Implement check really read received packet size and warning it not all data read.
* This let more easy catch packet structure chnages at client switch.
* Fixed structure CMSG_GUILD_BANK_SWAP_ITEMS
* Fixed structure CMSG_SPLIT_ITEM, CMSG_SELL_ITEM
* Added read data amount fixes for some other packets.

Thanks to TOM_RUS in help check correct packets structure.

Note: not all packets possible fixed. Please report for not fixed cases at errors:
"opcode %s (0x%.4X) have unprocessed tail data (read stop at %u from %u)"
2009-08-19 00:45:24 +04:00
arrai
6e70c05191 [8386] Fixed areatrigger distance check
Old check caused false positives for trigger #4853
2009-08-18 17:41:28 +02:00
arrai
c34ff46443 [8385] Use 3D coordinates for checking corpse distance at reclaiming 2009-08-18 16:09:10 +02:00
tomrus88
373a837aa5 Merge commit 'origin/master' into 320 2009-08-18 09:30:02 +04:00
VladimirMangos
2b534cbc23 [8382] Implement ByteArray functions for skip read of fields not needed for server in received packets.
* Use this fucntions in some case.
* Change some packets to form: read fields first check later for better control recieved packets structure.
* Fix CMSG_STAND_STATE_CHANGE packet structure to more correct.
2009-08-18 03:49:50 +04:00
tomrus88
f553cf2887 Merge commit 'origin/master' into 320
Conflicts:
	src/game/CharacterHandler.cpp
	src/game/DuelHandler.cpp
	src/game/ItemHandler.cpp
	src/game/Mail.cpp
	src/game/MiscHandler.cpp
	src/game/MovementHandler.cpp
	src/game/TaxiHandler.cpp
	src/game/WorldSession.h
	src/game/WorldSocket.cpp
2009-08-17 10:31:02 +04:00
arrai
a24f39a36f [8378] Use exceptions instead of explicit size checking for each packet
CHECK_PACKET_SIZE was pretty error prone; once it was forgotten mangosd
could crash due to the asserts in ByteBuffer.h. That was exploitable by
malicious players.
Furthermore, there were duplicate checks: Additionally to
CHECK_PACKET_SIZE, the ByteBuffer assertions keept an eye
on not exceeding the packet boundaries - just to crash the server for
sure in such a case.
To prevent memory leaks or other undesirable states, please read in
every handler all variables _before_ doing any concrete handling.
2009-08-16 23:50:22 +02:00
tomrus88
6bf8eb346d Added CMSG_WORLD_STATE_UI_TIMER_UPDATE handler. 2009-08-08 18:28:22 +04:00
tomrus88
7c52111fb1 Fixed /played chat command.
(cherry picked from commit 3e49bbe692ea5f44ea2daffdfe970a7201d501f5)

Conflicts:

	src/game/MiscHandler.cpp
	src/game/SharedDefines.h
	src/game/UpdateFields.h
	src/realmd/AuthCodes.h
2009-07-29 15:14:23 +04:00
tomrus88
3058ba26c6 Applied coding style. 2009-07-28 17:04:01 +04:00
tomrus88
786e48cdba [8262] Fixed work /played client chat command.
Thanks to The_Game_Maste for prepering patch for master branch.

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-07-28 01:03:59 +04:00
tomrus88
299f40ac0c Merge commit 'origin/master' into 320 2009-07-26 10:52:21 +04:00
tomrus88
1c93b206e8 Updated to 10147 client build. 2009-07-25 13:50:28 +04:00
SilverIce
0cf083eb55 [8231] Use more safe destination buffer size for zlib compression.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-07-22 15:59:36 +04:00
tomrus88
a26e90019b /played command should work once again. 2009-07-22 01:25:15 +04:00
tomrus88
4c709772c1 Merge commit 'origin/master' into 320
Conflicts:
	src/game/Player.cpp
	src/game/Totem.cpp
2009-07-21 08:22:30 +04:00
XTZGZoReX
4f53c4ee28 [8193] Use constant instead explicit value in title index checks.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-07-17 19:29:48 +04:00
tomrus88
02f9416963 Merge commit 'origin/master' into 320 2009-07-16 13:23:03 +04:00
VladimirMangos
c129b0a1bd [8185] Allow set visible gm level for in gm list and in who list checks.
* GM.InGMList replaced by GM.InGMList.Level with default value 3 (visible any gm levels)
* GM.InWhoList replaced by GM.InWhoList.Level with default value 3 (visible any gm levels)

Update mangosd.conf if used non default value for old GM.InGMList and GM.InWhoList
2009-07-16 02:54:57 +04:00
tomrus88
2066de036f Updated auras enum, dbc comments. 2009-07-11 10:36:56 +04:00
tomrus88
c9258deb5a Updated to 10072 client build. 2009-07-08 22:03:53 +04:00