Commit graph

5094 commits

Author SHA1 Message Date
Laise
8f71d95c0d [10642] Implement spell 56826 2010-10-25 15:20:28 +02:00
VladimirMangos
46d740bbf4 [10641] Fixed use item dynamic/item proto flags.
* List its independelty. Each from this 2 fields have own flags. Cleanup lists.
* Not copy proto flags to item flags update field. This fix heroic item versions
  show in client in result mixed use ITEM_DYNFLAG_WRAPPED (0x8) with ITEM_FLAG_HEROIC (0x8)
* Update uses to proto case use for some cases where before wrongly has been used item dyn.flags
* For ITEM_DYNFLAG_UNLOCKED (0x4) set for item at unlock and check for prevent re-unlocking.
  This mostly for future case when will be implemented partly loting items support.
* For ITEM_FLAG_LOOTABLE (0x4) check loot absent or conflicting setting with containers/casted at use items.
  Report wrong cases art loading.
* Better check related loot tables content using ITEM_FLAG_PROSPECTABLE and ITEM_FLAG_MILLABLE
2010-10-25 16:27:14 +04:00
Tasssadar
d53fe93e9d [10640] Implement instance guids with proper HIGHGUID_INSTANCE use.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-10-24 14:54:11 +04:00
NoFantasy
365c4a19e0 [10639] Making dummy effect of spell 54530 be positive effect.
Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-10-24 11:18:46 +02:00
VladimirMangos
a79f9b1fe4 [10638] More appropriate for warrior spell fail result for combo point check fail. 2010-10-24 09:28:13 +04:00
VladimirMangos
666ecfee99 [10637] Better totem summon cases selection.
But added check still not allways work. Unclear better way selections for summon prop id 61
2010-10-22 11:41:26 +04:00
VladimirMangos
691412d05c [10636] Implement server side check combo points req. for spell cast.
Thanks to nos4r2zod for problem research.
2010-10-21 15:00:56 +04:00
VladimirMangos
7a26fdd45d [10636] Ignore another map target for text emote. 2010-10-21 11:01:42 +04:00
VladimirMangos
851e15c70a [10635] Convert many opcode handlers to ObjectGuid use.
Also re-enabled anticheating check for bank window open
base at .bank command access rights.
2010-10-21 10:43:14 +04:00
VladimirMangos
0901a4c2ac [10634] Include non-percent mana cost in EffectDestroyAllTotems mana return.
Also small speedup for no-return spells.
2010-10-21 01:57:45 +04:00
NoFantasy
bf2b256720 [10633] Correct behavior for completion of quest objectives.
Rename related function to SendQuestCompleteEvent for clarification of when it's expected to be used.

Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-10-20 12:57:47 +02:00
Salja
8886b86a2b [10632] Small comment style fix in mangosd.conf
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-10-20 12:54:31 +04:00
NoFantasy
2fe87fc3c7 [10631] Small code style cleanup in quest related functions
Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-10-20 09:34:06 +02:00
VladimirMangos
da07caba28 [10630] Convert Set(Get)ChannelObjectGuid to ObjectGuid way.
Also fix typo in debug output for prev. commit.
2010-10-20 11:19:47 +04:00
VladimirMangos
31c9efd219 [10629] Drop function GuidHigh2TypeId
Added ObjectGuid version Aura::GetCasterGuid()

But for prevent big problen with backporting AuraHolder
to mangos-0.12 in most cases still used old uint64 version
Aura::GetCasterGUID.

Recommended use new version where possible in clean way
as done for some cases in commit already.
2010-10-20 09:12:43 +04:00
VladimirMangos
fdc5a1dd67 [10628] SQL update for prev. commit 2010-10-20 08:23:18 +04:00
VladimirMangos
c955941b55 [10627] Use ObjectGuid for player's selection and unit's target 2010-10-20 08:19:48 +04:00
zerg
e74d56f9d2 [10626] Fix logic in FillRaidOrPartyManaPriorityTargets and FillRaidOrPartyHealthPriorityTargets
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-10-20 03:08:59 +04:00
fgenesis
c46d3bf9b0 [10465] Fix bad bandate check. 2010-10-19 22:27:00 +02:00
NoFantasy
36a6e829b3 [10625] Implement SPELL_EFFECT_CLEAR_QUEST (139)
Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-10-19 12:56:24 +02:00
NoFantasy
4b83c5c88e [10624] Fix quests w/QuestFlags QUEST_FLAGS_AUTO_REWARDED
Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-10-19 11:58:23 +02:00
VladimirMangos
22bc9c80a1 [10623] Make .respawn work correctly with BG event spawns 2010-10-19 11:03:01 +04:00
VladimirMangos
2101b1ba0e [10622] Set respawn delay for BG creatures before set dead state.
This prevent save to DB wrong respawn time and unexpected in wrong event state spawn BG creatures.
2010-10-19 09:36:59 +04:00
NoFantasy
77b064e19a [10621] Add new field RequiredClasses for quest_template
* SkillOrClass is converted to RequiredSkill (and then field can contain skill id only)
* Field ZoneOrSort has no longer a function in quest requirement, and RequiredClasses must be used instead where class limits are expected.

To restrict a quest to one class or more, use bitmask of class in RequiredClasses. RequiredSkill works like before.

Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-10-19 00:33:16 +02:00
zerg
3c6d5e985f [10620] Fixed MSG_MOVE_HEARTBEAT structure.
Thx Wojta for pointing.

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-10-19 00:55:26 +04:00
VladimirMangos
811a86baf5 [10619] Clarify premade groups mode config option.
Also prevent mark group as premade with 0 time wait.
It's any way useless becase at next tick group moved to normal team mode.
2010-10-18 09:13:07 +04:00
VladimirMangos
099f375961 [10618] Properly update objects usable state at GM-mode on/off. 2010-10-18 05:59:47 +04:00
VladimirMangos
d3c1780f55 [10617] Fixed array access in SCRIPT_COMMAND_TALK loading check. 2010-10-18 04:56:27 +04:00
SilverIce
c4ddbead04 [10616] Simplified trade distance checks, GROUP_UPDATE_FLAG_POSITION flag handling moved out of Map
note: need avoid Map::PlayerRelocation calls now and use Player::SetPosition instead
2010-10-17 19:19:47 +03:00
NoFantasy
608815855f [10615] Add script effect of spell 66741
Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-10-17 12:37:19 +02:00
DasBlub
a3c03eb919 [10614] Replace ACE_ASSERT with MANGOS_ASSERT 2010-10-17 00:08:41 +02:00
DasBlub
57a88d2e3f [10613] A bit of cleanup in ByteBuffer::hexlike 2010-10-16 16:00:10 +02:00
DasBlub
fc5dd54f37 [10612] Revert "[10611] Made some values const"
Reason: It makes no sense to make a local variable const.

This reverts commit 49e3184d69056738701bc15d9b7f982bf11d7bbc.
2010-10-15 22:29:10 +02:00
Reve
47d971c7f9 [10611] Made some values const
Signed-off-by: DasBlub <dasblub@gmail.com>
2010-10-15 22:14:42 +02:00
DasBlub
61102e3b16 [10610] Renamed some functions from the Creature class
Also other classes have been affected, due to the use of search&replace.
This will probably break some patches and 3rd party libraries, so make sure to update them if required.
Thanks to Phille for the original idea and patch!
2010-10-14 22:07:04 +02:00
Lynx3d
d090bce461 [10609] I consider it proven that all classes shall benefit from intellect for weapon skill increase.
But better formula for chance would still welcome...
2010-10-14 15:50:05 +02:00
MrLama
699a22b2de [10608] Update melee miss chance calculations...finally.
Also thanks to Revils for correcting effective skill for spells that don't use weapon despite being melee/ranged ability.

Signed-off-by: Lynx3d <lynx3d@some-imaginary-isp.org>
2010-10-14 15:10:32 +02:00
Schmoozerd
c44438a517 [10607] Handle GAMEOBJECT_TYPE_GENERIC at Use() to trigger despawn of GO
In addition, a check is added to prevent unexpected call to Use() at received opcode. Despawn of this type GO can then only be used with explicit call to Use()

Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-10-14 14:44:57 +02:00
NoFantasy
df4563e653 [10606] Fix loot for victims being creature type critter
Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-10-14 09:41:14 +02:00
SilverIce
4c5c6c46a1 [10605] Fixed infinity loop at grid loading
this also probably solves the problem that object tries to be loaded twice
2010-10-13 22:39:07 +03:00
nos4r2zod
90e4480439 [10604] A couple more spell_proc_event entries for relics.
Missing items were 38360, 40714, 45509, 45144, 50454, 50455, 50456, 50457, 50458, 50459, 50460, 50461, 50462, 50464.

Signed-off-by: Lynx3d <lynx3d@some-imaginary-isp.org>
2010-10-13 11:43:19 +02:00
NoFantasy
edbe9ed886 [10603] Replace one hard coded value w/enum name. Additional code style cleanup
Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-10-13 09:41:44 +02:00
VladimirMangos
589c9d8a5d [10602] Add GO_DYNFLAG_LO_ACTIVATE to GAMEOBJECT_TYPE_GENERIC and merge similar cases. 2010-10-12 04:31:53 +04:00
VladimirMangos
0236699b0a [10601] Amother attemp fix locale structures corruption.
Possible real source of problem: existing in code mixed
std:: structure templates instanting under pack pragma and out.
And this incompatible structure layouts wrongly mixed used by GCC.

So all std:: strcutures used moved out from pack pragma guards.
2010-10-10 23:14:40 +04:00
NoFantasy
2fe45365c0 [10600] Correct size of animprogress for GO Create()
Add a default define and use it instead of hard coded value.
Some additional minor corrections for transport GO's

Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-10-10 13:27:25 +02:00
cyberbrest2
0205adfde1 [10599] Attempt fix data corruption for some localization structures with GCC use.
By unknown reason GCC generate wrong code for locale structures declared in header after pack pragma.

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-10-09 22:43:24 +04:00
NoFantasy
ba3578107a [10598] Create enum GameObjectDynamicLowFlags and use instead of hard coded
Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-10-09 19:20:29 +02:00
VladimirMangos
c4c9b5a726 [10597] Enable by default vmap.enableHeight and vmap.enableLOS
mangosd.conf version updated.
2010-10-09 03:00:56 +04:00
VladimirMangos
304bd3d7b6 [10596] Apply restrictions to vmap options.
After switch to new vmap version and later height check code chnages
some vmap related options now outdated.

* Option vmap.ignoreMapIds removed. You can't now diable vmaps use for selected maps.
* Option vmap.enableHeight must be always enabled for normal work server and server
  at startup now pring error if it's diabled. Option still supported just for special
  work cases (debug, new clients testing, etc).

Possible soon option vmap.ignoreSpellIds also will be removed, because like los ignore checks
must be in spell code instead options.
2010-10-09 02:53:53 +04:00
NoFantasy
926381824f [10595] Add new functions to Set/RemoveShortFlag (uint16, lo and high part of uint32)
Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-10-09 00:11:15 +02:00