Commit graph

3602 commits

Author SHA1 Message Date
NoFantasy
61990de6dd [10252] Implement reputation_reward_rate for quests and creatures
* In addition, implement "flat" reputation for quests, where a value in RewRepValueN is given. Human diplomacy will not affect the total. The rate however will be applied, where a faction is defined with a rate for quests. Value in database are expected to be *100 of the actual value given (before rate are applied).
* New database storage can contain rates for quest/creature/spell reputation and will affect the base value given as reward. When for example the quest reward for a faction should receive 30% more reputation points, the rate can be set to 1.3.
* This will fix issues with certain quests that are using the expected RewRepValueId but where the outcome has been lower than expected.
* Note that if the rate is set to 0.0 it will disable reputation gain for the faction and type.
* Reputation rate for spells (spell effect) is not yet implemented

Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-07-23 17:50:36 +02:00
VladimirMangos
50c2e8eca2 [10251] Clarify error message for one from redundent commamd data case. 2010-07-23 19:34:23 +04:00
VladimirMangos
9350c9990d [10250] Select auction store by house id only.
After this commit auction auctioneer guid used only for select auction house in packet or loading.
Next task replace it in DB by houseid, dependence DB data from creature guid isn't good.
2010-07-23 18:06:08 +04:00
Laise
02532a469a [10249] Don't interrupt area effects for channeled spells from target side 2010-07-23 09:22:05 +03:00
Lynx3d
33e7d46519 [10248] Implement applying proper penalty spell when making use of talent 46917. 2010-07-23 07:45:57 +02:00
VladimirMangos
5efb7410f2 [10247] Prevent lost items at problems with auction loading.
This will prevent adding to DD item data garbage not accessable from anywhere.
Now item will mailed back to owner.
2010-07-23 09:36:56 +04:00
VladimirMangos
9d8b66cf93 [10246] Restore work killCredit and kill achievements in regular difficulty instances. 2010-07-22 13:11:34 +04:00
fdb_
384915b0d0 [10245] Allow have custom starting area team/personal rating.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-07-22 10:29:59 +04:00
VladimirMangos
40ec688b2c [10244] Implement .stable gm command for open pet stable anywhere.
Maybe command not so useful for stable case because spell can be learned,
but it example how can be packet allowed depndent from player possibility
when some functionality base at many packets recieved from client.
Same way possible can be used for auction anywhere, maybe some other cases.

Also it will very usefull for 2.x/1.x branches where no another way... ;)
2010-07-22 08:49:15 +04:00
VladimirMangos
62e0e020a0 [10243] Traditional crash fix :/ 2010-07-22 07:35:14 +04:00
VladimirMangos
a121f7a3e5 [10242] Rewrite internal work chat command system.
* Use single command search function with recursion and reuse it in now more simple
  and consistent for execute/help/loading
* Add intergiry checks for hardcoded part of commands list. Fix some cases base at it.
* Fixed diff small problems in past code:
  - in console single symbol commands rejected (without dot start)
  - .help not output propertly subcommands list for not found subcommand
  - some other...
2010-07-22 06:51:16 +04:00
Laise
30a0701ca9 [10241] Fix expired spell interrupt 2010-07-21 13:01:59 +03:00
Laise
3e326311ad [10240] Fix some spells proc from spells that don't deal damage/heal 2010-07-21 08:16:23 +03:00
Lynx3d
4f0f701b63 [10239] Fix mangos.sql
I just had to forget one thing...
2010-07-21 03:33:30 +02:00
Lynx3d
c5038d2b95 [10238] Set flag for offhand melee spells to allow proper triggering of weapon-specific effects. 2010-07-21 03:22:40 +02:00
Lynx3d
a4a6a7a609 [10237] Implement additional damage proc on hit for Spell 8024 and ranks. 2010-07-21 03:19:52 +02:00
Ceris
d7b6840634 [10236] Implement SPELL_AURA_OPEN_STABLE (292).
(based on Wowka321's repo commit 213ceb0)

Signed-off-by: VladimirMangos <vladimir@getmangos.com>

Rewrited partly.
2010-07-21 04:59:04 +04:00
VladimirMangos
e7093e3ebb [10235] Cleanup in pet stable handlers 2010-07-21 04:03:40 +04:00
tehmarto
631a6a5e59 [10234] Fix typo in IsNoStackAuraDueToAura() Signed-off-by: Lynx3d <lynx3d@some-imaginary-isp.org> 2010-07-20 22:32:48 +02:00
pasdVn
d59cd7c2f2 [10233] Fixed check in SpellAuraHolder::HasMechanicMask
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-07-20 15:05:47 +04:00
Laise
d8c1374fcd [10232] Fix mechanic-related check, thanks to VladimirMangos 2010-07-20 13:20:35 +03:00
VladimirMangos
0065693c4c [10231] Use VMAP::VMAPLoadResult instead raw int loadMap result. 2010-07-20 01:27:07 +04:00
VladimirMangos
06bcc77495 [10230] Avoid use enum valuse/define like naming style for enum type name. 2010-07-20 01:18:13 +04:00
VladimirMangos
9381e8680c [10229] Small cleanup in taxi related checks 2010-07-20 00:42:58 +04:00
Timawyn
6b0746b49b [10228] Missing send packet in empty vendor item list case.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-07-19 23:38:22 +04:00
VladimirMangos
e8f18b1606 [10227] Generate gameobject loot only at open spawned gameobject. 2010-07-19 12:19:44 +04:00
Lutik
c4c21d3fb6 [10226] Fixed GO_JUST_DEACTIVATED for despawned by default gameobject.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-07-19 11:43:55 +04:00
a1ien
e9e7aff5bb [10225] Propertly show empty vendor list for empty item list.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-07-19 11:13:14 +04:00
VladimirMangos
6192bdbe1b [10224] Small code style cleanup. 2010-07-19 08:21:17 +04:00
VladimirMangos
093db9c033 [10223] Implement spell 44572 affect to permament stun immuned targets.
This also fix unexpected triggering effect any unrelated spell casts.
2010-07-19 06:53:01 +04:00
VladimirMangos
0e2a80477a [10222] Restore proc events at full miss/immune spells to target. 2010-07-19 06:50:01 +04:00
SilverIce
1377db20a7 [10221] Fixed visual bug that some deleted auras still show at client side
(based on commit b10058e)

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-07-19 00:11:39 +04:00
VladimirMangos
98ae9efbc6 [10220] Fixed typos in mangos.sql
* Typos in `1playercreateinfo_*` tables. Thanks to Astoria.
* Lost recent field rename in `item_template`. Thanks to bobi88.
2010-07-18 22:54:58 +04:00
Laise
5a1a40719c [10219] Fix spell 36032 stacking and procs 2010-07-18 20:02:13 +03:00
Laise
c384650af8 [10218] Restore trinket procs when no specific spell is defined for proc 2010-07-18 18:53:46 +03:00
crackm
7bb8b2bedb [10217] Update playercreateinfo_action/playercreateinfo_spell
* Drop some food action buttons
* Drop attack spells for caster classes
* Use expected simlifed spell version 20154 (it replaced by full version at learn spell 53408 and similar)
  In code used helper code for support 2 versions as fake non-stacking ranks.
* Some other old "max ranks" of talents and spells now are permanent bonuses known from start (only "max rank" for spell exist)

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-07-18 12:26:12 +04:00
VladimirMangos
238b57f93e [10216] Re-implement ROLL_VOTE_DISENCHANT disable case
Also implement NEED_BEFORE_GREED disabling ROLL_VOTE_MASK_NEED
instead skip item as expected in recent client changes.

Thanks to TOM_RUS for help in understanding proper way work.
Hmm, maybe i still do wrong something... ^^

Also count disenchnt roll as greed in ACHIEVEMENT_CRITERIA_TYPE_ROLL_GREED
2010-07-18 05:40:34 +04:00
VladimirMangos
4ef23face4 [10215] Implement ROLL_VOTE_DISENCHANT disable
* for player without reqired enchanting skill
* for item without disenchanting possibility
2010-07-18 02:04:06 +04:00
VladimirMangos
15374bd626 [10214] Small final (as i think ;) ) fixes for restricted flight zone
* Fixed my horriable typo in 58600 effect code. Thanks to zergtmn for pointing to it.
* Remove redundent cast 45472 in 58600 effect code (it casted from 58601 already). Thanks to porteyoplait.
* Prevent restart 58600 debuf timer at temporary leave zone and return to it.
2010-07-18 01:13:48 +04:00
VladimirMangos
73a00a6807 [10213] Implement ITEM_FLAGS2_NEED_ROLL_DISABLED. 2010-07-17 23:45:56 +04:00
zergtmn
5c6fbdb54e [10212] Fix iterator update in Unit::RemoveNotOwnSingleTargetAuras
Signed-off-by: Laise <fenrisse@gmail.com>
2010-07-17 21:36:53 +03:00
Laise
f37c73e255 [10211] Fix aura procs for spells with auras that can't trigger 2010-07-17 21:32:05 +03:00
VladimirMangos
63ea8bbf4b [10210] Do unmount at expire restricted flight zone debuf if still in restricted zone/etc. 2010-07-17 21:42:09 +04:00
VladimirMangos
d6a3347245 [10209] Output leaned before disabled ranks at talent re-learn or spec swith in proper order. 2010-07-17 20:44:39 +04:00
crackm
624b45f333 [10208] Add proper data for character orientation at creating.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-07-17 20:04:38 +04:00
VladimirMangos
20a5551739 [10207] Implement ITEM_FLAGS2_EXT_COST_REQUIRES_GOLD use instead sign of ExtendedCost field. 2010-07-17 19:23:38 +04:00
VladimirMangos
9882bc811f [10206] Implement ITEM_FLAGS2_HORDE_ONLY and ITEM_FLAGS2_ALLIANCE_ONLY
* Check item_template data
* Check at equip/use
* Skip at loot if not compatible
* Skip in vendor list if not compatible
2010-07-17 08:21:23 +04:00
Lynx3d
f2e3881a77 [10205] Correctly implement flying mount restrictions in zone 4395 by use of special area flag.
Also drop existing spell_area entries if exist, workaround not needed anymore.
2010-07-17 05:53:17 +02:00
XTZGZoReX
3ed6542c1d [10204] Add one more known value for item flags2. 2010-07-17 03:00:39 +02:00
VladimirMangos
4e16982d18 [10203] Rename item_template.Faction to Flags2 and define some values for it.
Thanks to Shauren for research flag ITEM_FLAGS2_COST_REQUIRES_GOLD meaning
and inspiring in general what must be done long time ago with field rename
and other enum values listing.
2010-07-17 04:51:25 +04:00