Commit graph

59 commits

Author SHA1 Message Date
XTZGZoReX
1f23884757 Don't use singleton to access static functions.
* This affects especially ObjectMgr functions:
   - GetCreatureInfo
   - GetGameObjectInfo
   - GetInstanceTemplate
   These are in fact static functions.
2009-11-08 03:54:27 +01:00
SilverIce
023b13f348 [8627] Avoid not needed too oftent send update data, cleanups.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-10-11 19:31:57 +04:00
VladimirMangos
59befa2e0e Merge branch 'master' into 320 2009-10-02 19:09:06 +04:00
VladimirMangos
30105b8a0d [8577] Remove redundent #include "ObjectAccessor.h" 2009-10-01 19:30:30 +04:00
VladimirMangos
47bf1dbce6 [8571] Avoid use ^ bitmask operation for bool values compare in general.
Also drop HandleSet32Bit logn unused and wrong coded chat command code.
2009-09-30 19:39:44 +04:00
tomrus88
2d86aa4535 Misc fixes. 2009-09-14 18:11:15 +04:00
tomrus88
9c8a0d615e Merge commit 'origin/master' into 320
Conflicts:
	src/game/WorldSession.cpp
2009-08-30 15:52:20 +04:00
Fog
016dc29e5d [8438] Correctly update achievement at bank bag slot buy instead next login.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-08-29 23:31:56 +04:00
tomrus88
fec1a1954c Merge commit 'origin/master' into 320
Conflicts:
	src/game/MovementHandler.cpp
2009-08-20 16:24:37 +04:00
VladimirMangos
35121cdd34 [8389] Implement check really read received packet size and warning it not all data read.
* This let more easy catch packet structure chnages at client switch.
* Fixed structure CMSG_GUILD_BANK_SWAP_ITEMS
* Fixed structure CMSG_SPLIT_ITEM, CMSG_SELL_ITEM
* Added read data amount fixes for some other packets.

Thanks to TOM_RUS in help check correct packets structure.

Note: not all packets possible fixed. Please report for not fixed cases at errors:
"opcode %s (0x%.4X) have unprocessed tail data (read stop at %u from %u)"
2009-08-19 00:45:24 +04:00
tomrus88
f553cf2887 Merge commit 'origin/master' into 320
Conflicts:
	src/game/CharacterHandler.cpp
	src/game/DuelHandler.cpp
	src/game/ItemHandler.cpp
	src/game/Mail.cpp
	src/game/MiscHandler.cpp
	src/game/MovementHandler.cpp
	src/game/TaxiHandler.cpp
	src/game/WorldSession.h
	src/game/WorldSocket.cpp
2009-08-17 10:31:02 +04:00
arrai
a24f39a36f [8378] Use exceptions instead of explicit size checking for each packet
CHECK_PACKET_SIZE was pretty error prone; once it was forgotten mangosd
could crash due to the asserts in ByteBuffer.h. That was exploitable by
malicious players.
Furthermore, there were duplicate checks: Additionally to
CHECK_PACKET_SIZE, the ByteBuffer assertions keept an eye
on not exceeding the packet boundaries - just to crash the server for
sure in such a case.
To prevent memory leaks or other undesirable states, please read in
every handler all variables _before_ doing any concrete handling.
2009-08-16 23:50:22 +02:00
tomrus88
1df1f7cff5 Fixed player movement.
Fixed multinode taxi.
Removed some unhandled opcode spam.
2009-08-09 18:08:14 +04:00
tomrus88
299f40ac0c Merge commit 'origin/master' into 320 2009-07-26 10:52:21 +04:00
VladimirMangos
bd1ea72043 [8244] Skip cheating check for buy bank slot opcode.
This is not big problem in any case and will allow buy slots
in bank windows open using .bank command.
2009-07-25 06:47:05 +04:00
tomrus88
a26e90019b /played command should work once again. 2009-07-22 01:25:15 +04:00
tomrus88
3de88aef12 Updated to 10116 client build. 2009-07-17 17:01:47 +04:00
tomrus88
87930a6d07 Merge commit 'origin/master' into 320 2009-07-08 22:08:09 +04:00
VladimirMangos
b4302d61e5 [8121] Cleanup and more safe code in Player::BuyItemFromVendor use.
* Move bag search by bag guid code to WorldSession::HandleBuyItemInSlotOpcode
* Really reject unexisted bag cases.
2009-07-05 17:45:45 +04:00
tomrus88
02bcc56919 Added placeholders for new battlegrounds, some other stuff. 2009-06-25 19:08:53 +04:00
nos4r2zod
8db10be934 [8048] Fixed typo in HandleBuyItemInSlotOpcode.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-06-20 01:48:46 +02:00
tomrus88
4236f7c75c Merge branch 'master' into 310 2009-06-05 14:54:05 +04:00
VladimirMangos
0b3a4bf5a5 [7950] Make clear in error output 2 cases of fail CMSG_ITEM_NAME_QUERY: DB absent data and not expected to exist item. 2009-06-04 04:18:53 +04:00
tomrus88
a57bf5a78b Applied coding style. 2009-05-29 19:23:28 +04:00
tomrus88
42f8ce5f3e [7911] Applied coding style. 2009-05-29 19:07:28 +04:00
tomrus88
ec4928008c Some coding style fixes. 2009-05-26 14:41:57 +04:00
tomrus88
afd82229d7 Merge commit 'origin/master' into 310
Conflicts:
	src/game/SpellAuras.cpp
	src/game/SpellEffects.cpp
2009-05-24 10:11:26 +04:00
VladimirMangos
3d1b055e9e Fixed bank bag slot amount achievement statistic. Cleanup related code. 2009-05-23 18:50:46 +04:00
tomrus88
5e26a2a152 Just a few renames. 2009-05-09 16:01:31 +04:00
tomrus88
950a4bf13f Merge commit 'origin/master' into 310
Conflicts:
	src/game/Player.cpp
2009-04-28 19:08:53 +04:00
AlexDereka
c9d51a6dc7 [7716] Fixed some typos and possible crashes. 2009-04-26 18:49:07 +04:00
tomrus88
a9e148edac Merge commit 'origin/master' into 310
Conflicts:
	src/game/AchievementMgr.cpp
	src/game/BattleGroundHandler.cpp
	src/game/CreatureEventAIMgr.cpp
	src/game/DBCStructure.h
	src/game/Player.cpp
	src/game/Spell.cpp
	src/shared/revision_nr.h
2009-04-21 15:20:45 +04:00
VladimirMangos
f4adf83cd7 [7688] Move Get*IfCanInteractWith to Player including renamed IsGameObjectOfTypeInRange. 2009-04-19 22:54:40 +04:00
tomrus88
2fc6e75a81 Fixed item buy packets. Thanks to yad02 for reporting.
Fixed client disconnect when boarding transport (by yad02 and woweur).
2009-04-19 11:03:20 +04:00
tomrus88
d6f6272f8c Merge branch 'master' into 310 2009-04-14 15:54:43 +04:00
arrai
a0ef77af5b [7659] Added several security checks to prevent cheating using facked packets 2009-04-13 02:16:01 +02:00
tomrus88
31b3ee95ad Merge branch 'master' into 310
Conflicts:
	src/game/Level2.cpp
	src/game/PetHandler.cpp
	src/game/Player.cpp
	src/game/Player.h
	src/game/SkillHandler.cpp
2009-03-11 12:22:58 +03:00
balrok
6c39db38f4 removed unneeded World.h includes
this is done by this script:
ack -c "World.h" | ack :1 | sed 's/:1//' | xargs grep -c sWorld | grep :0 | sed 's/:0//' | xargs sed -i '/#include "World.h"/d'
i didn't checked every change but gcc haven't complained
2009-03-08 01:26:52 +03:00
VladimirMangos
ce8bd43bef Merge commit 'origin/master' into 310 (at [7360]) 2009-03-01 01:18:20 +03:00
VladimirMangos
b9326100ea [7360] Use defines instead harcoded item prototype array sizes. 2009-03-01 00:32:37 +03:00
tomrus88
ffca6c8c57 Fixed some opcodes 2009-02-27 19:25:11 +03:00
VladimirMangos
9b3daf3933 [7330] Code warnings and style cleanups. Some bugs fixes.
1) comparison singed and unsigned values
2) redundent includes
3) wrong constructor :-part field initilization
4) unused not-/*name*/-guarded args in template/virtual functions that not required like args.
5) explicitly list not implemented achievement types.

Also bugs fixed:
1) Drop wrong phase mask 0 check in WorldObject::InSamePhase.
2) ArenaTeamMember::ModifyPersonalRating incorrect work with move points in negative with infinity values in result.
3) ArenaTeam::SaveToDB code send uint64 value to string with arg format %u.
2009-02-24 01:54:53 +03:00
VladimirMangos
b052777f71 Implemented limit category check for item/gem at equip or gem inserting. 2009-02-14 12:17:04 +03:00
freghar
f04ec2b98b [7272] Trailing whitespace cleaning
The "please use git diff --check before commit" thing.

Signed-off-by: freghar <compmancz@gmail.com>
2009-02-12 15:14:40 +01:00
zhenya
c5f20ff9a9 [7248] Check battlemaster_entry data at loading. Code cleanups.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-02-08 04:22:46 +03:00
VladimirMangos
fdd8176d74 [7227] Implement prismatic sockets. Related code cleanups.
Big thanks to TOM_RUS for help in reseach!
2009-02-04 02:09:46 +03:00
VladimirMangos
ed14e59de4 Fixed typo in log output and misc code cleanups. 2009-01-16 18:11:58 +03:00
VladimirMangos
c0824b35c6 Fix item Unk0 field type as expected signed and related log output.
Also restore item class check at server loading but not subclass check. Problems only with subclass check case.
2009-01-15 03:08:25 +03:00
VladimirMangos
c7a5537bac [7087] Use signed type as expected for item material field. This also fix -1 value output for it.
Also disable Class/Subclass item_template check by dbc data for avoid unexpected log spam (dbc have some wrong values for this fields).
2009-01-15 00:12:48 +03:00
arrai
c6f48843ad [7017] Updated copyright notice for new year 2009-01-03 18:09:51 +01:00