Commit graph

5770 commits

Author SHA1 Message Date
Ambal
40ef9cbf2f [11284] Implement prepared statements for INSERT+DELETE+UPDATE SQL requests. Should improve player save performance + lower MySQL server CPU usage.
Note: PostgreSQL does not have prepared statements implemented using native APIs.

Huge thanks to Undergarun, kero99 and Vinolentus.

Signed-off-by: Ambal <pogrebniak@gala.net>
2011-03-25 22:17:59 +02:00
DasBlub
d9374d936f [11283] Drop the no longer used Visual Leak Detector (VLD)
For leak detection you can also use tools like Valgrind.

If you really want to use VLD you can revert this commit and remove the comments in MemoryLeaks.cpp and MemoryLeaks.h.
The VLD version which has been shipped with MaNGOS is *heavily* outdated and I thus suggest you to use a newer version of it, if you really plan to use it. You can find the newest version on github in its official repository: https://github.com/dmoulding/vld
2011-03-25 19:04:39 +01:00
zergtmn
0bc4bc1d75 [11282] Use uint32 datatype for aura charges and stacks
* Some spells have StackAmount > 255, for example 22735, 54314
* In SMSG_AURA_UPDATE maximum stack amount is limited by 255
* Move duplicate code into SpellAuraHolder::BuildUpdatePacket function
* Cleanup some weird type casts in _LoadAuras
2011-03-25 14:40:09 +05:00
VladimirMangos
77e612cbf7 [11281] Code cleanup in Player::CastItemCombatSpell 2011-03-25 10:47:13 +03:00
zergtmn
098a561529 [11280] Drop obsolete code
Debuff from talent 22959 is no longer stackable after 3.3.
2011-03-24 22:15:43 +05:00
NoFantasy
681159656b [11279] Remove aura 53031 at 53039 aura removal.
Signed-off-by: NoFantasy <nofantasy@nf.no>
2011-03-24 08:28:12 +01:00
VladimirMangos
0751a35342 [11278] Fixed auras stack size check at loading.
For non stacking auras preserve stack size 1 as auras created instead reset it to 0 at mnext load.
For client no difference in show and most non stacking auras not dependent from stack size value
at server side code, but any way set stack size to 0 can generate unexpected wrong caluclation results
in spell code.
2011-03-23 05:37:38 +03:00
NoFantasy
96183f8e3f [11277] Add dummy effect of spell 48046
Signed-off-by: NoFantasy <nofantasy@nf.no>
2011-03-22 12:32:15 +01:00
VladimirMangos
678cfcea78 [11276] In dest. point slection must used in world casting object (not owner of cast affects) 2011-03-22 03:25:39 +03:00
Schmoozerd
cb1bb261ea [11275] Add missing script call JustSummoned for guardian and critter pet
Signed-off-by: NoFantasy <nofantasy@nf.no>
2011-03-21 23:57:08 +01:00
Schmoozerd
281bf03b12 [11274] Updated some more copyrights which were outdated
Signed-off-by: DasBlub <DasBlub@gmail.com>
2011-03-21 23:49:36 +01:00
DaC
98377df5f4 [11273] Fix the ".gm setview" command
Signed-off-by: DasBlub <DasBlub@gmail.com>
2011-03-21 23:40:31 +01:00
faramir118
87cd258d8b [11272] Update previously commit copyright notices. We are in 2011, not in 2010
Signed-off-by: DasBlub <DasBlub@gmail.com>
2011-03-21 23:11:06 +01:00
DasBlub
66e6fcf5a1 [11271] Add missing copyright to some files in contrib/ 2011-03-21 22:46:01 +01:00
NoFantasy
5fc4a839e3 [11270] Let GM (.gm on) always see gossip options regardless of conditions set.
Signed-off-by: NoFantasy <nofantasy@nf.no>
2011-03-21 10:13:49 +01:00
VladimirMangos
92a1e9b4d0 [11269] Apply to lootPlayerNonQuestNonFFAConditionalItems same loot rules as to notmal shared loot.
Also some code refactoring.
2011-03-21 04:26:28 +03:00
TheLuda
3edc98c4aa * Mark the functions deterministic to avoid issues with MySQL binary logging. 2011-03-20 14:39:39 -07:00
NoFantasy
5b9c2bf336 [11268] Add dummy effect of spell 43014
Signed-off-by: NoFantasy <nofantasy@nf.no>
2011-03-20 18:41:47 +01:00
VladimirMangos
b442332403 [11267] Restore itemset 647 4p bonus affect work. 2011-03-20 07:16:25 +03:00
VladimirMangos
52c6d0ef24 [11266] Fixed work glyph 41108 (typo in spell id) 2011-03-20 05:12:27 +03:00
NoFantasy
0432802379 [11265] Properly take reagents for triggered spell of 44364 (ref previous commit)
Signed-off-by: NoFantasy <nofantasy@nf.no>
2011-03-19 11:43:51 +01:00
NoFantasy
f1fb9afa43 [11264] Add script effect of spell 44364
Signed-off-by: NoFantasy <nofantasy@nf.no>
2011-03-19 11:16:03 +01:00
VladimirMangos
3c9f268b53 [11263] Revert "[11262] Revert "[11261] Check gaps in quest RewChoiceItem* data.""
This reverts commit 714d48a99e2ccc9404b34ebcfec50b2d8300fc46.

Additiona reserch show that no any know cases when data in RewChoiceItem* have gaps
except detected wrong data cases. So check good have in 3.x/2.x for better data intergrity checks.
2011-03-18 18:57:26 +03:00
VladimirMangos
24545a6162 [11262] Revert "[11261] Check gaps in quest RewChoiceItem* data."
This reverts commit a2d5f153c2d0256ad943a48442535730894e5d5e.

Only 1.x client have this problem.
2011-03-18 01:42:40 +03:00
VladimirMangos
5fce047e69 [11261] Check gaps in quest RewChoiceItem* data.
Client can crash if data not continues.

Thanks Chero and Joey for help in research problem ^^
2011-03-17 21:47:29 +03:00
zergtmn
df89544baa [11261] Get rid of two const_casts by storing const char* instead of char* 2011-03-17 12:17:31 +05:00
VladimirMangos
b588ea9db3 [11260] Add wrapper for creature vistual item set. 2011-03-16 20:21:45 +03:00
zergtmn
a6d155fc54 [11259] Move scheduled scripts counter to ScriptMgr
Also cleanup forward declarations.
2011-03-16 20:01:10 +05:00
Vinolentus
dee6d712c4 [11258] Typo in ObjectMgr::LoadItemConverts()
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2011-03-16 16:50:24 +03:00
Hundekuchen
f1a880a4ed [11257] Fix overwrite spells 33649 and 20572, other cases with same icon.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2011-03-16 03:36:57 +03:00
Vinolentus
06d319e5f8 [11256] Restore broken in [7207] Creature::SaveToDB overwriting.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2011-03-16 03:26:49 +03:00
VladimirMangos
a7405fd673 [11255] Fixed receive BoA item from deleted character by mail. 2011-03-16 03:01:42 +03:00
VladimirMangos
7196d81679 [11254] Really load item text at login.
This fix problem when item with text created but not read before
logout after logout not show text. In most cases this is mail text
copied to inventry. Client cache text in WDB so if open before
logout then item "show" text. If you have items created before
this fix with like problem you need clear WDB cache for fix text
show for item.
2011-03-16 02:15:35 +03:00
VladimirMangos
d8b71eade1 [11253] Drop unused define GAMEOBJECT_FISHINGNODE_ENTRY 2011-03-15 23:49:22 +03:00
VladimirMangos
acc12cc9ed [11252] One missing case for save non-static spawned creatures. 2011-03-15 21:50:19 +03:00
NoFantasy
7b070a93aa [11251] Add some base code for GAMEOBJECT_TYPE_CAPTURE_POINT
Note that code is only a tiny start to implement these gameobjects, and are most likely wrong in itself as conditions for calling events does not exist yet.
To be used in further development.

Signed-off-by: NoFantasy <nofantasy@nf.no>
2011-03-15 11:14:05 +01:00
NoFantasy
167ec0df42 [11250] Fix create position for summoned creatures.
Signed-off-by: NoFantasy <nofantasy@nf.no>
2011-03-15 09:43:32 +01:00
VladimirMangos
789f513ede [11249] Lost summon point set for critter 2011-03-15 04:18:10 +03:00
Vinolentus
a6bab82c72 [11248] Clarify and check DBC/SQL storage format field types.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2011-03-15 02:55:10 +03:00
VladimirMangos
189e7c08b7 [11247] Prevent attemps save npc data without static spawns
Original patch provided by Vinolentus.
2011-03-15 01:02:20 +03:00
VladimirMangos
52b0748282 [11246] Provide mail template items for offline players
Implemented generation mail template items at mails loading in case when
original mail send in time when receiver has been offline. Before like
receiver not receive items.

Small change in mail.has_items meaning. Now it set also in cases when items
generated for template but none items really added to mail. This not affect
mostly existed code work aceept case when mail with template loading.
2011-03-14 23:20:37 +03:00
NoFantasy
13776fa1e4 [11245] Clarify and provide more details for errors related to table spell_script_target
Signed-off-by: NoFantasy <nofantasy@nf.no>
2011-03-14 10:15:47 +01:00
VladimirMangos
2b65cdb3bb [11244] Collect in CreatureCreatePos data for delayed pos setup into Creature::Create.
* CreatureCreatePos work in 3 modes:
    - exactly provided coordinates/orientation/map/phasemask
    - exactly object + orientation as coordinates/map/phasemask
    - delayed position calculation near provided object at specific dist/angle.
* Use in similar way and for Pet/Vehicle Create functions.
  For Totem created new Totem::Create function with some moved in to it totem specific code.
* This let resolve recent problems with creature spawn and preserve fix for cases when
  Creature::Create addon/script code expected known correct possition for creature.
2011-03-14 06:18:34 +03:00
NoFantasy
44915f6f13 [11243] Allow riding training from other team factions when exalted
Signed-off-by: NoFantasy <nofantasy@nf.no>
2011-03-14 00:01:35 +01:00
DasBlub
a19c308001 [11242] Fix line endings for Visual Studio Solution Files (they need to be CRLF, not LF) 2011-03-12 20:03:22 +01:00
DasBlub
93da372dc5 [11241] Fix some renglish/denglish -> english in config files
For the "MaNGOS-Feeling" (c) I left most of the renglish and typos in there, so you will still be able to recognize it as a MaNGOS file ;)
2011-03-11 23:24:25 +01:00
DasBlub
98a5eb6f0e [11240] Drop dead code from vmap extractor 2011-03-10 22:01:51 +01:00
NoFantasy
99b8c8b34f [11239] Comment out crap added in [11237] and bonk the author for creating it.
Signed-off-by: NoFantasy <nofantasy@nf.no>
2011-03-10 20:06:51 +01:00
NoFantasy
0ca45c76dc [11238] Add IsActive check in PointMovementGenerator, as with similar waypointmovement
Signed-off-by: NoFantasy <nofantasy@nf.no>
2011-03-10 19:54:08 +01:00
NoFantasy
fcb4eca715 [11237] Implement conditional check in EffectQuestComplete
A few spells has basepoint value, conditional for successful effect.

Signed-off-by: NoFantasy <nofantasy@nf.no>
2011-03-10 17:13:55 +01:00