Commit graph

5790 commits

Author SHA1 Message Date
zergtmn
4d262b593d [11301] Implement SPELL_EFFECT_CANCEL_AURA 2011-03-31 13:24:27 +06:00
rsa
d2d3c22b77 [11300] Fix compile in GCC 2011-03-31 01:24:15 +06:00
zergtmn
4687fa8cb4 [11299] Handle aura durations in SpellAuraHolder
- Unit::CalculateSpellDuration split into two functions
    - CalculateSpellDuration taking into account combo points and caster-side spell mods
    - Unit::CalculateAuraDuration taking into account target-side spell mods
- Diminishing is now applied before duration reduction mods
- Implement saving per-effect periodic timers to DB (required for auras affected by haste)
2011-03-30 23:29:01 +06:00
Ambal
5833d74963 [11298] NearUsedPosDo searcher should add only units with correct coordinates. Possibly can help with freezes when 'DetectPosCollision = 1'.
Signed-off-by: Ambal <pogrebniak@gala.net>
2011-03-30 09:35:02 +03:00
VladimirMangos
c6794ce48b [11297] Comment fix 2011-03-28 13:55:22 +04:00
NoFantasy
d79d348af1 [11296] Load and check GAMEOBJECT_TYPE_CAPTURE_POINT event id's
Signed-off-by: NoFantasy <nofantasy@nf.no>
2011-03-28 09:25:25 +02:00
VladimirMangos
2aef552668 [11295] Load achievment system state before laoding other character data.
This prevent lost detected achievement criteria update or have unexpected criteria update event
at character data loading like skills/spells/itemts/etc.

Achievment system state load by self not dependent from other character data (checked after
all data loading in CheckAllAchievementCriteria() call.
2011-03-28 00:55:44 +04:00
crackm
cc24542aec [11294] corspe -> corpse typos fix.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2011-03-27 23:45:50 +04:00
zergtmn
ee5b59b7e0 [11293] Cleanups in spell target lists 2011-03-28 01:14:36 +06:00
zergtmn
37fd225a89 [11292] Strip trailing whitespace after [11284] 2011-03-27 23:40:42 +06:00
Bobi88
443b5c776c [11291] And just when we thought that we'd have updated all copyrights in all files...
Signed-off-by: DasBlub <DasBlub@gmail.com>
2011-03-27 16:45:53 +02:00
TOM_RUS
d1f03cec61 Edited src/game/CalendarHandler.cpp via GitHub 2011-03-26 07:02:39 -07:00
TOM_RUS
9996150a8e Edited src/game/DBCStructure.h via GitHub 2011-03-26 06:50:58 -07:00
NoFantasy
23af82081b [11290] Add dummy aura effect of spell 62109
Also add a smaller hack to have access to m_caster later (see code comments)

Signed-off-by: NoFantasy <nofantasy@nf.no>
2011-03-26 10:53:40 +01:00
NoFantasy
40d87bfabf [11289] Partially revert [11287] and try to do it properly this time.
Signed-off-by: NoFantasy <nofantasy@nf.no>
2011-03-26 08:05:07 +01:00
VladimirMangos
989d229968 [11288] Check IsPositiveEffect in IsPositiveSpell only for existed effects.
Thanks to NoFantasy for problem research.

Also make IsPositiveEffect use SpellEntry* arg instead spell id.
2011-03-26 03:10:26 +03:00
NoFantasy
dae28ae93a [11287] Add dummy effect of spell 62105 and dummy aura effect of 62248
Note: spell 62105 are still considered to be negative, despite explicit exception added in IsPositiveEffect and will unexpectedly put caster in combat.

Signed-off-by: NoFantasy <nofantasy@nf.no>
2011-03-26 00:16:09 +01:00
TOM_RUS
7645b98a49 Edited DBCStructure.h via github. 2011-03-25 14:40:30 -07:00
faramir118
6c7cfa95e2 [11286] Use .gitattributes file in order to set the Visual Studio Files to CRLF line endings.
Signed-off-by: DasBlub <DasBlub@gmail.com>
2011-03-25 21:53:48 +01:00
DasBlub
96512037a9 [11285] Revert "[11242] Fix line endings for Visual Studio Solution Files (they need to be CRLF, not LF)"
This reverts commit 10e5bdfbb130c6a70d0b28a9f69d9c99e6ea3f20.
2011-03-25 21:51:39 +01:00
Ambal
40ef9cbf2f [11284] Implement prepared statements for INSERT+DELETE+UPDATE SQL requests. Should improve player save performance + lower MySQL server CPU usage.
Note: PostgreSQL does not have prepared statements implemented using native APIs.

Huge thanks to Undergarun, kero99 and Vinolentus.

Signed-off-by: Ambal <pogrebniak@gala.net>
2011-03-25 22:17:59 +02:00
DasBlub
d9374d936f [11283] Drop the no longer used Visual Leak Detector (VLD)
For leak detection you can also use tools like Valgrind.

If you really want to use VLD you can revert this commit and remove the comments in MemoryLeaks.cpp and MemoryLeaks.h.
The VLD version which has been shipped with MaNGOS is *heavily* outdated and I thus suggest you to use a newer version of it, if you really plan to use it. You can find the newest version on github in its official repository: https://github.com/dmoulding/vld
2011-03-25 19:04:39 +01:00
zergtmn
0bc4bc1d75 [11282] Use uint32 datatype for aura charges and stacks
* Some spells have StackAmount > 255, for example 22735, 54314
* In SMSG_AURA_UPDATE maximum stack amount is limited by 255
* Move duplicate code into SpellAuraHolder::BuildUpdatePacket function
* Cleanup some weird type casts in _LoadAuras
2011-03-25 14:40:09 +05:00
VladimirMangos
77e612cbf7 [11281] Code cleanup in Player::CastItemCombatSpell 2011-03-25 10:47:13 +03:00
zergtmn
098a561529 [11280] Drop obsolete code
Debuff from talent 22959 is no longer stackable after 3.3.
2011-03-24 22:15:43 +05:00
NoFantasy
681159656b [11279] Remove aura 53031 at 53039 aura removal.
Signed-off-by: NoFantasy <nofantasy@nf.no>
2011-03-24 08:28:12 +01:00
VladimirMangos
0751a35342 [11278] Fixed auras stack size check at loading.
For non stacking auras preserve stack size 1 as auras created instead reset it to 0 at mnext load.
For client no difference in show and most non stacking auras not dependent from stack size value
at server side code, but any way set stack size to 0 can generate unexpected wrong caluclation results
in spell code.
2011-03-23 05:37:38 +03:00
NoFantasy
96183f8e3f [11277] Add dummy effect of spell 48046
Signed-off-by: NoFantasy <nofantasy@nf.no>
2011-03-22 12:32:15 +01:00
VladimirMangos
678cfcea78 [11276] In dest. point slection must used in world casting object (not owner of cast affects) 2011-03-22 03:25:39 +03:00
Schmoozerd
cb1bb261ea [11275] Add missing script call JustSummoned for guardian and critter pet
Signed-off-by: NoFantasy <nofantasy@nf.no>
2011-03-21 23:57:08 +01:00
Schmoozerd
281bf03b12 [11274] Updated some more copyrights which were outdated
Signed-off-by: DasBlub <DasBlub@gmail.com>
2011-03-21 23:49:36 +01:00
DaC
98377df5f4 [11273] Fix the ".gm setview" command
Signed-off-by: DasBlub <DasBlub@gmail.com>
2011-03-21 23:40:31 +01:00
faramir118
87cd258d8b [11272] Update previously commit copyright notices. We are in 2011, not in 2010
Signed-off-by: DasBlub <DasBlub@gmail.com>
2011-03-21 23:11:06 +01:00
DasBlub
66e6fcf5a1 [11271] Add missing copyright to some files in contrib/ 2011-03-21 22:46:01 +01:00
NoFantasy
5fc4a839e3 [11270] Let GM (.gm on) always see gossip options regardless of conditions set.
Signed-off-by: NoFantasy <nofantasy@nf.no>
2011-03-21 10:13:49 +01:00
VladimirMangos
92a1e9b4d0 [11269] Apply to lootPlayerNonQuestNonFFAConditionalItems same loot rules as to notmal shared loot.
Also some code refactoring.
2011-03-21 04:26:28 +03:00
TheLuda
3edc98c4aa * Mark the functions deterministic to avoid issues with MySQL binary logging. 2011-03-20 14:39:39 -07:00
NoFantasy
5b9c2bf336 [11268] Add dummy effect of spell 43014
Signed-off-by: NoFantasy <nofantasy@nf.no>
2011-03-20 18:41:47 +01:00
VladimirMangos
b442332403 [11267] Restore itemset 647 4p bonus affect work. 2011-03-20 07:16:25 +03:00
VladimirMangos
52c6d0ef24 [11266] Fixed work glyph 41108 (typo in spell id) 2011-03-20 05:12:27 +03:00
NoFantasy
0432802379 [11265] Properly take reagents for triggered spell of 44364 (ref previous commit)
Signed-off-by: NoFantasy <nofantasy@nf.no>
2011-03-19 11:43:51 +01:00
NoFantasy
f1fb9afa43 [11264] Add script effect of spell 44364
Signed-off-by: NoFantasy <nofantasy@nf.no>
2011-03-19 11:16:03 +01:00
VladimirMangos
3c9f268b53 [11263] Revert "[11262] Revert "[11261] Check gaps in quest RewChoiceItem* data.""
This reverts commit 714d48a99e2ccc9404b34ebcfec50b2d8300fc46.

Additiona reserch show that no any know cases when data in RewChoiceItem* have gaps
except detected wrong data cases. So check good have in 3.x/2.x for better data intergrity checks.
2011-03-18 18:57:26 +03:00
VladimirMangos
24545a6162 [11262] Revert "[11261] Check gaps in quest RewChoiceItem* data."
This reverts commit a2d5f153c2d0256ad943a48442535730894e5d5e.

Only 1.x client have this problem.
2011-03-18 01:42:40 +03:00
VladimirMangos
5fce047e69 [11261] Check gaps in quest RewChoiceItem* data.
Client can crash if data not continues.

Thanks Chero and Joey for help in research problem ^^
2011-03-17 21:47:29 +03:00
zergtmn
df89544baa [11261] Get rid of two const_casts by storing const char* instead of char* 2011-03-17 12:17:31 +05:00
VladimirMangos
b588ea9db3 [11260] Add wrapper for creature vistual item set. 2011-03-16 20:21:45 +03:00
zergtmn
a6d155fc54 [11259] Move scheduled scripts counter to ScriptMgr
Also cleanup forward declarations.
2011-03-16 20:01:10 +05:00
Vinolentus
dee6d712c4 [11258] Typo in ObjectMgr::LoadItemConverts()
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2011-03-16 16:50:24 +03:00
Hundekuchen
f1a880a4ed [11257] Fix overwrite spells 33649 and 20572, other cases with same icon.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2011-03-16 03:36:57 +03:00