* Higher ranks are now automatically filled when not listed in spell_threat
* Added some loading checks to detect inconsistent data
Signed-off-by: Lynx3d <lynx3d@some-imaginary-isp.org>
There has been a security risk as the 'mangos' user had full access to all databases on the MySQL server.
The new create_mysql.sql file now gives more restrictive rights so that the 'mangos' user can only do what he really needs to do.
If you have already set up the DB and want to make sure, that it's more secure, open up the MySQL doc about the 'REVOKE' command and revoke all rights for that user from any other db. Alternatively you can revoke ALL rights from the 'mangos' user and then re-grant him as done in the file.
* calcThreat() is also called in addThreat() when given proper parameters,
and division by 'size' is commutative
* threat redirection is also handled in addThreat() again
It may have been faster, but unfortunately made the aggressor threatened by his enemies instead of the opposite...
In case Player heals himself, this is of course pointless as he chooses target himself, hence it had no real effect at all.
Some non-passive spells autocasted at shapeshift but without fix
in case already active form at like spell learning it not has been casted
in different from passive similar spells.
This is fix apply dodge chance part of spell 17002 for described case.
Some spells have procCharges > 0 and in same time maxStack > 1. It's support has been implemented more year ago
but current way work with single aura from stack remove at proc always made some spells work wrongly
(7 spells (with ranks) in 3.3.5a). In fact only 3 spell (with ranks) need this "one from stack" way and
all form its have similarity: Its apply max stack from start and decrease stacks at proc hit.
Another prove for correctness this way: in 2.x exist single spell with charges and maxstack that expect full aura stack remove.
So implemented opposition way: normal aura proc remove always full aura holder stack.
Special 3 cases have overwrite code for work with stack in correct for its way.
Fixed work:
* items 31857 and 50259
* recipe 46027 effects.
* talent 63730 and ranks
Affected by code changes talents 51528 and 55166 tested and work.
Spell 34026 use similar decrease stack at hit but req. independent patch for full implemention, so not work.
This will avoid show unexpected "gain Name Name(2) Name(N)" spam in log.
Maybe exist more nice way seelct like spells instead raw listing but i not see currently it.
Aura holder unlock called later by code.
This prevent unexpected real aura delete at early effect aura proccessing
and crash at next effect aura proccessing.
* Fishing now prowide junk loot at fail skill check.
This can be disabled for old way work using SkillFail.Loot.Fishing option.
Junk loot expected to be listed in fishing_loot_template entry 0.
* Fishing can gain skill grow at skill fail check case.
Controlled by SkillFail.Gain.Fishing option.
* Fishing from fishing pool gameobject can't be fail.
Controlled by SkillFail.Possible.FishingPool
Also clarify context for remove ghost auras place after set alive state.
This let get more expected results at remove ghost speed aura.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
