Commit graph

1534 commits

Author SHA1 Message Date
ApoC
f3fa9bf5e5 [8184] Added same handling for non existing excludeTargetAuraSpell as for excludeCasterAuraSpell
* This fix casting 10278 and ranks to targets with 61987

Signed-off-by: ApoC <apoc@nymfe.net>
2009-07-15 23:34:56 +02:00
VladimirMangos
9a0abf0e01 [8183] Some gameobject despanw related fixes
* Implement use `consumable` field in gameobject template for gameobject required explcit despawn at use.
* Move gameobject template fields cech function from Gameobject to gameobject template class, and update callers.
* Cast spells at gameobject use with gameobject guid as original caster guid, as already used in some other cases.
2009-07-15 06:32:08 +04:00
Ambal
58209ee79a [8182] Store and use Map* pointer in WorldObject instead map ids for speedup
Also some code logic cleanups.
Changes let make more cleanups in base map access and other places,
but this chnages not inlcuded in patch.

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-07-15 02:13:52 +04:00
ApoC
fcb34b3928 [8181] Prevent passing negative values into IsWithinDist() in stealth detection
* This should fix wrong stealth detection for high level differencies

Signed-off-by: ApoC <apoc@nymfe.net>
2009-07-14 19:32:47 +02:00
VladimirMangos
58a292e99c [8180] Drop dead code for old version 28730. It not have another way to work (from 3.0.2) 2009-07-14 05:31:12 +04:00
VladimirMangos
1363605cfc [8179] Fill spell_check table by data for dummy effect (0 spell family), some code cleanups. 2009-07-14 05:13:29 +04:00
VladimirMangos
12ee5cdc08 [8178] Fixed absent break in spell targeting code. 2009-07-14 03:41:12 +04:00
ApoC
2b09bb19eb [8177] Fixed calling SummonedCreatureDespawn from TemporarySummon::UnSummon
* If we call AddObjectToRemoveList m_inWorld is set to false and
  ObjectAccessor::GetUnit always returns NULL.

Signed-off-by: ApoC <apoc@nymfe.net>
2009-07-13 22:16:06 +02:00
VladimirMangos
c96f8e3d9f [8176] Forbid using some monster movement flags (that can crash client) in creature*_addon tables.moveflag tables field.
Also refactoring creature addon tables loading.
2009-07-13 23:38:27 +04:00
VladimirMangos
647e1c5a8b [8175] More fixes for 33878/33876 and ranks.
* Apply SPELL_AURA_MOD_MECHANIC_DAMAGE_TAKEN_PERCENT in melee binus for special attacks
* In damage calulcation spell 5221 and ranks considered have MECHANIC_BLEED.
* Drop more dead code related to 33878/33876 and ranks.
2009-07-13 18:48:11 +04:00
ApoC
9759a2279c [8174] Fixed typo in IsSpellHaveAura
* Correct cast DBC data to AuraType instead of SpellEffect.

Signed-off-by: ApoC <apoc@nymfe.net>
2009-07-13 15:14:10 +02:00
VladimirMangos
2dee7750e4 [8173] Fixes for 1822 and ranks base at spell_check detection
* Update AP bonus per tick to 0.18 as expected in 3.0.2 and later.
* Better spell selction to avoid unrelated spells for AP bonuses
2009-07-13 15:58:37 +04:00
VladimirMangos
2ed6642539 [8172] Drop dead code for 33878/33876 and ranks.
Detected by spell_check: not have now dummy aura but have
SPELL_AURA_MOD_MECHANIC_DAMAGE_TAKEN_PERCEN for proper mechanic.
2009-07-13 15:03:09 +04:00
VladimirMangos
d09615b2e5 [8171] Restore work double damage chance for spell 35290 and ranks.
It has been broken at client switch and detected by spell_check data.
2009-07-13 04:31:44 +04:00
VladimirMangos
fe1693a7da [8170] Fill spell_check by data form SpellEffect.cpp until end of Spell::EffectSchoolDMG.
2 error and 1 spell mask duplicate with strnage differences specially not fixed for
show .debug spellcheck work ;)
2009-07-13 04:00:11 +04:00
VladimirMangos
f99f477fe8 [8169] Implement new optional table spell_check and console command .debug spellcheck
* Table expected to be store data mirror same data in code:
  - explicit spell ids with related expected spell properties like effects, spell family or auras
  - implicit requirements for select some spell sets like spell family masks, icons or visual values
* For check can be used .debug spellcheck _console_ only command.
* Main purpose table and related command check code parts for outdated data at client switch.
  It also can be used for check data in patch writing time to be sure code correctness.
2009-07-12 22:15:56 +04:00
KAPATEJIb
3b47b66ba9 [8168] Fixed typo in .lookup taxinode output.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-07-12 16:16:18 +04:00
VladimirMangos
7f3f21ee1a [8167] Use more consistence debug command handler names and move its code to debugcmds.cpp 2009-07-12 16:00:28 +04:00
VladimirMangos
f84a68553c [8166] Add support for 32-bit hex format in addition to 64-bit version 2009-07-12 15:59:58 +04:00
ApoC
5b209bced4 [8165] Correctly add quest talent points count for characters on lvl 55.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-07-12 00:38:06 +02:00
Lutik
04a5a674d2 [8164] Implement engineering boots permanently enchantment 55016 effect.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-07-12 01:55:44 +04:00
SeT
e6d40697a1 [8163] Fixed typo and wrong check affecting threat calculation.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-07-12 00:18:28 +04:00
ApoC
0dc7ea6cc2 [8162] Fixed applying random enchantments to quest rewarded items.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-07-11 21:52:35 +02:00
ApoC
45eda48693 [8161] Partial revert and fix of my prev. commit in Aura::SetStackAmount
* Aura should be refreshed also when stackAmount == m_stackAmount
  this fixing problem that aura not refreshed if you have already full stack
  and cast "stack spell" again on target

Thanks Corfen for problem reporting and testing

Signed-off-by: ApoC <apoc@nymfe.net>
2009-07-11 19:13:01 +02:00
VladimirMangos
aed2a9f9b3 [8160] Now finally correct extraction uint16 enchantment id from uint32. 2009-07-11 19:38:16 +04:00
VladimirMangos
fcc1acfa83 [8159] Restore show item enchantments visual effects in character enum list. 2009-07-11 06:28:45 +04:00
VladimirMangos
50dbfadcb3 [8158] Update playercreateinfo_action base at UDB data for this table.
* Some fixes added for used UDB data base at not applied old mangos sql update and drop some wrong data.
* Primary key added to avoid button duplicates for (race,class) pair.
* This update expected to fix recently problems with empty action bars for new created characters

Note: This sql update not affect existed characters.
2009-07-10 22:24:04 +04:00
VladimirMangos
104158d93d [8157] Fixes and some tables support finish for pleays pdumps.
* Restore mark character with duplicate for rename at login
* Restore save mail item_text data
* Finish implementaion for propertly load item_text data.
2009-07-10 06:39:38 +04:00
VladimirMangos
1b8ad033c5 [8156] Some mail show flags use. 2009-07-10 06:38:23 +04:00
VladimirMangos
02caaf3421 [8155] Move unneeded include from header. 2009-07-10 06:37:34 +04:00
ApoC
c703ce8bfd [8154] Export only needed method from TemporarySummon class instead of whole class.
Change suggested by Vladimir

Signed-off-by: ApoC <apoc@nymfe.net>
2009-07-09 13:11:52 +02:00
NetSky
394cf9264d [8153] Fixed some implicit float->int cast warnings.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-07-09 11:10:28 +04:00
ApoC
44e8c3374f [8152] Class TemporarySummon exported.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-07-09 04:16:05 +02:00
Win32
03926619d9 [8151] Fixed some format warnings and typos.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>

SOme changes rewrited with using [8150]
2009-07-09 01:09:12 +04:00
VladimirMangos
e0ddcd6ead [8150] Provided short name for portable format specifier for size_t values 2009-07-09 00:26:57 +04:00
XTZGZoReX
8b82154988 [8149] Use formula instead hardcoded value for CENTER_GRID_CELL_ID calculation.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-07-08 23:25:32 +04:00
yad02
d583fd7f54 [8148] Remove zthread.vcproj GUID references from mangosdVC80.sln & mangosdVC90.sln files
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-07-08 22:54:23 +04:00
VladimirMangos
3bfe549a2b [8147] Some fixes and cleanups in mind control and charmed code. Mind control stil not finished.
* Allow command to mind controlled unit attack target at client. Rename related flag to UNIT_FLAG_PLAYER_CONTROLLED.
* Move code for pet action bar remove at client side to new function Player::RemovePetActionBar
* Not allow cast spells with SPELL_AURA_MOD_POSSESS and SPELL_AURA_MOD_POSSESS_PET by non-players and simplify related code base at this.
2009-07-08 20:09:33 +04:00
ApoC
1ad013e25b [8146] Fixed handling of eventchance for CreatureEventAI.
Check event chance after timers advances othewise event is
not scheduled to next time period and event chance is again
checked on next AI update.

Signed-off-by: ApoC <apoc@nymfe.net>
2009-07-07 23:01:28 +02:00
Ambal
2d25d7f8bc [8145] Use constant name instead not-safe explicit value.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-07-07 23:04:02 +04:00
ApoC
17d0cda637 [8144] Forgotten uninitialized value fix.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-07-07 19:42:10 +02:00
ApoC
4b4eb0a6d5 [8143] Fixed Aura::IsCritFromAbilityAura
* If not applied critical damage bonus don't clasify tick as critical.

Signed-off-by: ApoC <apoc@nymfe.net>
2009-07-07 19:36:37 +02:00
ApoC
5d4b581009 [8142] Remade precast spell system to be more similar to trigger spell system.
* Removed runtime allocation of list
* Methods and defines from precast spell system and trigger system moved closer
  to each other

Signed-off-by: ApoC <apoc@nymfe.net>
2009-07-07 16:15:30 +02:00
QAston
42300153ce [8141] Comment fix.
I would like to also appology to QAston for not mentioned him in
my prev. commit (db13c2fe18ff3953851eaaf86922ee57510e556a) as patch author.
I am sorry.
ApoC

Signed-off-by: ApoC <apoc@nymfe.net>
2009-07-07 14:50:17 +02:00
ApoC
0f6d312e59 [8140] Fixed dummy spell proc for 31876 and ranks.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-07-07 00:53:55 +02:00
ApoC
fccba20c9d [8139] Implemented aura SPELL_AURA_ABILITY_PERIODIC_CRIT(286).
This commit affects spells 49868, 58435, 63068, 63091, 63503,
64915, 64925.

Signed-off-by: ApoC <apoc@nymfe.net>
2009-07-06 22:48:34 +02:00
VladimirMangos
c8bb0c75a3 [8138] Prevent stacking pet mind control auras. Thanks to NetSky for reset. 2009-07-07 00:13:39 +04:00
hunuza
38197b539f [8137] Init player display id + native display id on login.
* Temporary reset of display id on save no longer needed.
* Players always have the right model for their gender.

Signed-off-by: hunuza <hunuza@gmail.com>
2009-07-06 18:18:01 +02:00
ApoC
84e46d76e3 [8136] Fixed aura refresh on modify stack by negative amount.
When decreasing stack amount of aura, aura should not be
refreshed to full time. This should only happen on increasing
stack.

Signed-off-by: ApoC <apoc@nymfe.net>
2009-07-06 15:36:49 +02:00
VladimirMangos
5d8bd14d38 [8135] Cast quest rewarded spells after mark spell as completed.
Some spell have spell_area requirement for cast (for later re-apply)
2009-07-06 16:13:51 +04:00