Commit graph

4966 commits

Author SHA1 Message Date
VladimirMangos
92e9670a11 [10492] Fixed crash in debug output for some data.
It well known at account data loading if character/account have
in account data string look like pritf format string (with %s for example)

Thanks for research porblem to jwo@lighthouseapp.com!
2010-09-17 00:35:04 +04:00
VladimirMangos
d83a7dbcd9 [10491] Search player in player list in update fields data prepare is bad idea. 2010-09-16 22:51:59 +04:00
nos4r2zod
6c2414b7d2 [10490] Arena ratings chnages is signed, fix debug string accordingly.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-09-16 20:27:24 +04:00
NoFantasy
bb7792940b [10489] Correct some typos in comments for SCRIPT_COMMAND*
Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-09-15 21:34:27 +02:00
NoFantasy
9aa683f0e9 [10488] Fix checking text id's for creature_movement_template
Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-09-15 11:57:18 +02:00
NoFantasy
8b10ac9474 [10487] Implement SCRIPT_COMMAND_MOVEMENT(20) to start/change movement
datalong can be 0:idle, 2:random, 3:waypoint. In case 3, creature must have a existing creature_movement_template.
Command start movement for source of script. If source is not creature but target is, it will apply to target.
Optionally creature entry can be defined (datalong2) and start movement for this if found nearby (search radius defined in datalong3).

Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-09-15 11:48:51 +02:00
Laise
abbf4f5331 [10486] Use casterGUID check for delaying holder since possible stacking same spell from different casters 2010-09-15 11:36:04 +02:00
darkstalker
63cdd66bcb [10485] Check school mask for SPELL_AURA_MOD_AOE_DAMAGE_AVOIDANCE
* Some spells expect this.
* Check SPELL_AURA_MOD_PET_AOE_DAMAGE_AVOIDANCE just for similarity,
  currently no spels with aura 310 with special school masks.

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-09-15 03:17:38 +04:00
VladimirMangos
f0956e258c [10484] Use for auraholde/aura GetStackAmount uint32 result.
uint32 result used in most expressions for stack calculation/compare
Alos uint8implicitly casted to int by C++ in expressions that generate unexpected
signed/unsigned warnings in comparisons (uint8 +1) > uint32 and similar.
2010-09-14 21:30:42 +04:00
Lynx3d
a3e62d43b0 [10483] Finally add README to vmap_assembler 2010-09-14 16:25:23 +02:00
NoFantasy
921dda56ba [10482] Add basic function MoveWaypoint() to manually start creature waypoint path
Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-09-14 12:43:04 +02:00
NoFantasy
3027d4ba61 [10481] Use prefix m_ for member variable in motionMaster
Some additional code style cleanup.

Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-09-14 10:52:57 +02:00
NoFantasy
d7994c1df4 [10480] Fix a bug causing creature dynamic flags to be removed at normal loot preparation.
In addition add use of UNIT_DYNFLAG_TAPPED_BY_PLAYER
Added check to see if creature is tapped for isAllowedToLoot()

Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-09-13 10:34:53 +02:00
darkstalker
919dc87bac [10479] Implement heak absorb for periodic heal
Also fix SMSG_PERIODICAURALOG for periodic heal for 3.5.5

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-09-13 03:10:10 +04:00
VladimirMangos
6af66f1ae4 [10478] Implement item 49623 visual effects.
Original patch provided by Darkruler.
2010-09-13 02:12:06 +04:00
faramir118
f8c258608f [10477] Fixed heal amount for some cases heal absorb
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-09-12 20:35:18 +04:00
Laise
b91f914dbc [10476] Fix 31228 and ranks 2010-09-12 16:52:26 +02:00
VladimirMangos
84a915e1b1 [10475] Implement SPELL_AURA_HEAL_ABSORB (301)
Used for example in spells 66237 and 70659.

Also rename CalculateAbsorbAndResist -> CalculateDamageAbsorbAndResist
2010-09-12 02:45:26 +04:00
DasBlub
ae53d49352 [10474] Cleanup vmap_assembler
* Drop dead code
* Use std::string instead of char*
* Use std::cout instead of printf()

Signed-off-by: Lynx3d <lynx3d@some-imaginary-isp.org>
2010-09-12 00:28:56 +02:00
LordJZ
31ea979c7c [10473] Fix structure SMSG_SPELLHEALLOG for 3.5.5
This also fix proper show critical heals

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-09-12 01:27:57 +04:00
VladimirMangos
8eb47efddc [10472] Implement SPELL_AURA_MOD_PET_AOE_DAMAGE_AVOIDANCE (310)
Original patch provided by rsa
2010-09-12 00:20:35 +04:00
DasBlub
16f912190f [10471] Drop vmap_debugger.
After new vmaps version it not work and useless.

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-09-11 15:03:53 +04:00
Vinolentus
73a85b0989 [10470] Fixed totem owner faction/level set for creature onwer case.
When totem created creature owner alos not in world yet.

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-09-11 14:53:58 +04:00
VladimirMangos
54d991ef3a [10469] Rename some opcode handler to better follow used naming style 2010-09-11 14:38:22 +04:00
Patman64
ad23b7ca05 [10468] Typos in comments in recent patches.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-09-11 12:10:30 +04:00
tester20tester20 tester20
7785daf2f9 [10467] Implement proper triggering for spell 34477, 57934
Signed-off-by: VladimirMangos <vladimir@getmangos.com>

Also fixed charges amount (1) for main spell auras.
2010-09-11 02:31:46 +04:00
Toinan67
4d30b464b4 [10466] Proper reset threat rediraction for existed spells.
In 3.5.5a this is: 34477, 57934, 59665 and triggered spells.

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-09-11 01:09:22 +04:00
ascent
88cc2d440f [10465] Implement SPELL_EFFECT_REDIRECT_THREAT
Note: all spells with effect expect additional code for redirection reset.
Until code adding redirection work longer that expected.

Signed-off-by: VladimirMangos <vladimir@getmangos.com>

Patch partly rewrited with move new data into HostileRefManager
and added redirection to threatAssist. Also bug fixed with
redirection threat to unit not in hostile list yet.
2010-09-11 00:35:13 +04:00
DasBlub
f441216aa0 [10464] Revert a part of [10463] and move them back to the .gitignore file in the sub-directory
Signed-off-by: XTZGZoReX <xtzgzorex@gmail.com>
2010-09-10 22:11:35 +02:00
DasBlub
fb2f74e4c9 [10463] Clean up the .gitignore files.
* Move the settings for VS and CMake files to /.gitignore
* Drop now unused .gitignore files

Signed-off-by: XTZGZoReX <xtzgzorex@gmail.com>
2010-09-10 19:29:52 +02:00
VladimirMangos
aa90aa8fdf [10462] Implement spell 6495
Also implement proper work CMSG_FAR_SIGHT.
This packet control switch view point from far sight object to caster
and back wihtout modify far sight object seelction.
2010-09-10 05:32:51 +04:00
silviu2009
1341345216 [10461] Fix error message in extractor tool
Signed-off-by: Lynx3d <lynx3d@some-imaginary-isp.org>
2010-09-09 22:41:39 +02:00
VladimirMangos
d334f9fab8 [10460] Fixed unexpected area aura stacking from same caster at spellmods reapply.
In fact it general problem possible with area auras if it re-casted
non-standard way from code. But known only test case for mangos-0.12 branch.

Thanks to ciphercom for reportand original research of problem source.
2010-09-09 23:34:56 +04:00
VladimirMangos
77148f0e60 [10459] Restore update area aura values at caster/around targets.
For example, at related improvement talent learn by caster.
It has been disabled in aura holder code changes.
2010-09-09 16:28:18 +04:00
NoFantasy
334398b3f7 [10458] Changes to corpse decay/respawn times for creatures
*CORPSE_DECAY values adjusted (Rare/RareElite values are guessed) with more proper.
*RATE_CORPSE_DECAY_LOOTED is now 0.0 as default and a modifier of the creatures spawntimesecs are used for corpse decay.

Respawn time for creature is now set at death (result: database spawntimesecs are in most cases the time it takes from kill to respawn)

Overall, this will affect four things:
* corpse will stay visible longer before looted
* corpse will stay visible longer after looted, when creature has long respawn time
* creature without loot will "skip" the default decay times and then fix a "should respawn almost instant" -problem
* creature with loot and very short respawn time may respawn instantly after looted

Signed-off-by: NoFantasy <nofantasy@nf.no>
2010-09-09 11:58:53 +02:00
Tequila
c196045d15 [10457] Fix proc of 51692 and ranks
Signed-off-by: Laise <fenrisse@gmail.com>
2010-09-08 11:53:30 +03:00
zergtmn
7092137ead [10456] Implement 60764
Signed-off-by: Laise <fenrisse@gmail.com>
2010-09-08 11:36:22 +03:00
Laise
e115f635ef [10455] Add missing break, thanks to nos4r2zod 2010-09-08 11:28:40 +03:00
dpedroia15
326fff975b [10454] Fix 54821 proc
Signed-off-by: Laise <fenrisse@gmail.com>
2010-09-08 11:25:48 +03:00
Laise
0cb6f7be0c [10453] Fix disease consume part of 49020 and ranks 2010-09-08 10:47:41 +03:00
Veretos
812383ac8c [10452] Typo in World field.
Signed-off-by: unknown <vladimir@getmangos.com>
2010-09-07 16:52:53 +04:00
narma
5dbb561b50 [10451] Replace ASSERT by MANGOS_ASSERT
Signed-off-by: Laise <fenrisse@gmail.com>
2010-09-07 14:27:30 +03:00
VladimirMangos
72414ad03b [10450] Skip wrong guid movement packets.
Also fix src/game/SharedDefines.h line ends corrupted in prev. commit. :/
2010-09-06 18:35:03 +04:00
Darkrulerz
214c65baa1 [10449] Typos in enum names and comments
Also typos find by darkstalker and Neo2003

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-09-06 15:48:37 +04:00
VladimirMangos
e3d9ebe81e [10448] Use base run speed * 2 as fall speed.
It equal to base flight speed and not dependent from real creature speed as expected.
2010-09-05 23:02:06 +04:00
Lynx3d
ddc42c5491 [10447] Certain compilers refuse to erase const_iterator... 2010-09-05 11:26:12 +02:00
VladimirMangos
425375687c [10446] Small fix for single target auras: remove caster only auras
Avoid remove different caster aura if target have similar diff caster auras
in case when auras from diff casters allowed for spell.
2010-09-05 08:54:03 +04:00
VladimirMangos
dfc9966d3b [10445] Re-implement in more safe way single cast spell targets system.
It also fix case when target can unexpected lost single target aura at phase switch
in case when target still visible in new phase (pet for example)
2010-09-05 07:47:45 +04:00
KiriX
6e6936c321 [10444] Fixed scripted AI init for TemporarySummon/Totem summon code
Call AIM_Initialize before adding to map instead after calling.
This make this call order similar other cases.

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-09-05 03:59:45 +04:00
zhenya
e621af3b97 [10443] Fixed expected packet size for SMSG_SET_PROFICIENCY
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2010-09-05 00:54:26 +04:00