Commit graph

1873 commits

Author SHA1 Message Date
ApoC
ef2992f175 [8673] Typo fix from prev. commit. :(
Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-18 19:57:38 +02:00
ApoC
3558829283 [8672] Fixed condition in prev. commit.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-18 19:33:04 +02:00
XTZGZoReX
0e1854a936 [8671] Correctly send SMSG_PET_TAME_FAILED with appropriate value when taming fail instead of spell fail.
I also removed conditions from Spell::EffectTameCreature which are checked in Spell::CheckCast.

Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-18 19:16:48 +02:00
pasdVn
906b2784a2 [8670] Apply SPELL_AURA_MOD_EXPERTISE in related hit chance calculations for creatures
(backported from commit 315a1cd)

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-10-18 18:28:12 +04:00
Seizerkiller
990824a88c [8669] Apply creature DB dmg modifier to base damage instead full.
This fix problem with unexpected fixed damage spells scaling.

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-10-18 18:15:06 +04:00
balrok
81e79ce199 [8668] change log: outError to outDebug typo in AddHonor 2009-10-18 14:18:13 +02:00
seirge
7eda96614d [8667] Correctly respawn pooled object in case the same object is selected for respawn.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-18 12:10:42 +02:00
ApoC
df3cc2ce00 [8666] Sorted switch for dummy effect spell generic part by spell id.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-18 12:10:32 +02:00
hunuza
ec10a5bf3c [8665] Correctly implement XP bonus auras.
Signed-off-by: hunuza <hunuza@gmail.com>
2009-10-18 11:44:01 +02:00
VladimirMangos
c0ffd1b48c [8664] Update auras list notes for 3.2.2a state 2009-10-18 07:22:26 +04:00
VladimirMangos
9a9ecddea3 [8663] Implement aura SPELL_AURA_MOD_ATTACKER_SPELL_CRIT_DAMAGE (205) 2009-10-18 06:21:04 +04:00
VladimirMangos
0a65c6218c [8662] Typo fixes in aura names. 2009-10-18 05:25:19 +04:00
VladimirMangos
2e884f4228 [8661] Fixes and improvments in absorb/reduction damage ignore auras work.
* Use stored in aura amount percent damage ignore for auras SPELL_AURA_MOD_IGNORE_ABSORB_FOR_SPELL
* Implement apply percent damage ignore for absorb (SPELL_AURA_MOD_IGNORE_ABSORB_SCHOOL (194))
  and redunction (SPELL_AURA_MOD_IGNORE_DAMAGE_REDUCTION_SCHOOL (269)).
  Later need recheck what from this 2 auras applied to armor reduction
  (currently 269 used only in single spell and this spell is single affecting armor
  and single normal school damage applied with 194 aura)
  Also unclear is this must applied to DoTs, expected that not need.
* Implement talent 53375 boots for spell 31884.
2009-10-18 05:02:33 +04:00
hunuza
2412777007 [8660] Fix spell triggering of spell 25371.
Signed-off-by: hunuza <hunuza@gmail.com>
2009-10-17 11:07:29 +02:00
VladimirMangos
9fd87a644b [8659] Restore less restcricted call format for Unit::AddThreat
Mostly for scripting use, core cases already fixed anyway.
2009-10-17 12:39:26 +04:00
VladimirMangos
b258a17ba4 [8658] Threat calculation fixes and improvements.
* Add single arg version Unit::AddThreat for just adding to threat list.
* Req. provide schollmask and crit flag for any real threat value for proper threats mod apply.
* Send crit flag in DealDamage as MELEE_HIT_CRIT for spell damage for later send to threat call.
* For not affected by modifiers threat values use SPELL_SCHOOL_MASK_NONE.
* Implement aura SPELL_AURA_MOD_CRITICAL_THREAT (used only in itemset 529 effect).
2009-10-17 11:02:30 +04:00
ApoC
ba62cdbe8f [8657] Mark spell 44689 as negative.
This allows aura to be counted down in logoff.

Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-17 00:56:39 +02:00
ApoC
aa42097331 [8656] Removed wrong static keyword.
Thx Vladimir for pointing it out.

Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-17 00:33:30 +02:00
VladimirMangos
29444467a9 [8655] Remove problematic defines from Common.h
Its create conflicts with ACE code.
More cleanup need (with replace use ACE_OS function versions
but stuck for example still used old sockets libarary.
2009-10-17 02:25:28 +04:00
VladimirMangos
bc1f6c7d3f [8654] Allow loading some type gameobjects without diplay id set.
But make its always inviisble for client.
2009-10-17 02:16:36 +04:00
ApoC
45c9c136ba [8653] Implemented per map guids store.
This patch implements storing guid->object pairs on per map level, this leads
to less locking in ObjectAccessor in case of further multithreaded map update.

For case of cross map guid looking (auras cases) all maps are linked into
ObjectAccessor and can be traversed for this lookup.

Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-17 00:12:31 +02:00
ApoC
40b0612dfc [8652] Lock typo fixed.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-16 20:45:57 +02:00
VladimirMangos
cf7ec4c456 [8651] Not send unexpected reply whisper to sender for addon messages.
Thanks to Leo9@mangos.lighthouseapp.com for provided client side testing addons.
2009-10-16 17:51:50 +04:00
laise
adcfd1e078 [8650] Allow stacking some paladin spell auras.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-10-16 06:11:50 +04:00
VladimirMangos
a4d61a6988 [8649] Implement SPELL_AURA_MECHANIC_IMMUNITY_MASK (147) and related cleanups.
* Always use machanic masks in form (1 << (mech-1)), fix all cases.
* Imppement SPELL_AURA_MECHANIC_IMMUNITY_MASK (mostly boss/elite spells).

Note: db stored mechannic masks already stored in proper format so not affected.
2009-10-15 20:53:01 +04:00
qsa
369e50e068 [8648] Implement SPELL_AURA_MOD_HONOR_GAIN
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-10-15 15:04:36 +04:00
NoFantasy
4011433918 [8647] Use correct check in _BuildMovementUpdate, if creature can fly.
Signed-off-by: NoFantasy <nofantasy@nf.no>
2009-10-15 00:28:01 +02:00
NoFantasy
b780e2dd80 [8646] Add basic support for QUEST_FLAGS_PARTY_ACCEPT (2).
Signed-off-by: NoFantasy <nofantasy@nf.no>
2009-10-14 19:19:49 +02:00
XTZGZoReX
aff1a3e59f [8645] Cleanup code for config loading/store/access.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-10-14 20:48:16 +04:00
VladimirMangos
4d3e43e814 [8644] Add assert for catch not updated constant at DBC data changes. 2009-10-14 19:35:40 +04:00
NoFantasy
e973b082f4 [8643] Correct a few typos in debug log messages.
Signed-off-by: NoFantasy <nofantasy@nf.no>
2009-10-14 13:42:44 +02:00
NoFantasy
65965bc5fa [8642] Replace the Spanish word 'hostil' with the English one.
Signed-off-by: NoFantasy <nofantasy@nf.no>
2009-10-14 12:46:10 +02:00
NoFantasy
da4a1037e7 [8641] Add comment for two unknown UNIT_FLAG_
Signed-off-by: NoFantasy <nofantasy@nf.no>
2009-10-14 10:42:47 +02:00
ApoC
7eb95ed64b [8640] Puted back commented not obsolete but disabled code what i removed in [8637] by mistake.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-14 10:34:59 +02:00
VladimirMangos
ec2fd7396f [8639] Fixed tabs and trailing whitespaces. 2009-10-14 11:46:09 +04:00
ApoC
9fd4965299 [8638] For TARGET_FOCUS_OR_SCRIPTED_GAMEOBJECT check also if target type in DB is GameObject target.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-14 03:07:38 +02:00
ApoC
ed0b01c65c [8637] Added special check in load time for TARGET_FOCUS_OR_SCRIPTED_GAMEOBJECT, code cleanup.
- Added check for presence of implicit spell focus for TARGET_FOCUS_OR_SCRIPTED_GAMEOBJECT
- Avoid double creature lookup in loading code
- Code style cleanup
- Old commented code part removed

Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-14 02:38:52 +02:00
ApoC
901eea0813 [8636] Fixed patch intoduced in [8544]. Now targeting should work as main idea of patch intended.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-14 02:38:38 +02:00
pasdVn
c47cf7bd61 [8635] Rewrote bonus damage claculation
* calculation depends on the damageClass now
  ->SPELL_DAMAGE_CLASS_RANGED & SPELL_DAMAGE_CLASS_MELEE use MeleeDamageBonus()
  ->SPELL_DAMAGE_CLASS_MAGIC & SPELL_DAMAGE_CLASS_RANGED use SpellDamageBonus()
* changes/improvements in MeleeDamageBonus:
  -> improved criterions to apply bonuses
  -> implemented scaling of FLAT damage Bonus for non weapon damage based spells
  -> support of DOT's
  -> added pet's bonus damage for non weapon based spells
* general cleanup in CalculateSpellDamage() and MeleeDamageBonus()
* implemented global helper functions GetWeaponAttackType() and GetAuraTicks() in SpellMgr

Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-14 00:33:24 +02:00
balrok
29fde5f671 [8634] BattleGrounAV: fixed wrong strings at boss-dead
thx to henhouse
2009-10-13 21:59:49 +02:00
Derex
fd48113941 [8633] Fix possible build error at ASSERT redefine.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-10-13 20:49:13 +04:00
Pablo
85d8aaccd8 [8632] Fixed syntax for new autotools.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-12 23:02:28 +02:00
ApoC
d36a62cee4 [8631] Query fix for PGSQL.
Signed-off-by: ApoC <apoc@nymfe.net>
2009-10-12 14:34:38 +02:00
VladimirMangos
7c3f35c408 [8630] More fatigue/breath/fire times control in config.
DisableWaterBreath replaced by TimerBar.Breath.GMLevel so update configs if use.
2009-10-12 01:32:40 +04:00
balrok
01318dbc8c [8629] don't let eventaicreatures cast spells in stuns etc.
also small correction to feign death (unit could still turn around
to face his victim with this aura)
2009-10-11 22:42:07 +02:00
ApoC
2be50d4b95 [8628] Code cleanup.
Signed-off-by: ApoC <apoc@nymfe.net>
(cherry picked from commit 5aab292281cbd57d65960003451155cc5a92d25a)

Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-10-11 21:05:20 +04:00
SilverIce
023b13f348 [8627] Avoid not needed too oftent send update data, cleanups.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
2009-10-11 19:31:57 +04:00
NoFantasy
9cb356851c [8626] Add missing argument names in function declaration.
Signed-off-by: NoFantasy <nofantasy@nf.no>
2009-10-11 16:37:41 +02:00
balrok
02d45b4b54 [8625] feign_death cleanups
use an extra function for setfeigndeath()
like it's done with setfeared already..
allow to apply feigndeath on creatures too
avoid moving of creatures with feign death applied
and start attacking last victim when feigndeath disappears
2009-10-11 14:22:52 +02:00
balrok
f4081b2c6a [8624] fixed typo introduced in 8552
(it was commit e294da6bbf)

through that pickpocketing didn't work right
2009-10-11 13:55:04 +02:00