(based on insider42's repo commit 90de00d)
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
It include reverts commit ca99760e884d82219fff63ecf5f2ca87b02b5924
with less clean implemetation.
[patch 155] Fixed triggering of spell 55095 by 45524. Patch provided by me
(based on commit 90de00d)
* Now apply 4x bonus dependent from target health in time spell cast,
not from current health in tick.
* 4x bonus applied to own spell damage value, not to total taken damage.
npc_vendor.ExtandedCost can be negative now that meaning:
price excluded default item BuyPrice and use only abs(ExtandedCost) items).
For example expected used for item 36908.
Some negative spells have positive effects with targets not affected by negative effects of spell.
For example spell 45524 cast negative effecst to target and possitive effect to caster self.
For like possitive only target of negetive spell will not triggered negative proc events.
In last cases will avoid triggering glyph 43537 at caster at spell 43537 cast.
* Restore work with money loot.
* Old code sometime generate empty loot windows for normal loot and sometime skip its.
Code changed to be more consistent. Added new option Corpse.EmptyLootShow that control
show empty normal loot window in some cases enabled by default:
- if creature expected to be lootable but loot generated empty by some reasons.
- if creature can be skinnable
If option disabled thne code attempt avoid empty normal loot windows for empty cases.
* Possible fixed case instant despawn non-skinable creature after normal loot complete.
This will solve problem with summoned GO that does not appear before later, but does not solve problem with visual effects (which is a generic problem with many spells).
Signed-off-by: NoFantasy <nofantasy@nf.no>
Only use TalkedToCreature when gossip does not have any following sub menu (and of course when the prepared npc options does not include any gossip)
Signed-off-by: NoFantasy <nofantasy@nf.no>
* Show skinning tooltip only after creature loot
(when creature can be explcitly skinned).
* Allow reopen skinning loot if still have not looted items.
And update config version.
Also note: it not has been propertly updated in prev. time
when config version in .conf.in changed. It must be sync changed in
*.conf.in and in SystemConfig.h.in
* No reson have 6 copies near to exactly same code.
* This fix problem with apply attack power bonus in some case.
Thanks to Wowka321 for find and reseach problem.
Can be source very strange damage/absorb and any near stored/calculated in memory values. and crashes also.
Signed-off-by: VladimirMangos <vladimir@getmangos.com>
* damage - different direct damage calculation tracing
* combat - combat state updates, roll attack result and etc
* spell_cast - spell cast progress and aura apply
* .server log filter comamnd let temporary (until config reload or restart)
set log filters state. Or look at filters state.
* .server log level renamed from .server set loglevel but now let look at log level also.
* If player tap creature in group and leave then group will have access to creature loot if not disbanded
* If player tap creature and after join to group then creature loot will accesable only by player
* Also RewardPlayerAndGroupAtKill divided to simgle player and group reward versions used for group tap
and single player tap cases.
* Changes include (in fact as part cleanup) fix got NeedBeforeGreed locked item after expire roll timer
suggested by somedruid@mangos.lighthouseapp.com.
* Added cancel rolling at creatuer corpse remove.
* For NeedBeforeGreed and GroupLoot sued common code for prepare item roll.
